Changeset fc229f5 in Klonkt for test/url-linkify.test.js

Timestamp:

07/01/2026 10:20:25 PM (2 months ago)

Author:

roboburr <roboburr@…>

Branches:

main

Children:

e499b71

Parents:

2abd3d2

Message:

fix(fediverse): bracketed mentions/hashtags/URLs link and notify

The mention/hashtag/URL prefix classes required whitespace or '>' before the
token, so "(@user@server)", "(#tag)" and "(​https://…)" federated as plain text —
and a bracketed mention's target was never notified (real-world miss on a reply).
Opening brackets are now valid prefixes. Quote characters are deliberately NOT in
the class: a quote precedes attribute values, which must never match.

• src/services/ActivityPubService.js — prefix class [\s>] → [\s>([{] in linkHashtags, linkUrls, and both mention regexes (scan + per-handle replace).
• test/url-linkify.test.js — bracketed URL + hashtag link; attribute values stay untouched.
• CHANGELOG(.nl/.de).md — under Fixed.

Closes prutfolio-src-ovj.

Co-Authored-By: Claude <noreply@…>

File:

• test/url-linkify.test.js (modified) (1 diff)

test/url-linkify.test.js

@@ -40 +40 @@
 });
 
+test('a URL inside parentheses links, closing paren stays outside', () => {
+  const n = note('<p>site (https://example.com/a) hier</p>');
+  assert.match(n.content, /\(<a href="https:\/\/example\.com\/a"[^>]*>https:\/\/example\.com\/a<\/a>\)/);
+});
+
+test('a hashtag inside parentheses still links; quoted attribute values never match', () => {
+  const n = note('<p>leuk (#jazz) toch</p>');
+  assert.match(n.content, /\(<a [^>]*class="mention hashtag"[^>]*>#jazz<\/a>\)/);
+  // A quote precedes attribute values — the prefix class must NOT include quotes.
+  const n2 = note('<p>plaatje <a href="https://x.example/#frag">link</a></p>');
+  assert.equal((n2.content.match(/<a /g) || []).length, 1, 'href value untouched');
+});
+
 test('attribute values are untouched, standalone URLs still link (image stripped from content)', () => {
   const n = note('<p><img src="https://cdn.example.com/pic.png" alt=""> and https://example.org</p>');