Changeset 41a7637 in Klonkt for src/routes/posts.js

Timestamp:

06/24/2026 01:04:50 PM (3 months ago)

Author:

Robin Genis <roboburr@…>

Branches:

main

Children:

cc24fa1

Parents:

7f46112b

Message:

fix(activitypub): instant Send + confirmation on remote reply

Send now resolves+delivers in the background and immediately shows a 'Sent ✅'
confirmation, instead of awaiting delivery and redirecting to a raw AP-JSON URL
(which felt like nothing happened).

Co-Authored-By: Claude <noreply@…>

File:

• src/routes/posts.js (modified) (2 diffs)

src/routes/posts.js

@@ -518 +518 @@
   const site = res.locals.site;
   const uri = (req.query.uri || '').toString();
+  const sent = !!req.query.sent;
   let target = null;
-  try { target = await ActivityPubService.resolveRemoteNote(uri); } catch { /* ignore */ }
+  if (!sent) { try { target = await ActivityPubService.resolveRemoteNote(uri); } catch { /* ignore */ } }
   renderPage(req, res, 'pages/authorize-interaction', {
     pageTitle: 'Reageer via de fediverse',
@@ -525 +526 @@
     uri,
     target,
+    sent,
     siteTitle: site ? site.title : '',
   });
 });
 
-router.post('/authorize_interaction', requireSiteManager, async (req, res) => {
+router.post('/authorize_interaction', requireSiteManager, (req, res) => {
   const site = res.locals.site;
   const uri = (req.body.uri || '').toString();
   const text = (req.body.text || '').toString();
   if (site && uri && text.trim()) {
-    try {
-      const parent = await ActivityPubService.resolveRemoteNote(uri);
-      if (parent) await ActivityPubService.deliverReply(site, { postId: '', postSlug: null, parent, text });
-    } catch (e) { console.warn('[AP] remote reply failed:', e.message); }
-  }
-  // Send them to the post they replied to so they can see the thread.
-  res.redirect(uri && /^https?:\/\//i.test(uri) ? uri : (res.locals.siteUrlBase || '/'));
+    // Resolve + deliver in the background so Send responds instantly.
+    ActivityPubService.resolveRemoteNote(uri)
+      .then((parent) => parent && ActivityPubService.deliverReply(site, { postId: '', postSlug: null, parent, text }))
+      .catch((e) => console.warn('[AP] remote reply failed:', e.message));
+  }
+  res.redirect('/authorize_interaction?sent=1&uri=' + encodeURIComponent(uri));
 });