Changeset cc24fa1 in Klonkt

Timestamp:

06/24/2026 01:11:01 PM (3 months ago)

Author:

Robin Genis <roboburr@…>

Branches:

main

Children:

7d932ce

Parents:

41a7637

Message:

fix(activitypub): dedup guard on outbound replies (prevent double-send)

Skip delivery when an identical reply (same site, in_reply_to, content) already
exists — guards against the multi-click duplicates from the old slow Send.

Co-Authored-By: Claude <noreply@…>

File:

• src/services/ActivityPubService.js (modified) (1 diff)

src/services/ActivityPubService.js

@@ -455 +455 @@
     ? `<a href="${escHtml(parent.actor_url || parent.actor_uri)}" class="u-url mention">${escHtml(handle)}</a> ` : '';
   const content = `<p>${mention}${body}</p>`;
+  // Dedup: skip if the exact same reply was already sent (double-submit guard).
+  const dup = db.prepare('SELECT 1 FROM ap_outbox WHERE site_slug = ? AND IFNULL(in_reply_to, \'\') = ? AND content = ? LIMIT 1')
+    .get(site.slug, parent.object_uri || '', content);
+  if (dup) { console.log('[AP] outreply skipped (duplicate)'); return { duplicate: true, delivered: 0 }; }
   const id = crypto.randomUUID();
   iStmts().insO.run(id, site.slug, postId, postSlug || null, parent.object_uri || null, parent.actor_uri || null, handle, content);