Changeset 2b4252c in Klonkt for src/services/guardianship

Timestamp:

07/25/2026 09:15:34 AM (7 weeks ago)

Author:

Robin <roboburr@…>

Branches:

main

Children:

4f15f67

Parents:

af5b79b

Message:

Cross-instance follow-goedkeuring, gemodelleerd op de guardian-offer (§5.3)

Guardians die op een andere instance wonen kunnen nu een gated follow goedkeuren.
Zelfde gedistribueerde patroon als de adoptie-offer: de ward forwardt de follow
naar z'n guardians als een Offer(Follow); elke guardian houdt een kopie en ziet
'm in /guardian2; de guardian antwoordt met Accept/Reject naar de ward; de ward
telt quorum (bestaande follows.decide) en stuurt de gewone Accept(Follow) naar de
volger. Lokale guardians blijven zoals ze waren (push + lokale beslissing, geen
forwarding). Alles achter de shaer:followApproval-marker, dus normaal verkeer
onaangeroerd.

Changed files:
src/services/ActivityPubService.js

• gate: remote guardian krijgt Offer(Follow) (leg 1); lokale guardian push
• handleFollowApprovalInbox: Offer(Follow) -> review (leg 2), Accept/Reject -> decide+commit (leg 4)
• sendFollowDecision: guardian stuurt beslissing naar de ward (leg 3)
• dispatch-tak op shaer:followApproval vóór de handshake-dispatch

src/services/guardianship/follows.js

• guardian-side review-store (recordReview/getReview/listReviews/removeReview)

src/config/database.js

• ap_follow_reviews (PK slug,id): de guardian-kopie van een remote-ward-follow

src/routes/guardian2.js

• follow-requests toont ook reviews (remote); approve op een review = sendFollowDecision

test/follow-gating.test.js

• review-store test erbij

remarks: npm test 171/171. Spec-clausule §5.3 toegevoegd (forwarding gemodelleerd
op §3). Lokale/co-located flow ongewijzigd.

-robo
Co-Authored-By: Claude Opus 4.8 <noreply@…>

File:

• src/services/guardianship/follows.js (modified) (1 diff)

src/services/guardianship/follows.js

@@ -73 +73 @@
 export function remove(id) { stmts().del.run(id); }
 
-export default { recordPending, getPending, listForWard, decide, remove };
+// ── Guardian-side copy (cross-instance, modelled on the guardian offer): a
+//    gated follow on a REMOTE ward this account guards, forwarded here as an
+//    Offer(Follow). The decision is Accept/Reject sent back to ward_inbox. ──
+let _r = null;
+function rstmts() {
+  if (!_r) {
+    _r = {
+      ins: db.prepare(`INSERT OR IGNORE INTO ap_follow_reviews
+        (id, guardian_slug, ward_uri, ward_inbox, follower_uri, follower_handle, follower_icon, follow_json, created_at)
+        VALUES (?,?,?,?,?,?,?,?, CURRENT_TIMESTAMP)`),
+      get: db.prepare('SELECT * FROM ap_follow_reviews WHERE guardian_slug = ? AND id = ?'),
+      bySlug: db.prepare("SELECT * FROM ap_follow_reviews WHERE guardian_slug = ? AND status = 'pending' ORDER BY created_at DESC"),
+      del: db.prepare('DELETE FROM ap_follow_reviews WHERE guardian_slug = ? AND id = ?'),
+    };
+  }
+  return _r;
+}
+
+export function recordReview(guardianSlug, r) {
+  rstmts().ins.run(r.id, guardianSlug, r.wardUri, r.wardInbox || null, r.follower, r.followerHandle || null, r.followerIcon || null, r.followJson || null);
+  return rstmts().get.get(guardianSlug, r.id);
+}
+export function getReview(guardianSlug, id) { return rstmts().get.get(guardianSlug, id); }
+export function listReviews(guardianSlug) { return rstmts().bySlug.all(guardianSlug); }
+export function removeReview(guardianSlug, id) { rstmts().del.run(guardianSlug, id); }
+
+export default {
+  recordPending, getPending, listForWard, decide, remove,
+  recordReview, getReview, listReviews, removeReview,
+};