Changeset 4f15f67 in Klonkt

Timestamp:

07/25/2026 09:35:10 AM (7 weeks ago)

Author:

Robin <roboburr@…>

Branches:

main

Children:

0a686a0

Parents:

2b4252c

Message:

Ward-actor: manuallyApprovesFollowers true (FEP-633c §5.3)

Robin zag de bug: beta (een ward) adverteerde manuallyApprovesFollowers:false,
dus Mastodon nam aan dat een follow meteen geaccepteerd was terwijl wij 'm intern
gaten en GEEN Accept sturen. Een ward hoort manuallyApprovesFollowers:true te
adverteren zodat de volger 'verzoek verzonden' ziet tot de guardians goedkeuren.
Nu: true zodra de site guardians heeft, anders ongewijzigd (false).

Changed files:
src/services/ActivityPubService.js

• buildActor: manuallyApprovesFollowers = isWard (heeft guardians)

remarks: npm test groen. Bestaande non-ward-sites ongewijzigd.

-robo
Co-Authored-By: Claude Opus 4.8 <noreply@…>

File:

• src/services/ActivityPubService.js (modified) (2 diffs)

src/services/ActivityPubService.js

@@ -158 +158 @@
   const id = actorId(base, site.slug);
   const keys = getOrCreateKeys(site.slug);
+  // FEP-633c §5.3: a ward's follows are gated (guardians approve), so the actor
+  // MUST advertise manuallyApprovesFollowers:true — otherwise a follower's server
+  // (Mastodon) assumes auto-accept and shows "Following" while we hold it pending.
+  const isWard = (() => { try { return Guardianship.listGuardians(site.slug).length > 0; } catch { return false; } })();
   const actor = {
     '@context': AP_CONTEXT,
@@ -166 +170 @@
     summary: site.tagline || site.description || '',
     url: `${base}/${site.slug === site.primary_slug ? '' : 'user/' + encodeURIComponent(site.slug)}`,
-    manuallyApprovesFollowers: false,
+    manuallyApprovesFollowers: isWard,
     discoverable: true,
     inbox: `${id}/inbox`,