Changeset 0a93c15 in Klonkt for test/polls.test.js

Timestamp:

07/04/2026 05:44:17 PM (2 months ago)

Author:

roboburr <roboburr@…>

Branches:

main

Children:

da71f9d

Parents:

6ec0433

Message:

fix(ap): a poll keeps its cover art when federated

The real reason "Swimming Pools" (a music poll) showed a blank tile
after every earlier cover fix: applyPollToNote did delete note.image,
stripping the cover off the AS2 Question entirely — so it was never in
the federated poll, and no amount of consumer-side healing could bring
back what the origin never sent.

The comment justified it as "media + poll are mutually exclusive on
Mastodon", but that's true only of attachment (media). image is the
cover, which Mastodon ignores on any Note/Question anyway and Klonkt
reads to show the cover in feeds/the Cirkel. Keep attachment stripped,
keep image.

Verified with a new test: an embed/music poll (images suppressed → cover
in note.image) stays a Question, keeps note.image with its alt text, and
still has no attachment. Suite 46/46.

• src/services/ActivityPubService.js — stop deleting note.image in applyPollToNote
• test/polls.test.js — poll-keeps-cover test
• CHANGELOG(.nl/.de).md — Unreleased entry (3 languages)

Co-Authored-By: Claude <noreply@…>

File:

• test/polls.test.js (modified) (1 diff)

test/polls.test.js

@@ -42 +42 @@
   assert.ok(note.endTime, 'has an endTime');
   assert.ok(!('attachment' in note), 'no media on a poll (mutually exclusive on Mastodon)');
+});
+
+test('a poll KEEPS its cover in note.image (feeds show it; Mastodon ignores it)', () => {
+  // An embed/music poll suppresses image attachments (so Mastodon shows the
+  // player/embed card) and carries the cover in note.image instead — exactly
+  // the case that lost its cover when applyPollToNote deleted image.
+  const withCover = {
+    ...singlePoll, id: 'p1', slug: 'fav',
+    content: '<p>Pick one</p> [[embed:https://www.youtube.com/watch?v=abcdefghijk]]',
+    cover_image_url: '/media/post-images/cover.webp', cover_alt: 'Album art',
+  };
+  const note = AP.buildNote(BASE, site, withCover);
+  assert.equal(note.type, 'Question', 'still a Question');
+  assert.ok(note.image && note.image.url, 'the cover survives as note.image');
+  assert.ok(note.image.url.endsWith('/media/post-images/cover.webp'), 'absolute cover url');
+  assert.equal(note.image.name, 'Album art', 'alt text kept');
+  assert.ok(!('attachment' in note), 'still no media attachment on a poll');
 });