Changeset 0a93c15 in Klonkt

Timestamp:

07/04/2026 05:44:17 PM (2 months ago)

Author:

roboburr <roboburr@…>

Branches:

main

Children:

da71f9d

Parents:

6ec0433

Message:

fix(ap): a poll keeps its cover art when federated

The real reason "Swimming Pools" (a music poll) showed a blank tile
after every earlier cover fix: applyPollToNote did delete note.image,
stripping the cover off the AS2 Question entirely — so it was never in
the federated poll, and no amount of consumer-side healing could bring
back what the origin never sent.

The comment justified it as "media + poll are mutually exclusive on
Mastodon", but that's true only of attachment (media). image is the
cover, which Mastodon ignores on any Note/Question anyway and Klonkt
reads to show the cover in feeds/the Cirkel. Keep attachment stripped,
keep image.

Verified with a new test: an embed/music poll (images suppressed → cover
in note.image) stays a Question, keeps note.image with its alt text, and
still has no attachment. Suite 46/46.

• src/services/ActivityPubService.js — stop deleting note.image in applyPollToNote
• test/polls.test.js — poll-keeps-cover test
• CHANGELOG(.nl/.de).md — Unreleased entry (3 languages)

Co-Authored-By: Claude <noreply@…>

Files:

• CHANGELOG.de.md (modified) (1 diff)
• CHANGELOG.md (modified) (1 diff)
• CHANGELOG.nl.md (modified) (1 diff)
• src/services/ActivityPubService.js (modified) (1 diff)
• test/polls.test.js (modified) (1 diff)

CHANGELOG.de.md

@@ -5 +5 @@
 
 ## [Unreleased]
+
+### Behoben
+- **Umfragen behalten ihr Cover, wenn sie geboostet werden.** Eine Umfrage mit
+  Musik oder Embed wurde ohne Cover föderiert, sodass eine geteilte Umfrage eine
+  leere Kachel zeigte; das Cover reist jetzt mit.
 
 ## [1.3.4] — 2026-07-04

CHANGELOG.md

@@ -5 +5 @@
 
 ## [Unreleased]
+
+### Fixed
+- **Polls keep their cover art when boosted.** A poll with music or an embed was
+  federating without its cover, so a boosted poll showed a blank tile; the cover
+  now travels with it.
 
 ## [1.3.4] — 2026-07-04

CHANGELOG.nl.md

@@ -5 +5 @@
 
 ## [Unreleased]
+
+### Opgelost
+- **Polls behouden hun cover als ze geboost worden.** Een poll met muziek of een
+  embed federeerde zonder cover, waardoor een geboooste poll een leeg vak toonde;
+  de cover reist nu mee.
 
 ## [1.3.4] — 2026-07-04

src/services/ActivityPubService.js

@@ -890 +890 @@
   if (poll.closed) note.closed = poll.endTime ? new Date(poll.endTime).toISOString() : new Date().toISOString();
   note.votersCount = voters;
-  delete note.attachment;   // media + poll are mutually exclusive on Mastodon
-  delete note.image;
+  delete note.attachment;   // media ATTACHMENTS + a poll are mutually exclusive on Mastodon
+  // Keep note.image: it's the cover, which Mastodon ignores on a Question anyway
+  // (same as on any Note) but Klonkt reads to show the cover in feeds/the Cirkel.
+  // Deleting it stripped the cover off every boosted poll.
   return note;
 }

test/polls.test.js

@@ -42 +42 @@
   assert.ok(note.endTime, 'has an endTime');
   assert.ok(!('attachment' in note), 'no media on a poll (mutually exclusive on Mastodon)');
+});
+
+test('a poll KEEPS its cover in note.image (feeds show it; Mastodon ignores it)', () => {
+  // An embed/music poll suppresses image attachments (so Mastodon shows the
+  // player/embed card) and carries the cover in note.image instead — exactly
+  // the case that lost its cover when applyPollToNote deleted image.
+  const withCover = {
+    ...singlePoll, id: 'p1', slug: 'fav',
+    content: '<p>Pick one</p> [[embed:https://www.youtube.com/watch?v=abcdefghijk]]',
+    cover_image_url: '/media/post-images/cover.webp', cover_alt: 'Album art',
+  };
+  const note = AP.buildNote(BASE, site, withCover);
+  assert.equal(note.type, 'Question', 'still a Question');
+  assert.ok(note.image && note.image.url, 'the cover survives as note.image');
+  assert.ok(note.image.url.endsWith('/media/post-images/cover.webp'), 'absolute cover url');
+  assert.equal(note.image.name, 'Album art', 'alt text kept');
+  assert.ok(!('attachment' in note), 'still no media attachment on a poll');
 });