Changeset 0a93c15 in Klonkt for src/services/ActivityPubService.js

Timestamp:

07/04/2026 05:44:17 PM (2 months ago)

Author:

roboburr <roboburr@…>

Branches:

main

Children:

da71f9d

Parents:

6ec0433

Message:

fix(ap): a poll keeps its cover art when federated

The real reason "Swimming Pools" (a music poll) showed a blank tile
after every earlier cover fix: applyPollToNote did delete note.image,
stripping the cover off the AS2 Question entirely — so it was never in
the federated poll, and no amount of consumer-side healing could bring
back what the origin never sent.

The comment justified it as "media + poll are mutually exclusive on
Mastodon", but that's true only of attachment (media). image is the
cover, which Mastodon ignores on any Note/Question anyway and Klonkt
reads to show the cover in feeds/the Cirkel. Keep attachment stripped,
keep image.

Verified with a new test: an embed/music poll (images suppressed → cover
in note.image) stays a Question, keeps note.image with its alt text, and
still has no attachment. Suite 46/46.

• src/services/ActivityPubService.js — stop deleting note.image in applyPollToNote
• test/polls.test.js — poll-keeps-cover test
• CHANGELOG(.nl/.de).md — Unreleased entry (3 languages)

Co-Authored-By: Claude <noreply@…>

File:

• src/services/ActivityPubService.js (modified) (1 diff)

src/services/ActivityPubService.js

@@ -890 +890 @@
   if (poll.closed) note.closed = poll.endTime ? new Date(poll.endTime).toISOString() : new Date().toISOString();
   note.votersCount = voters;
-  delete note.attachment;   // media + poll are mutually exclusive on Mastodon
-  delete note.image;
+  delete note.attachment;   // media ATTACHMENTS + a poll are mutually exclusive on Mastodon
+  // Keep note.image: it's the cover, which Mastodon ignores on a Question anyway
+  // (same as on any Note) but Klonkt reads to show the cover in feeds/the Cirkel.
+  // Deleting it stripped the cover off every boosted poll.
   return note;
 }