| 1 | // FEP-7628 (Move actor, DRAFT) — the inbound half: an account our sites follow
|
|---|
| 2 | // announces a move, and our follows travel along. All network legs are
|
|---|
| 3 | // injected; the DB is in-memory, like the other AP tests.
|
|---|
| 4 | import { test, beforeEach } from 'node:test';
|
|---|
| 5 | import assert from 'node:assert/strict';
|
|---|
| 6 |
|
|---|
| 7 | process.env.DATABASE_PATH = ':memory:';
|
|---|
| 8 | process.env.PUBLIC_BASE_URL = 'https://test.example';
|
|---|
| 9 |
|
|---|
| 10 | const dbMod = await import('../src/config/database.js');
|
|---|
| 11 | const db = dbMod.default;
|
|---|
| 12 | dbMod.initializeDatabase();
|
|---|
| 13 | const { handleMoveInbox, buildActor } = await import('../src/services/ActivityPubService.js');
|
|---|
| 14 |
|
|---|
| 15 | db.prepare('INSERT INTO users (id, username, email, password_hash, role) VALUES (?,?,?,?,?)').run('u1', 'u1', 'u1@test', 'x', 'god');
|
|---|
| 16 | for (const [id, slug] of [['s1', 'radio'], ['s2', 'blog']]) {
|
|---|
| 17 | db.prepare('INSERT INTO sites (id, slug, title, owner_id, is_primary) VALUES (?,?,?,?,?)').run(id, slug, slug, 'u1', id === 's1' ? 1 : 0);
|
|---|
| 18 | }
|
|---|
| 19 |
|
|---|
| 20 | const OLD = 'https://oldhome.example/users/dj';
|
|---|
| 21 | const NEW = 'https://newhome.example/users/dj';
|
|---|
| 22 | const STRANGER = 'https://elsewhere.example/users/nosy';
|
|---|
| 23 |
|
|---|
| 24 | // The target actor doc the mover controls; the alsoKnownAs back-reference is
|
|---|
| 25 | // the proof both ends belong to the same person.
|
|---|
| 26 | const targetActor = (aka = [OLD]) => ({ id: NEW, type: 'Person', inbox: `${NEW}/inbox`, alsoKnownAs: aka });
|
|---|
| 27 | const move = (overrides = {}) => ({ '@context': 'https://www.w3.org/ns/activitystreams', id: `${OLD}#move-1`, type: 'Move', actor: OLD, object: OLD, target: NEW, ...overrides });
|
|---|
| 28 |
|
|---|
| 29 | // Stubs mirror the DB effect of the real followActor/unfollowActor, so the
|
|---|
| 30 | // handler's row bookkeeping is exercised without keys or delivery queues.
|
|---|
| 31 | let calls;
|
|---|
| 32 | const deps = (aka) => ({
|
|---|
| 33 | fetchActorFn: async () => targetActor(aka),
|
|---|
| 34 | unfollowFn: async (site, uri) => { calls.unfollow.push([site.slug, uri]); db.prepare('DELETE FROM ap_following WHERE slug = ? AND actor_uri = ?').run(site.slug, uri); },
|
|---|
| 35 | followFn: async (site, uri, autoBoost) => { calls.follow.push([site.slug, uri, autoBoost]); db.prepare('INSERT OR REPLACE INTO ap_following (slug, actor_uri, status, auto_boost) VALUES (?,?,?,?)').run(site.slug, uri, 'pending', autoBoost ? 1 : 0); },
|
|---|
| 36 | });
|
|---|
| 37 |
|
|---|
| 38 | beforeEach(() => {
|
|---|
| 39 | calls = { unfollow: [], follow: [] };
|
|---|
| 40 | db.prepare('DELETE FROM ap_following').run();
|
|---|
| 41 | db.prepare('DELETE FROM ap_blocks').run();
|
|---|
| 42 | db.prepare('INSERT INTO ap_following (slug, actor_uri, status, auto_boost) VALUES (?,?,?,?)').run('radio', OLD, 'accepted', 1);
|
|---|
| 43 | db.prepare('INSERT INTO ap_following (slug, actor_uri, status, auto_boost) VALUES (?,?,?,?)').run('blog', OLD, 'accepted', 0);
|
|---|
| 44 | });
|
|---|
| 45 |
|
|---|
| 46 | const following = (slug) => db.prepare('SELECT * FROM ap_following WHERE slug = ? ORDER BY actor_uri').all(slug);
|
|---|
| 47 |
|
|---|
| 48 | test('a third party cannot narrate someone else\'s move', async () => {
|
|---|
| 49 | const res = await handleMoveInbox(move(), { verifiedActor: STRANGER, ...deps() });
|
|---|
| 50 | assert.equal(res, 401);
|
|---|
| 51 | assert.equal(following('radio')[0].actor_uri, OLD);
|
|---|
| 52 | assert.equal(calls.follow.length + calls.unfollow.length, 0);
|
|---|
| 53 | });
|
|---|
| 54 |
|
|---|
| 55 | test('without the alsoKnownAs back-reference nothing moves', async () => {
|
|---|
| 56 | const res = await handleMoveInbox(move(), { verifiedActor: OLD, ...deps([]) });
|
|---|
| 57 | assert.equal(res, 202); // declined, not errored: the sender may be retrying in good faith
|
|---|
| 58 | assert.equal(following('radio')[0].actor_uri, OLD);
|
|---|
| 59 | assert.equal(calls.follow.length + calls.unfollow.length, 0);
|
|---|
| 60 | });
|
|---|
| 61 |
|
|---|
| 62 | test('push mode: both sites re-follow, each keeping its own auto-boost', async () => {
|
|---|
| 63 | const res = await handleMoveInbox(move(), { verifiedActor: OLD, ...deps() });
|
|---|
| 64 | assert.equal(res, 202);
|
|---|
| 65 | assert.deepEqual(calls.unfollow.sort(), [['blog', OLD], ['radio', OLD]]);
|
|---|
| 66 | assert.deepEqual(calls.follow.sort(), [['blog', NEW, false], ['radio', NEW, true]]);
|
|---|
| 67 | assert.equal(following('radio')[0].actor_uri, NEW);
|
|---|
| 68 | assert.equal(following('radio')[0].auto_boost, 1);
|
|---|
| 69 | assert.equal(following('blog')[0].auto_boost, 0);
|
|---|
| 70 | });
|
|---|
| 71 |
|
|---|
| 72 | test('pull mode: the NEW actor may announce the move itself', async () => {
|
|---|
| 73 | const res = await handleMoveInbox(move({ actor: NEW, id: `${NEW}#move-1` }), { verifiedActor: NEW, ...deps() });
|
|---|
| 74 | assert.equal(res, 202);
|
|---|
| 75 | assert.equal(following('radio')[0].actor_uri, NEW);
|
|---|
| 76 | });
|
|---|
| 77 |
|
|---|
| 78 | test('redelivery is idempotent: the second Move finds nothing to do', async () => {
|
|---|
| 79 | await handleMoveInbox(move(), { verifiedActor: OLD, ...deps() });
|
|---|
| 80 | calls = { unfollow: [], follow: [] };
|
|---|
| 81 | const res = await handleMoveInbox(move(), { verifiedActor: OLD, ...deps() });
|
|---|
| 82 | assert.equal(res, 202);
|
|---|
| 83 | assert.equal(calls.follow.length + calls.unfollow.length, 0);
|
|---|
| 84 | });
|
|---|
| 85 |
|
|---|
| 86 | test('a site already following the target is not re-followed, old row still cleaned', async () => {
|
|---|
| 87 | db.prepare('INSERT INTO ap_following (slug, actor_uri, status, auto_boost) VALUES (?,?,?,?)').run('radio', NEW, 'accepted', 0);
|
|---|
| 88 | await handleMoveInbox(move(), { verifiedActor: OLD, ...deps() });
|
|---|
| 89 | assert.deepEqual(calls.follow, [['blog', NEW, false]]); // radio skipped
|
|---|
| 90 | assert.equal(following('radio').length, 1); // OLD gone, NEW kept
|
|---|
| 91 | assert.equal(following('radio')[0].actor_uri, NEW);
|
|---|
| 92 | });
|
|---|
| 93 |
|
|---|
| 94 | test('a blocked destination is declined: no door opens to a blocked house', async () => {
|
|---|
| 95 | db.prepare('INSERT INTO ap_blocks (slug, target, kind) VALUES (?,?,?)').run('radio', NEW, 'actor');
|
|---|
| 96 | const res = await handleMoveInbox(move(), { verifiedActor: OLD, ...deps() });
|
|---|
| 97 | assert.equal(res, 202);
|
|---|
| 98 | assert.equal(following('radio')[0].actor_uri, OLD); // untouched
|
|---|
| 99 | assert.equal(calls.follow.length + calls.unfollow.length, 0);
|
|---|
| 100 | });
|
|---|
| 101 |
|
|---|
| 102 | test('malformed moves are 400: missing target, or object === target', async () => {
|
|---|
| 103 | assert.equal(await handleMoveInbox(move({ target: undefined }), { verifiedActor: OLD, ...deps() }), 400);
|
|---|
| 104 | assert.equal(await handleMoveInbox(move({ target: OLD }), { verifiedActor: OLD, ...deps() }), 400);
|
|---|
| 105 | });
|
|---|
| 106 |
|
|---|
| 107 | test('an unsigned Move is refused before anything is read', async () => {
|
|---|
| 108 | const res = await handleMoveInbox(move(), { verifiedActor: null, ...deps() });
|
|---|
| 109 | assert.equal(res, 401);
|
|---|
| 110 | assert.equal(following('radio')[0].actor_uri, OLD);
|
|---|
| 111 | });
|
|---|
| 112 |
|
|---|
| 113 | test('the actor publishes alsoKnownAs from ap_aliases; the own id is filtered out', () => {
|
|---|
| 114 | db.prepare("UPDATE sites SET ap_aliases = ? WHERE slug = 'radio'")
|
|---|
| 115 | .run(JSON.stringify(['https://oldhome.example/users/dj', 'https://test.example/ap/users/radio', 42]));
|
|---|
| 116 | const site = db.prepare("SELECT * FROM sites WHERE slug = 'radio'").get();
|
|---|
| 117 | const actor = buildActor('https://test.example', site);
|
|---|
| 118 | assert.deepEqual(actor.alsoKnownAs, ['https://oldhome.example/users/dj']);
|
|---|
| 119 | });
|
|---|
| 120 |
|
|---|
| 121 | test('no aliases set, no alsoKnownAs on the actor', () => {
|
|---|
| 122 | db.prepare("UPDATE sites SET ap_aliases = NULL WHERE slug = 'radio'").run();
|
|---|
| 123 | const site = db.prepare("SELECT * FROM sites WHERE slug = 'radio'").get();
|
|---|
| 124 | assert.equal('alsoKnownAs' in buildActor('https://test.example', site), false);
|
|---|
| 125 | });
|
|---|