source: Klonkt/src/server.js@ 421c2d4

main
Last change on this file since 421c2d4 was 9effb80, checked in by roboburr <roboburr@…>, 3 months ago

fix(editor): CSP blocked blob: image → empty edit dialog

img-src was missing blob:, so the Cropper <img> (URL.createObjectURL → blob:)
was silently blocked by CSP → no image visible. Added blob: to img-src (media-src
already had it for audio). + onerror fallback in the editor: if the image fails
to load, the original is uploaded instead of getting stuck.

Co-Authored-By: Claude <noreply@…>

  • Property mode set to 100644
File size: 20.7 KB
Line 
1/**
2 * Klonkt Beta — server bootstrap
3 *
4 * Persoonlijk multi-site platform — Node + SQLite + htmx.
5 * Stack: Express + better-sqlite3 + EJS + htmx + ws.
6 */
7
8import 'dotenv/config';
9import express from 'express';
10import helmet from 'helmet';
11import session from 'express-session';
12import bodyParser from 'body-parser';
13import path from 'path';
14import fs from 'fs';
15import { fileURLToPath } from 'url';
16import http from 'http';
17import db, { initializeDatabase } from './config/database.js';
18import { startScheduler } from './services/Scheduler.js';
19import { SqliteSessionStore } from './services/SqliteSessionStore.js';
20import { ensurePrimarySite } from './services/ensurePrimarySite.js';
21import PrutterService from './services/PrutterService.js';
22import { WebSocketServer } from 'ws';
23
24import { resolveSite, loadAudioTracks, loadTheme } from './middleware/site.js';
25import { isViewer } from './middleware/auth.js';
26import { renderPage } from './middleware/render.js';
27import authRoutes from './routes/auth.js';
28import accountRoutes from './routes/account.js';
29import adminRoutes from './routes/admin.js';
30import adminAudioRoutes from './routes/admin-audio.js';
31import adminPlaylistsRoutes from './routes/admin-playlists.js';
32import adminSitesRoutes from './routes/admin-sites.js';
33import adminUsersRoutes from './routes/admin-users.js';
34import adminCommentsRoutes from './routes/admin-comments.js';
35import adminSettingsRoutes from './routes/admin-settings.js';
36import adminSeoRoutes from './routes/admin-seo.js';
37import prutterRoutes from './routes/prutter.js';
38import audioRoutes from './routes/audio.js';
39import searchRoutes from './routes/search.js';
40import commentsRoutes from './routes/comments.js';
41import tagsRoutes from './routes/tags.js';
42import typesRoutes from './routes/types.js';
43import usersRoutes from './routes/users.js';
44import feedRoutes from './routes/feed.js';
45import hubRoutes from './routes/hub.js';
46import artistsRoutes from './routes/artists.js';
47import postsRoutes from './routes/posts.js';
48import langRoutes from './routes/lang.js';
49import federationRoutes from './routes/federation.js';
50import { startCircleSyncLoop } from './services/CircleService.js';
51import adminCircleRoutes from './routes/admin-circle.js';
52import adminUpdatesRoutes from './routes/admin-updates.js';
53import adminPatreonRoutes from './routes/admin-patreon.js';
54import adminStatsRoutes from './routes/admin-stats.js';
55import circleRoutes from './routes/circle.js';
56import epkRoutes from './routes/epk.js';
57import newsletterRoutes from './routes/newsletter.js';
58import adminNewsletterRoutes from './routes/admin-newsletter.js';
59import downloadRoutes from './routes/download.js';
60import linkbioRoutes from './routes/linkbio.js';
61import embedRoutes from './routes/embed.js';
62import showsRoutes from './routes/shows.js';
63import adminShowsRoutes from './routes/admin-shows.js';
64import adminEpkRoutes from './routes/admin-epk.js';
65import changelogRoutes from './routes/changelog.js';
66
67if (!process.env.SESSION_SECRET) {
68 console.error('❌ FATAL: SESSION_SECRET is required');
69 process.exit(1);
70}
71
72if (process.env.NODE_ENV === 'production' && process.env.SESSION_SECRET.length < 32) {
73 console.error('❌ FATAL: SESSION_SECRET too weak for production');
74 process.exit(1);
75}
76
77const __dirname = path.dirname(fileURLToPath(import.meta.url));
78const PORT = process.env.PORT || 3000;
79const isDev = process.env.NODE_ENV !== 'production';
80
81const app = express();
82const server = http.createServer(app);
83
84app.use(helmet({
85 contentSecurityPolicy: {
86 directives: {
87 defaultSrc: ["'self'"],
88 scriptSrc: [
89 "'self'",
90 "'unsafe-inline'",
91 // Eigen custom-embeds (embed-player.js) laden de OFFICIELE player-API's
92 // van deze hosts. Zonder deze whitelist blokkeert de CSP ze stil (alleen
93 // een console-fout) en faalt de embed-speler.
94 "https://www.youtube.com", // YouTube IFrame Player API (+ www-widgetapi.js)
95 "https://s.ytimg.com", // YouTube player-assets
96 "https://w.soundcloud.com", // SoundCloud Widget API (api.js)
97 "https://open.spotify.com", // Spotify iFrame API (loader)
98 "https://*.spotifycdn.com", // Spotify iFrame API (echte bundle: embed-cdn.spotifycdn.com)
99 ],
100 // Helmet's default zet script-src-attr op 'none', wat ALLE inline event-
101 // handlers (onchange/onclick/onsubmit) blokkeert — daardoor deed o.a. de
102 // avatar-upload (<input onchange="this.form.submit()">) en de rol-dropdown
103 // niets. We staan inline handlers expliciet toe, consistent met de al
104 // toegestane inline <script> hierboven.
105 scriptSrcAttr: ["'unsafe-inline'"],
106 styleSrc: ["'self'", "'unsafe-inline'"],
107 // blob: nodig voor de afbeeldings-editor (Cropper) — die toont de gekozen
108 // foto via een URL.createObjectURL(blob:…). Zonder blob: blokkeert de CSP
109 // de <img> stil → leeg bewerk-venster. (media-src heeft blob: al voor audio.)
110 imgSrc: ["'self'", "data:", "https:", "blob:"],
111 connectSrc: ["'self'", "wss:", "ws:", "https://*.spotifycdn.com", "https://*.scdn.co"],
112 // blob: is required for the audio player — it fetch()es track bytes and
113 // plays from a blob: object URL (Spotify-style). Without blob: here the
114 // CSP silently blocks <audio>.src = blob:… → the player fires 'error' and
115 // auto-skips every track. 'self'/https: do NOT imply blob:.
116 mediaSrc: ["'self'", "https:", "blob:"],
117 fontSrc: ["'self'"],
118 frameSrc: [
119 "'self'",
120 "https://open.spotify.com",
121 "https://w.soundcloud.com",
122 "https://bandcamp.com",
123 "https://embed.music.apple.com",
124 "https://www.youtube-nocookie.com",
125 "https://www.youtube.com", // YouTube IFrame API maakt soms een www.youtube.com-iframe
126 "https://player.vimeo.com",
127 ],
128 },
129 },
130 hsts: { maxAge: 31536000, includeSubDomains: true, preload: true },
131 frameguard: { action: 'sameorigin' },
132 referrerPolicy: { policy: 'no-referrer-when-downgrade' },
133}));
134
135app.set('view engine', 'ejs');
136app.set('views', path.join(__dirname, 'views'));
137
138app.use(bodyParser.urlencoded({ extended: true, limit: '10mb' }));
139app.use(bodyParser.json({ limit: '10mb' }));
140
141// Trust one upstream proxy in production. NPM (or Caddy / nginx) terminates
142// HTTPS and forwards to us over plain HTTP, setting X-Forwarded-Proto: https.
143// Without this, Express sees req.protocol === 'http' and won't issue secure
144// cookies — sessions never persist past the redirect after login.
145if (!isDev) app.set('trust proxy', 1);
146
147// Schema aanmaken/bijwerken VÓÓR iets de DB aanraakt: de session-store doet
148// bij constructie al een query op de `sessions`-tabel, dus bij een verse
149// install moeten de tabellen eerst bestaan (anders: "no such table: sessions"
150// → crash-loop op de allereerste boot).
151initializeDatabase();
152startScheduler(); // release-planning: zet geplande posts live zodra publish_at bereikt is
153
154// Vangnet: garandeer dat er altijd een primaire site is (solo/hub/circle).
155// Idempotent — doet niets als er al een site is of nog geen beheerder.
156ensurePrimarySite();
157
158// Session middleware extracted into a variable so the WebSocket upgrade
159// handler can reuse it (it needs req.session to authenticate sockets).
160const sessionMiddleware = session({
161 store: new SqliteSessionStore(),
162 secret: process.env.SESSION_SECRET,
163 resave: false,
164 saveUninitialized: false,
165 name: 'pcms.sid',
166 cookie: {
167 httpOnly: true,
168 secure: !isDev,
169 sameSite: 'lax',
170 maxAge: 30 * 24 * 60 * 60 * 1000,
171 },
172});
173app.use(sessionMiddleware);
174
175app.use('/assets', express.static(path.join(__dirname, 'assets'), { maxAge: isDev ? 0 : '1y' }));
176app.use('/media', express.static(process.env.MEDIA_PATH || './storage/media', {
177 // Publieke media (post-covers, avatars) moet door andere Klonkt-sites in hun
178 // CIRKEL cross-origin embedbaar zijn. Helmet zet standaard CORP=same-origin,
179 // wat die afbeeldingen in de browser blokkeert (bestand komt wél binnen, maar
180 // de browser weigert 'm te tonen). Voor /media dus expliciet cross-origin.
181 setHeaders: (res) => res.setHeader('Cross-Origin-Resource-Policy', 'cross-origin'),
182}));
183
184// (Verwijderd) TWA / digital-asset-links — alleen nodig voor de APK/TWA-variant.
185// Klonkt is PWA-only; geen assetlinks.json meer.
186
187// Cirkels: periodieke achtergrond-sync van remote instances (no-op tenzij tenancy='circle').
188startCircleSyncLoop();
189
190// Bundle HTMX: copy from node_modules into our own assets dir so we can serve
191// it locally (no third-party CDN). Idempotent — only copies if size differs.
192(function ensureLocalHtmx() {
193 const src = path.join(__dirname, '..', 'node_modules', 'htmx.org', 'dist', 'htmx.min.js');
194 const dest = path.join(__dirname, 'assets', 'js', 'htmx.min.js');
195 try {
196 const srcStat = fs.statSync(src);
197 const destStat = fs.existsSync(dest) ? fs.statSync(dest) : null;
198 if (!destStat || destStat.size !== srcStat.size) {
199 fs.copyFileSync(src, dest);
200 console.log(`📦 HTMX bundled locally: ${srcStat.size} bytes`);
201 }
202 } catch (e) {
203 console.warn('⚠️ Could not bundle HTMX:', e.message, '— run `npm install`');
204 }
205})();
206
207// Singleton PrutterService — routes get it via req.app.locals.prutter.
208const prutter = new PrutterService(db);
209app.locals.prutter = prutter;
210
211// Cirkels-federatie: publieke, site-agnostische endpoints (/.klonkt/*).
212// Vóór resolveSite/theme — ze hebben geen site-context nodig.
213app.use(federationRoutes);
214
215app.use(resolveSite);
216app.use(loadAudioTracks);
217app.use(loadTheme);
218
219// Lichtgewicht CSRF-defense: weiger cross-origin state-wijzigende requests.
220// Same-origin forms + HTMX sturen een matchende Origin; ontbreekt Origin dan
221// laten we door (non-browser clients). sameSite:'lax' op de sessiecookie is de
222// tweede laag. (Geldt niet voor GET/HEAD/OPTIONS.)
223app.use((req, res, next) => {
224 if (req.method === 'GET' || req.method === 'HEAD' || req.method === 'OPTIONS') return next();
225 const origin = req.get('origin');
226 if (!origin) return next(); // geen Origin -> geen browser-CSRF-vector
227 let originHost;
228 try { originHost = new URL(origin).host; } catch { return res.status(403).send('Ongeldige origin'); }
229 if (originHost !== req.get('host')) return res.status(403).send('Cross-origin request geweigerd');
230 next();
231});
232
233// Kijker-accounts: alles bekijken mag (incl. Beheer), niets wijzigen. Dit is de
234// ENIGE schrijf-blokkade — fail-closed, vóór alle route-handlers. Elke state-
235// wijzigende methode wordt geweigerd (de login-POST zet de sessie pas ná deze
236// guard, dus die valt er niet onder). I.p.v. rauwe 403-tekst tonen we een nette
237// pagina (of, bij HTMX, een ingeswapte melding).
238app.use((req, res, next) => {
239 const mutating = req.method !== 'GET' && req.method !== 'HEAD' && req.method !== 'OPTIONS';
240 if (mutating && isViewer(req.session?.user)) {
241 if (req.headers['hx-request'] === 'true') {
242 // htmx swapt niet op 4xx; stuur 200 + retarget zodat de melding in #pcms-main verschijnt.
243 res.setHeader('HX-Retarget', '#pcms-main');
244 res.setHeader('HX-Reswap', 'innerHTML');
245 res.status(200);
246 } else {
247 res.status(403);
248 }
249 return renderPage(req, res, 'pages/viewer-blocked', {
250 pageTitle: 'Kijker-modus',
251 bodyClass: 'on-special',
252 });
253 }
254 next();
255});
256
257app.use('/auth', authRoutes);
258app.use('/account', accountRoutes);
259app.use('/admin/audio', adminAudioRoutes);
260app.use('/admin/playlists', adminPlaylistsRoutes);
261app.use('/admin/sites', adminSitesRoutes);
262app.use('/admin/users', adminUsersRoutes);
263app.use('/admin/comments', adminCommentsRoutes);
264app.use('/admin/settings', adminSettingsRoutes);
265app.use('/admin/seo', adminSeoRoutes);
266app.use('/admin/circle', adminCircleRoutes);
267app.use('/admin/updates', adminUpdatesRoutes);
268app.use('/admin/patreon', adminPatreonRoutes);
269app.use('/admin/stats', adminStatsRoutes);
270app.use('/admin/newsletter', adminNewsletterRoutes);
271app.use('/admin/shows', adminShowsRoutes);
272app.use('/admin/epk', adminEpkRoutes);
273app.use('/admin', adminRoutes);
274app.use('/prutter', prutterRoutes);
275app.use('/audio', audioRoutes);
276app.use('/search', searchRoutes);
277app.use('/comments', commentsRoutes);
278app.use('/tag', tagsRoutes);
279app.use('/type', typesRoutes);
280app.use('/users', usersRoutes);
281// Feed/sitemap routes are mounted at root because they're at well-known paths
282app.use('/', feedRoutes);
283app.use('/leden', artistsRoutes); // doorzoekbare leden-directory (alleen hub; solo: next())
284app.get('/artiesten', (req, res) => res.redirect(301, req.originalUrl.replace(/^\/artiesten/, '/leden'))); // oude URL -> /leden
285app.use('/', hubRoutes); // hub-overview op '/' (solo: next() -> postsRoutes)
286app.use('/', circleRoutes); // /cirkel-feed (solo/hub: next() -> postsRoutes)
287app.use('/', epkRoutes); // /pers perskit (premium; niet-premium: next() -> 404)
288app.use('/', newsletterRoutes); // /nieuwsbrief in/uitschrijven (premium; niet-premium: next())
289app.use('/', downloadRoutes); // /downloads + /download/:id download-voor-email (premium)
290app.use('/', linkbioRoutes); // /links link-in-bio + klikstats (premium)
291app.use('/', embedRoutes); // /embed inbedbare audiospeler (premium)
292app.use('/', showsRoutes); // /shows agenda + notify-me (premium)
293app.use('/', changelogRoutes); // /changelog publieke release-/wijzigingen-pagina
294app.use('/', langRoutes); // /lang/:code — interface-taal kiezen (vóór de catch-all)
295app.use('/', postsRoutes);
296
297app.get('/manifest.webmanifest', (req, res) => {
298 const site = res.locals.site;
299
300 // PWA scope: confines installed apps to ONE site. If a user is in the
301 // bedrijf1 PWA and clicks a link to /sites/bedrijf2/..., the browser will
302 // open it in a regular tab (out-of-scope) instead of within the PWA.
303 // Same applies to APK packaging — the WebView is locked to this scope.
304 //
305 // For path-mounted sites: scope = /sites/<slug>/
306 // For root/subdomain sites: scope = /
307 const base = res.locals.siteUrlBase || ''; // '' or '/sites/<slug>'
308 const scope = (base || '') + '/';
309 const startUrl = (base || '') + '/?source=pwa';
310
311 // A stable identity per site so installs don't collide (Chromium uses `id`).
312 // NB: een id-wissel orphant bestaande PWA-installs (er is geen migratie die een
313 // install over een id-verandering heen tilt) — wie een site al als PWA had,
314 // moet 'm één keer opnieuw installeren. Data blijft server-side, dus niets kwijt.
315 const idBase = site?.slug ? `klonkt-${site.slug}` : 'klonkt';
316
317 res.set('Cache-Control', 'no-cache');
318 res.json({
319 id: idBase,
320 name: site?.title || 'Klonkt',
321 short_name: (site?.title || 'Klonkt').slice(0, 12),
322 description: site?.description || site?.tagline || '',
323 scope,
324 start_url: startUrl,
325 display: 'standalone',
326 display_override: ['standalone', 'minimal-ui'],
327 orientation: 'any',
328 background_color: '#1a1a17',
329 theme_color: site?.accent || '#c2410c',
330 lang: site?.language || 'nl',
331 icons: [
332 { src: '/favicon.svg', sizes: 'any', type: 'image/svg+xml' },
333 { src: '/favicon.ico', sizes: '64x64', type: 'image/x-icon' },
334 ],
335 // Hint to capable browsers: capture all in-scope links inside the PWA
336 capture_links: 'existing-client-navigate',
337 });
338});
339
340// Favicon — served as SVG so it picks up the site's accent color dynamically.
341// Browsers also request /favicon.ico by convention; we serve the same SVG
342// content there with a forgiving content-type since modern browsers accept it.
343function _renderFavicon(res, accent) {
344 const safeAccent = /^#[0-9a-fA-F]{3,8}$/.test(accent) ? accent : '#c2410c';
345 // Site mark: rounded square in the site accent + bold white 'K' (Klonkt)
346 const svg = `<?xml version="1.0" encoding="UTF-8"?>
347<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 64 64">
348 <rect width="64" height="64" rx="14" fill="${safeAccent}"/>
349 <text x="50%" y="50%" dy="0.35em" text-anchor="middle"
350 font-family="Arial, Helvetica, sans-serif"
351 font-size="42" font-weight="800" fill="#fff">K</text>
352</svg>`;
353 res.set('Content-Type', 'image/svg+xml');
354 res.set('Cache-Control', 'public, max-age=86400');
355 res.send(svg);
356}
357
358app.get('/favicon.svg', (req, res) => {
359 _renderFavicon(res, res.locals.site?.accent);
360});
361app.get('/favicon.ico', (req, res) => {
362 // Browsers requesting .ico will accept SVG content; chrome/firefox both fine.
363 // Keeping the route prevents 404 spam in the console.
364 _renderFavicon(res, res.locals.site?.accent);
365});
366
367app.get('/sw.js', (req, res) => {
368 res.set('Content-Type', 'application/javascript');
369 res.set('Cache-Control', 'no-cache');
370 res.send(`
371const CACHE_VERSION = 'pcms-v11-' + new Date().toISOString().split('T')[0];
372self.addEventListener('install', e => {
373 e.waitUntil(caches.open(CACHE_VERSION).then(c => c.addAll(['/'])));
374 self.skipWaiting();
375});
376self.addEventListener('activate', e => {
377 e.waitUntil(caches.keys().then(keys => Promise.all(
378 keys.filter(k => k !== CACHE_VERSION).map(k => caches.delete(k))
379 )));
380 self.clients.claim();
381});
382// ALLEEN navigaties (HTML-pagina's) onderscheppen, voor een offline-fallback.
383// Afbeeldingen, CSS, JS en /media NIET aanraken — laat de browser die native
384// afhandelen. Anders kon een mislukte netwerk-fetch terugvallen op een lege
385// cache-match (undefined) en zo een afbeelding "kapot" maken bij een gewone
386// refresh (hard reload omzeilt de SW en werkte daarom wél).
387self.addEventListener('fetch', e => {
388 if (e.request.method !== 'GET') return;
389 if (e.request.mode !== 'navigate') return; // alleen page-loads
390 e.respondWith(
391 fetch(e.request).catch(() => caches.match('/').then(r => r || Response.error()))
392 );
393});
394 `);
395});
396
397process.on('unhandledRejection', (reason) => {
398 console.error('⚠️ Unhandled Rejection:', reason);
399});
400
401app.use((err, req, res, next) => {
402 console.error('❌ Error:', err);
403 res.status(err.status || 500).send(
404 isDev ? `<pre>${err.stack || err.message}</pre>` : 'Internal Server Error'
405 );
406});
407
408app.use((req, res) => {
409 res.status(404);
410 // Nette, mobielvriendelijke 404 via de shell (viewport + nav + huisstijl).
411 // Valt terug op kale HTML als het renderen onverhoopt faalt.
412 try {
413 return renderPage(req, res, 'pages/404', {
414 pageTitle: '404 — niet gevonden',
415 bodyClass: 'on-special on-404',
416 });
417 } catch (e) {
418 return res.send('<!doctype html><meta name="viewport" content="width=device-width,initial-scale=1"><div style="font-family:system-ui;max-width:500px;margin:4rem auto;text-align:center;padding:2rem"><h1 style="font-size:4rem;margin:0">404</h1><p>Pagina niet gevonden</p><a href="/">← Home</a></div>');
419 }
420});
421
422// ==================== WebSocket: Prutter real-time ====================
423// Authenticate via the existing session cookie. We reuse sessionMiddleware
424// during the HTTP upgrade so req.session is populated; if no user, abort.
425const wss = new WebSocketServer({ noServer: true });
426
427server.on('upgrade', (req, socket, head) => {
428 if (req.url !== '/ws/prutter') {
429 socket.destroy();
430 return;
431 }
432 // Run session middleware on the upgrade request.
433 // (Express's middleware accepts (req, res, next); we pass a stub res.)
434 const stubRes = { setHeader: () => {}, getHeader: () => undefined, on: () => {}, end: () => {} };
435 sessionMiddleware(req, stubRes, () => {
436 if (!req.session?.user) {
437 socket.write('HTTP/1.1 401 Unauthorized\r\n\r\n');
438 socket.destroy();
439 return;
440 }
441 // Kijker-accounts zijn alleen-lezen: weiger de WS-upgrade. De HTTP-guard
442 // dekt geen WS, dus dit is de plek om schrijven via een (toekomstige)
443 // message-handler te voorkomen.
444 if (isViewer(req.session.user)) {
445 socket.write('HTTP/1.1 403 Forbidden\r\n\r\n');
446 socket.destroy();
447 return;
448 }
449 wss.handleUpgrade(req, socket, head, (ws) => {
450 ws.userId = req.session.user.id;
451 wss.emit('connection', ws, req);
452 });
453 });
454});
455
456wss.on('connection', (ws) => {
457 prutter.addConnection(ws.userId, ws);
458 ws.on('close', () => prutter.removeConnection(ws.userId, ws));
459 ws.on('error', () => prutter.removeConnection(ws.userId, ws));
460 // Optional: ping every 30s to keep connections alive through proxies
461 ws.isAlive = true;
462 ws.on('pong', () => { ws.isAlive = true; });
463});
464const wsPing = setInterval(() => {
465 for (const ws of wss.clients) {
466 if (ws.isAlive === false) { ws.terminate(); continue; }
467 ws.isAlive = false;
468 try { ws.ping(); } catch {}
469 }
470}, 30000);
471if (wsPing.unref) wsPing.unref();
472
473server.listen(PORT, () => {
474 console.log('');
475 console.log('🪶 Klonkt Beta');
476 console.log(` http://localhost:${PORT}`);
477 console.log('');
478 console.log(` ✓ Security: Helmet, CSP, secure sessions`);
479 console.log(` ✓ Privacy: Self-hosted fonts, no third-party requests`);
480 console.log(` ✓ Layout: v9 editorial feel (top nav, profile header)`);
481 console.log(` ✓ Auth: wachtwoord (beheer) + Google (luisteraars) / logout`);
482 console.log(` ✓ Posts: create / edit / view / archive`);
483 console.log(` ✓ Realtime: WebSocket server ready (Prutter)`);
484 console.log('');
485 console.log(` Mode: ${isDev ? 'development' : 'PRODUCTION'}`);
486 console.log('');
487});
488
489export default app;
Note: See TracBrowser for help on using the repository browser.