source: Klonkt/src/routes/activitypub.js@ af6e085

main
Last change on this file since af6e085 was 6fd0e20, checked in by Robin Genis <roboburr@…>, 6 weeks ago

FEP-044f: Klonkt resolvet de geciteerde post voor een ingebedde quote-kaart

De client kan remote AP-objecten niet gesigneerd ophalen, dus Klonkt resolvet de
quote emit-side tot een compacte, gesaneerde snapshot en serveert die als
shaer:quote op de C2S inbox-read. De client rendert daarmee een geneste kaart
(auteur + avatar + tekst + evt. thumbnail) i.p.v. alleen de link-chip.

resolveQuote(note) haalt de quoted post op (SSRF-safe apGetJson), pakt de auteur
(fetchActor + actorInfo) en saneert de content met dezelfde sanitizer als elke
andere note (kindveilig blijft gelden). Best-effort: faalt de fetch, dan blijft
quote_json leeg en valt de client terug op de chip.

Bron-URL via quoteHrefOf: object-level quote (FEP-044f) of een quote-rel
FEP-e232 Link. Resolutie op inbound (fire-and-forget, blokkeert de inbox-response
niet), op outbox-backfill (await) en in self-heal (v10 -> v11, met COALESCE-gedrag
zodat een tijdelijk onbereikbare quoted post de cache niet leegt).

Changed files:
src/config/database.js

  • ap_timeline.quote_json kolom

src/services/ActivityPubService.js

  • quoteHrefOf(note): quoted-post-URL uit object-quote of quote-rel Link
  • resolveQuote(note): async snapshot {url, author, content, published, media}
  • timelineQuote(quoteJson): snapshot terug voor de inbox-read
  • inbound (fire-and-forget), backfill (await), self-heal v11 (await + COALESCE)
  • timelineQuote in de default-export

src/routes/activitypub.js

  • inbox-read serveert shaer:quote (de geresolvede snapshot)

test/object-links.test.js

  • quoteHrefOf (object-quote + quote-rel Link + geen) en timelineQuote round-trip

remarks: 180 tests groen (was 178). resolveQuote zelf is netwerk, niet in de unit-test.

-robo
Co-Authored-By: Claude Opus 4.8 <noreply@…>

  • Property mode set to 100644
File size: 20.1 KB
Line 
1/**
2 * ActivityPub — public endpoints (Phase 1: discover + fetch).
3 *
4 * GET /.well-known/webfinger?resource=acct:<slug>@<host>
5 * GET /ap/users/:slug actor (content-negotiated: AP-JSON vs redirect to HTML profile)
6 * GET /ap/users/:slug/outbox OrderedCollection of Create(Note)
7 * GET /ap/users/:slug/followers count-only OrderedCollection
8 * GET /ap/users/:slug/featured pinned posts (Mastodon "Featured" tab)
9 * GET /ap/notes/:id a single Note
10 * POST /ap/users/:slug/inbox, /ap/inbox → 202 (Follow/Accept + signature verify: next step)
11 *
12 * Mounted before resolveSite; resolves the site by slug itself.
13 */
14import express from 'express';
15import { readFileSync } from 'fs';
16import db from '../config/database.js';
17import AP from '../services/ActivityPubService.js';
18import { apReadLimiter, apInboxLimiter } from '../middleware/rate-limit.js';
19import { apEnabled } from '../services/SettingsService.js';
20import OAuth from '../services/OAuthService.js';
21import * as Guardianship from '../services/guardianship/index.js';
22import multer from 'multer';
23import path from 'path';
24import fs from 'fs';
25import { fileURLToPath } from 'url';
26import { randomUUID } from 'crypto';
27
28const router = express.Router();
29// The whole fediverse layer can be turned off (solo "no federation" mode):
30// then /ap/*, WebFinger and NodeInfo are simply gone — the site is undiscoverable
31// and unfederatable. CRITICAL: this router is mounted at root (app.use(apRoutes)), so a
32// blanket res.status(404) here ran for EVERY request and 404'd the whole site when AP was
33// off. Use next('router') to SKIP this router entirely and let the normal routes handle it
34// (the /ap/* paths then fall through to the app's normal 404, which is correct).
35router.use((req, res, next) => { if (!apEnabled()) return next('router'); next(); });
36// Generous per-IP baseline over all /ap/* (reads). The inbox POST gets an
37// additional, tighter cap inline (it triggers outbound fetches).
38router.use(apReadLimiter);
39let _ver = '1.0.0';
40try { _ver = JSON.parse(readFileSync(new URL('../../package.json', import.meta.url))).version || _ver; } catch { /* keep default */ }
41
42const baseUrl = (req) => (process.env.PUBLIC_BASE_URL || `${req.protocol}://${req.get('host')}`).replace(/\/+$/, '');
43const hostOf = (req) => { try { return new URL(baseUrl(req)).host; } catch { return req.get('host'); } };
44const publicSite = (slug) => db.prepare('SELECT * FROM sites WHERE slug = ? AND (is_public IS NULL OR is_public = 1)').get(slug);
45const primarySlug = () => { const r = db.prepare('SELECT slug FROM sites WHERE is_primary = 1').get(); return r && r.slug; };
46
47// ── WebFinger ─────────────────────────────────────────────────────
48router.get('/.well-known/webfinger', (req, res) => {
49 const m = String(req.query.resource || '').match(/^acct:([^@]+)@(.+)$/i);
50 if (!m) return res.status(400).type('text/plain').send('bad resource');
51 const site = publicSite(m[1]);
52 if (!site) return res.status(404).end();
53 res.type('application/jrd+json; charset=utf-8');
54 res.set('Cache-Control', 'public, max-age=300');
55 const actorUri = AP.actorId(baseUrl(req), site.slug);
56 const profileUrl = baseUrl(req) + (site.slug === primarySlug() ? '/' : `/user/${encodeURIComponent(site.slug)}`);
57 res.send(JSON.stringify({
58 subject: `acct:${site.slug}@${hostOf(req)}`,
59 aliases: [actorUri, profileUrl],
60 links: [
61 { rel: 'self', type: 'application/activity+json', href: actorUri },
62 { rel: 'http://webfinger.net/rel/profile-page', type: 'text/html', href: profileUrl },
63 ],
64 }));
65});
66
67// ── Actor ─────────────────────────────────────────────────────────
68router.get('/ap/users/:slug', (req, res) => {
69 const site = publicSite(req.params.slug);
70 if (!site) return res.status(404).end();
71 if (!AP.apWants(req)) {
72 // A browser hit the AP actor URL → send them to the human profile.
73 const human = site.slug === primarySlug() ? '/' : `/user/${encodeURIComponent(site.slug)}`;
74 return res.redirect(302, baseUrl(req) + human);
75 }
76 site.primary_slug = primarySlug();
77 AP.sendAP(res, AP.buildActor(baseUrl(req), site));
78});
79
80// ── Outbox ────────────────────────────────────────────────────────
81router.get('/ap/users/:slug/outbox', async (req, res) => {
82 const site = publicSite(req.params.slug);
83 if (!site) return res.status(404).end();
84 // Authorized fetch (FEP-633c §5.3 note): a committed guardian doing a SIGNED
85 // GET may read the ward's fan-only history too, without appearing as a
86 // follower. Unsigned / non-guardian callers get the public collection only.
87 let asGuardian = false;
88 if (req.headers['signature']) {
89 const verified = await AP.verifyRequest(req).catch(() => null);
90 asGuardian = !!(verified && AP.isWardGuardian(req.params.slug, verified.id));
91 }
92 const fanClause = asGuardian ? '' : "AND (fan_only IS NULL OR fan_only = 0)";
93 const posts = db.prepare(
94 `SELECT id, slug, title, content, cover_image_url, cover_video_url, nsfw, content_warning, published_at, created_at
95 FROM posts WHERE site_id = ? AND status = 'published' ${fanClause}
96 ORDER BY COALESCE(published_at, created_at) DESC LIMIT 20`
97 ).all(site.id);
98 AP.sendAP(res, AP.buildOutbox(baseUrl(req), site, posts), asGuardian ? 'private, no-store' : undefined);
99});
100
101// ── Blocked collection (owner only, AP §5.6) ──────────────────────
102// The server blocklist is the source of truth for Shaer's "in Orbit":
103// clients read it here instead of keeping their own state. Actor-kind
104// blocks only (domain blocks are instance policy, not an Orbit member).
105router.get('/ap/users/:slug/blocked', (req, res) => {
106 const auth = OAuth.verifyBearer(req.headers.authorization);
107 if (!auth || auth.site.slug !== req.params.slug) return res.status(403).end();
108 const base = baseUrl(req);
109 const items = AP.listBlocks(auth.site.slug)
110 .filter((b) => b.kind === 'actor')
111 .map((b) => b.target);
112 AP.sendAP(res, {
113 '@context': AP.AP_CONTEXT,
114 id: `${base}/ap/users/${auth.site.slug}/blocked`,
115 type: 'OrderedCollection',
116 totalItems: items.length,
117 orderedItems: items,
118 });
119});
120
121// ── Guardian queues (owner only, FEP-633c, shaer:queues) ──────────
122// The dashboard collections the Shaer clients read: pending adoption offers,
123// gated follows (empty in Klonkt for now) and the guardian's wards. Same
124// contract as the Shaer test daemon.
125function queueRoute(name, build) {
126 router.get(`/ap/users/:slug/queues/${name}`, (req, res) => {
127 const auth = OAuth.verifyBearer(req.headers.authorization);
128 if (!auth || auth.site.slug !== req.params.slug) return res.status(403).end();
129 const base = baseUrl(req);
130 const me = `${base}/ap/users/${auth.site.slug}`;
131 AP.sendAP(res, { '@context': AP.AP_CONTEXT, ...build(`${me}/queues/${name}`, auth.site.slug, me) });
132 });
133}
134queueRoute('offers', (id, slug, me) => Guardianship.offersCollection(id, slug, me));
135queueRoute('follows', (id) => Guardianship.followsCollection(id));
136queueRoute('wards', (id, slug) => Guardianship.wardsCollection(id, slug));
137
138// ── Inbox read (owner only, AP C2S) ───────────────────────────────
139// GET on the inbox is part of ActivityPub C2S: the account owner (a bearer
140// scoped to this site) reads recent inbound posts (the timeline: accounts
141// they follow) as Create(Note) items, so an app (Shaer) can build a unified
142// feed. Anyone else gets 403; the inbox stays write-only for the public.
143router.get('/ap/users/:slug/inbox', (req, res) => {
144 const auth = OAuth.verifyBearer(req.headers.authorization);
145 if (!auth || auth.site.slug !== req.params.slug) return res.status(403).end();
146 const base = baseUrl(req);
147 const items = AP.getTimeline(auth.site.slug, 60).map((t) => ({
148 id: `${t.id}#create`,
149 type: 'Create',
150 actor: t.author_uri,
151 published: t.published || t.created_at || undefined,
152 object: {
153 id: t.id,
154 type: 'Note',
155 attributedTo: t.author_uri,
156 content: t.content,
157 url: t.url || undefined,
158 published: t.published || t.created_at || undefined,
159 sensitive: !!t.nsfw,
160 summary: t.cw || undefined,
161 // Friends' media travels along (media_json → AS2 attachment), so the
162 // client renders their images/audio like own outbox posts.
163 attachment: AP.timelineAttachments(t.media_json),
164 // The note's preserved tags, so the client can render them: FEP-9098
165 // Emoji tags (:shortcode: → image) and FEP-e232 Link tags (quotes /
166 // inline object references). Combined into one `tag` array; omitted
167 // when the note has neither.
168 tag: (() => {
169 const tags = [...(AP.timelineEmojis(t.emoji_json) || []), ...(AP.timelineObjectLinks(t.link_json) || [])];
170 return tags.length ? tags : undefined;
171 })(),
172 // FEP-044f: the resolved quoted post (author + content), so the client
173 // renders an embedded quote card instead of a bare link. Omitted when the
174 // note has no quote or the quoted post could not be resolved.
175 'shaer:quote': AP.timelineQuote(t.quote_json),
176 },
177 }));
178 AP.sendAP(res, {
179 '@context': AP.AP_CONTEXT,
180 id: `${base}/ap/users/${auth.site.slug}/inbox`,
181 type: 'OrderedCollection',
182 totalItems: items.length,
183 orderedItems: items,
184 });
185});
186
187// ── uploadMedia (owner only, AP C2S) ──────────────────────────────
188// The actor advertises endpoints.uploadMedia; this implements it. A bearer
189// scoped to this site uploads one image/audio/video (multipart field "file",
190// AP convention) into the same store the reply editor uses, and gets back
191// { url, mediaType, name } to attach on a note (e.g. the help-buoy capture).
192const AP_MEDIA_DIR = path.resolve(
193 process.env.REPLY_MEDIA_PATH ||
194 path.join(path.dirname(fileURLToPath(import.meta.url)), '..', '..', 'storage', 'media', 'reply-media')
195);
196fs.mkdirSync(AP_MEDIA_DIR, { recursive: true });
197const AP_MEDIA_EXT = new Set(['.jpg', '.jpeg', '.png', '.webp', '.gif', '.mp3', '.m4a', '.ogg', '.opus', '.flac', '.wav', '.mp4', '.webm', '.mov']);
198const apMediaUpload = multer({
199 storage: multer.diskStorage({
200 destination: (req, file, cb) => cb(null, AP_MEDIA_DIR),
201 filename: (req, file, cb) => cb(null, `${randomUUID()}${path.extname(file.originalname || '').toLowerCase()}`),
202 }),
203 limits: { fileSize: 32 * 1024 * 1024 },
204 fileFilter: (req, file, cb) => {
205 const ext = path.extname(file.originalname || '').toLowerCase();
206 if (!AP_MEDIA_EXT.has(ext)) return cb(new Error('Media must be an image, audio or video file'));
207 cb(null, true);
208 },
209});
210router.post('/ap/users/:slug/uploadMedia', (req, res) => {
211 const auth = OAuth.verifyBearer(req.headers.authorization);
212 if (!auth || auth.site.slug !== req.params.slug) return res.status(403).end();
213 apMediaUpload.single('file')(req, res, (err) => {
214 if (err) return res.status(400).json({ error: err.message });
215 if (!req.file) return res.status(400).json({ error: 'No file' });
216 const mime = String(req.file.mimetype || '');
217 if (!/^(image|audio|video)\//.test(mime)) {
218 try { fs.unlinkSync(req.file.path); } catch { /* best effort */ }
219 return res.status(400).json({ error: 'Media must be an image, audio or video file' });
220 }
221 res.status(201).json({
222 url: '/media/reply-media/' + req.file.filename,
223 mediaType: mime,
224 name: String(req.file.originalname || '').slice(0, 120),
225 });
226 });
227});
228
229// ── Followers (count-only public, full for the owner) ─────────────
230// A C2S bearer scoped to this site (the account owner) gets the real actor
231// URIs so their own client can build a friends list; everyone else gets the
232// count only (privacy).
233// FEP-9876: enrichment is opt-in via `Prefer: return=representation` (RFC 7240).
234// Returns true and sets the response headers when the owner asked for it.
235function wantsEnriched(req, res) {
236 res.set('Vary', 'Prefer'); // enriched and bare are two representations
237 if (AP.prefersEnriched(req.get('Prefer'))) {
238 res.set('Preference-Applied', 'return=representation');
239 return true;
240 }
241 return false;
242}
243
244router.get('/ap/users/:slug/followers', (req, res) => {
245 const auth = OAuth.verifyBearer(req.headers.authorization);
246 const owner = auth && auth.site.slug === req.params.slug;
247 const site = owner ? auth.site : publicSite(req.params.slug);
248 if (!site) return res.status(404).end();
249 if (owner) {
250 const uris = db.prepare('SELECT actor_uri FROM ap_followers WHERE slug = ? ORDER BY created_at').all(site.slug).map((r) => r.actor_uri);
251 // Default = bare references; enrich only when the client asks (FEP-9876).
252 const items = wantsEnriched(req, res) ? uris.map((u) => AP.buildActorRef(site.slug, u)) : uris;
253 return AP.sendAP(res, AP.buildFollowers(baseUrl(req), site, items.length, items));
254 }
255 const n = db.prepare('SELECT COUNT(*) n FROM ap_followers WHERE slug = ?').get(site.slug).n;
256 AP.sendAP(res, AP.buildFollowers(baseUrl(req), site, n));
257});
258
259// ── Following (count-only public, full for the owner) ─────────────
260router.get('/ap/users/:slug/following', (req, res) => {
261 const auth = OAuth.verifyBearer(req.headers.authorization);
262 const owner = auth && auth.site.slug === req.params.slug;
263 const site = owner ? auth.site : publicSite(req.params.slug);
264 if (!site) return res.status(404).end();
265 if (owner) {
266 const enrich = wantsEnriched(req, res); // FEP-9876 opt-in
267 let items = [];
268 try {
269 const uris = db.prepare("SELECT actor_uri FROM ap_following WHERE slug = ? AND status = 'accepted' ORDER BY created_at").all(site.slug).map((r) => r.actor_uri);
270 items = enrich ? uris.map((u) => AP.buildActorRef(site.slug, u)) : uris;
271 } catch { /* table may not exist */ }
272 return AP.sendAP(res, AP.buildFollowing(baseUrl(req), site, items.length, items));
273 }
274 let n = 0;
275 try { n = db.prepare("SELECT COUNT(*) n FROM ap_following WHERE slug = ? AND status = 'accepted'").get(site.slug).n; } catch { /* table may not exist */ }
276 AP.sendAP(res, AP.buildFollowing(baseUrl(req), site, n));
277});
278
279// ── Featured (pinned posts → Mastodon "Featured" tab) ─────────────
280router.get('/ap/users/:slug/featured', (req, res) => {
281 const site = publicSite(req.params.slug);
282 if (!site) return res.status(404).end();
283 // NB: Mastodon DISPLAYS the featured collection in REVERSE (pins shown
284 // last-processed-first). So we emit it reversed (lowest pin priority first,
285 // rank 1 last) → Mastodon flips it back to pin-rank ascending on the profile.
286 const posts = db.prepare(
287 `SELECT id, slug, title, content, cover_image_url, cover_video_url, nsfw, content_warning, published_at, created_at
288 FROM posts WHERE site_id = ? AND status = 'published' AND (fan_only IS NULL OR fan_only = 0)
289 AND pinned IS NOT NULL AND pinned > 0
290 ORDER BY pinned DESC, COALESCE(published_at, created_at) ASC LIMIT 20`
291 ).all(site.id);
292 AP.sendAP(res, AP.buildFeatured(baseUrl(req), site, posts));
293});
294
295// ── Note ──────────────────────────────────────────────────────────
296router.get('/ap/notes/:id', (req, res) => {
297 const post = db.prepare(
298 "SELECT * FROM posts WHERE id = ? AND status = 'published' AND (fan_only IS NULL OR fan_only = 0)"
299 ).get(req.params.id);
300 if (!post) {
301 // Could be one of OUR outbound replies (ap_outbox), not a post.
302 const note = AP.getOutboxNote(baseUrl(req), req.params.id);
303 if (!note) return res.status(404).end();
304 if (!AP.apWants(req)) {
305 // A browser hit a reply's AP URL → send them to the source it replies to
306 // (where the post + its reactions live), falling back to the site home.
307 const src = (typeof note.inReplyTo === 'string' && /^https?:\/\//i.test(note.inReplyTo))
308 ? note.inReplyTo : (baseUrl(req) + '/');
309 return res.redirect(302, src);
310 }
311 return AP.sendAP(res, { '@context': AP.AP_CONTEXT, ...note });
312 }
313 const site = db.prepare('SELECT * FROM sites WHERE id = ?').get(post.site_id);
314 if (!site) return res.status(404).end();
315 const note = AP.buildNote(baseUrl(req), site, post);
316 if (!AP.apWants(req)) {
317 // A browser hit a post's AP note URL → send them to the human post page
318 // (which shows the post + its "from the fediverse" reactions).
319 return res.redirect(302, note.url || (baseUrl(req) + '/'));
320 }
321 AP.sendAP(res, { '@context': AP.AP_CONTEXT, ...note });
322});
323
324// ── Replies collection ── lets remote servers fetch a post's whole thread.
325router.get('/ap/notes/:id/replies', (req, res) => {
326 const base = baseUrl(req);
327 const items = AP.getReplyUris(base, req.params.id);
328 AP.sendAP(res, {
329 '@context': AP.AP_CONTEXT,
330 id: `${base}/ap/notes/${req.params.id}/replies`,
331 type: 'OrderedCollection',
332 totalItems: items.length,
333 orderedItems: items,
334 });
335});
336
337// ── NodeInfo ── standard instance metadata so fediverse tools recognise Klonkt.
338router.get('/.well-known/nodeinfo', (req, res) => {
339 res.type('application/json');
340 res.set('Cache-Control', 'public, max-age=3600');
341 res.send(JSON.stringify({ links: [{ rel: 'http://nodeinfo.diaspora.software/ns/schema/2.1', href: `${baseUrl(req)}/nodeinfo/2.1` }] }));
342});
343router.get('/nodeinfo/2.1', (req, res) => {
344 let users = 0; let posts = 0;
345 // "users" = public AP actors (sites), not the admin/member account rows.
346 try { users = db.prepare('SELECT COUNT(*) c FROM sites WHERE (is_public IS NULL OR is_public = 1)').get().c; } catch { /* */ }
347 try { posts = db.prepare("SELECT COUNT(*) c FROM posts WHERE status = 'published'").get().c; } catch { /* */ }
348 res.type('application/json; charset=utf-8');
349 res.set('Cache-Control', 'public, max-age=600');
350 res.send(JSON.stringify({
351 version: '2.1',
352 software: { name: 'klonkt', version: _ver, repository: 'https://github.com/roboburr/klonkt' },
353 protocols: ['activitypub'],
354 services: { inbound: [], outbound: [] },
355 openRegistrations: false,
356 usage: { users: { total: users }, localPosts: posts },
357 metadata: { nodeName: 'Klonkt' },
358 }));
359});
360
361// ── Inbox — Follow→Accept, Undo Follow (best-effort signature verify) ──
362const apJson = express.json({
363 type: ['application/activity+json', 'application/ld+json', 'application/json'],
364 limit: '1mb',
365 verify: (req, _res, buf) => { req.rawBody = buf; }, // raw body for digest verification
366});
367router.post(['/ap/users/:slug/inbox', '/ap/inbox'], apInboxLimiter, apJson, async (req, res) => {
368 try { return res.status(await AP.handleInbox(req, req.params.slug || null) || 202).end(); }
369 catch (e) { console.warn('[AP inbox] error:', e.message); return res.status(202).end(); }
370});
371
372// ── Outbox POST: ActivityPub Client-to-Server ─────────────────────
373// A bearer-authenticated client (Shaer) POSTs an activity; we translate it onto
374// the normal delivery machinery. The token is scoped to one user+site (OAuth
375// consent), so it must match the slug in the URL. (Declared after apJson, which
376// this shares with the inbox handler.)
377router.post('/ap/users/:slug/outbox', apInboxLimiter, apJson, async (req, res) => {
378 const auth = OAuth.verifyBearer(req.headers.authorization);
379 if (!auth) { res.set('WWW-Authenticate', 'Bearer'); return res.status(401).json({ error: 'invalid_token' }); }
380 if (auth.site.slug !== req.params.slug) return res.status(403).json({ error: 'wrong_site', detail: 'token is scoped to a different site' });
381 if (auth.user.readonly) return res.status(403).json({ error: 'read_only_account' });
382
383 const out = await AP.ingestOutboxActivity(auth.site, auth.user, req.body);
384 if (out.error) return res.status(out.status || 400).json({ error: out.error, detail: out.detail });
385 // 201 Created → Location header (AP spec); 202 Accepted for side-effect verbs.
386 if (out.status === 201 && out.url) res.set('Location', out.url);
387 return res.status(out.status || 202).json({ ok: true, id: out.id, url: out.url });
388});
389
390export default router;
Note: See TracBrowser for help on using the repository browser.