Changeset f70e010 in Klonkt

Timestamp:

07/01/2026 06:08:33 AM (2 months ago)

Author:

Robin Genis <roboburr@…>

Branches:

main

Children:

6053c6c

Parents:

1bc0886

Message:

fix(thumbnails): skip ffmpeg for animated remote WebP/GIF (serve original)

getRemoteThumbnail ran ffmpeg on every remote image, but ffmpeg-static can't
decode an animated WebP → the downscale failed for every animated remote cover,
logging '[thumb-remote] downscale failed' and wasting a fetch+write+ffmpeg per
cache-miss. It then fell back to the original anyway. Now detect an animated
WebP/GIF from the fetched buffer (same check as the local isAnimatedSrc) and
return null up front → the route serves the ORIGINAL, keeping the animation,
without the doomed ffmpeg call or the error log.

• src/services/ThumbnailService.js — isAnimatedBuf() guard in getRemoteThumbnail

Co-Authored-By: Claude <noreply@…>

File:

• src/services/ThumbnailService.js (modified) (2 diffs)

src/services/ThumbnailService.js

@@ -165 +165 @@
  * @returns {Promise<string|null>} cached path, or null.
  */
+// Same animation check as isAnimatedSrc but on an in-memory buffer (remote fetch): ffmpeg-static
+// can't decode an animated WebP, and flattening a GIF/animated WebP to one frame loses its motion.
+function isAnimatedBuf(buf) {
+  try {
+    if (!buf || buf.length < 21) return false;
+    if (buf.toString('ascii', 0, 3) === 'GIF') return true; // any GIF (a flattened one loses its animation)
+    // Animated WebP: RIFF…WEBP with a VP8X chunk whose flags byte (20) has the animation bit (0x02).
+    if (buf.toString('ascii', 0, 4) === 'RIFF' && buf.toString('ascii', 8, 12) === 'WEBP'
+        && buf.toString('ascii', 12, 16) === 'VP8X' && (buf[20] & 0x02) !== 0) return true;
+    return false;
+  } catch { return false; }
+}
 export async function getRemoteThumbnail(url, width) {
   if (!THUMB_SIZES.has(width) || !ffmpegPath || !url) return null;
@@ -185 +197 @@
   }
   if (buf.length > 12 * 1024 * 1024) return null;
+  // ffmpeg-static can't decode an animated WebP (the doomed downscale just logs an error), and a
+  // flattened GIF/animated WebP loses its motion → skip it and let the route serve the ORIGINAL
+  // (keeps the animation; mirrors the local path's isAnimatedSrc guard).
+  if (isAnimatedBuf(buf)) return null;
 
   await fs.promises.mkdir(path.dirname(cached), { recursive: true });