Changeset f1a23b8 in Klonkt for src/routes/posts.js

Timestamp:

07/18/2026 12:53:15 AM (8 weeks ago)

Author:

Robin <roboburr@…>

Branches:

main

Children:

05cd954

Parents:

7d19465

git-author:

Robin <roboburr@…> (07/18/2026 12:52:51 AM)

git-committer:

Robin <roboburr@…> (07/18/2026 12:53:15 AM)

Message:

Feature: Messages merges Replies + Notifications into one inbox

/messages replaces /fediverse (manage own replies) and /notifications with a
single stream, per the Robin+Bart decision. getMessages() merges notifications
with your outbound replies ('sent' items, edit/delete via their outbox routes)
and collapses consecutive likes/boosts on the same post into one grouped item.
Design refresh: filter chips (All/Conversations/Activity/Sent, client-side),
avatars with a type-dot overlay, sent items with a direction indicator and
accent border, a lock badge on private replies (visibility now flows through
getNotifications along with actor icons), and unread dots via the existing
seen-watermark (read before marking seen). The two tabs collapse into one
Messages tab carrying the badge; the bookmarklet moved to /messages; old routes
redirect. Also fixes a latent NaN-unsafe date sort in getNotifications that
scrambled ordering when a row had a garbled created_at (seen live). i18n
NL/EN/DE. 4 new tests (67 green); verified in a browser incl. grouping, chips,
private badge, edit/delete forms. Beads: klonkt-demo-pkg. Old
fedi-notifications.ejs and the authorize-interaction manage block are now
unreachable; cleanup tracked in klonkt-demo-bk8.

Co-Authored-By: Claude Opus 4.8 <noreply@…>

File:

• src/routes/posts.js (modified) (2 diffs)

src/routes/posts.js

@@ -722 +722 @@
 
 // Manage / delete your own outbound fediverse replies (site owner only).
-router.get('/fediverse', requireSiteManager, (req, res) => {
-  const site = res.locals.site;
-  const items = site ? ActivityPubService.listOutbox(site.slug) : [];
-  renderPage(req, res, 'pages/authorize-interaction', {
-    pageTitleKey: 'fedi.manage_title', bodyClass: 'on-special', // i18n: was hardcoded Dutch
-    manage: items, uri: '', target: null, sent: false, siteTitle: site ? site.title : '',
+// Messages = Reacties + Meldingen in ONE inbox (your sent replies join the stream).
+// The old /fediverse (manage) and /notifications pages redirect here.
+router.get('/messages', requireSiteManager, (req, res) => {
+  const site = res.locals.site;
+  const items = site ? ActivityPubService.getMessages(site.slug, 80) : [];
+  // Read the watermark BEFORE marking seen → unread dots on items newer than last visit.
+  const seenAt = site ? ActivityPubService.notificationsSeenAt(site.slug) : 0;
+  if (site && !isViewer(req.session.user)) ActivityPubService.markNotificationsSeen(site.slug);
+  renderPage(req, res, 'pages/messages', {
+    pageTitleKey: 'msg.title', bodyClass: 'on-special', items, seenAt,
+    success: req.query.success || null, error: req.query.error || null,
   });
 });
+router.get('/fediverse', requireSiteManager, (req, res) => res.redirect(`${res.locals.siteUrlBase || ''}/messages`));
 
 router.post('/fediverse/:id/delete', requireSiteManager, async (req, res) => {
@@ -963 +969 @@
 
 // Notifications inbox (new followers + replies/likes/boosts on your posts).
-router.get('/notifications', requireSiteManager, (req, res) => {
-  const site = res.locals.site;
-  const items = site ? ActivityPubService.getNotifications(site.slug, 80) : [];
-  // viewing = seen → clears the bell badge. A viewer (kijker) may look but must not
-  // mutate state (the global write-guard only catches non-GET, not this GET-side effect).
-  if (site && !isViewer(req.session.user)) ActivityPubService.markNotificationsSeen(site.slug);
-  renderPage(req, res, 'pages/fedi-notifications', { pageTitle: 'Meldingen', bodyClass: 'on-special', items });
-});
+router.get('/notifications', requireSiteManager, (req, res) => res.redirect(`${res.locals.siteUrlBase || ''}/messages`));
 
 // Blocking / defederation (owner-only).