Changeset f1956d7 in Klonkt

Timestamp:

07/01/2026 01:56:09 PM (2 months ago)

Author:

roboburr <roboburr@…>

Branches:

main

Children:

7b07035

Parents:

c45c187

Message:

feat(fediverse): inline @mentions in posts (link + notify)

Typing @user@host in a post now federates as a real Mastodon-style mention: the
handle is linked to the actor, added to the note's Mention tags + cc, and the note
is delivered to the mentioned person's inbox so they're notified — even if they
don't follow the site. Mirrors the existing reply-mention flow (which resolved
mentions but posts didn't). On-site the post text is unchanged for now.

• src/services/ActivityPubService.js — buildNote emits Mention tags + adds the mentioned actors to cc (from already-linked content); deliverCreate/deliverUpdate resolve inline mentions at send time (WebFinger), link the note content, and add the mentioned inboxes to the delivery set (so a mention reaches non-followers too).
• test/mentions.test.js — Mention tag shape, cc addressing, and the no-mention no-op.
• CHANGELOG(.nl/.de).md — "Mention people in a post" under Unreleased.

Co-Authored-By: Claude <noreply@…>

Files:

• CHANGELOG.de.md (modified) (1 diff)
• CHANGELOG.md (modified) (1 diff)
• CHANGELOG.nl.md (modified) (1 diff)
• src/services/ActivityPubService.js (modified) (4 diffs)
• test/mentions.test.js (added)

CHANGELOG.de.md

@@ -7 +7 @@
 
 ### Hinzugefügt
+- **Erwähne Personen in einem Beitrag.** `@benutzer@server` in einem Beitrag verlinkt jetzt auf ihr
+  Profil und benachrichtigt sie im Fediverse — auch wenn sie dir nicht folgen — wie eine Erwähnung
+  in einer Antwort.
 - **Kurze Videos im Feed spielen automatisch ab und wiederholen sich.** Ein animiertes Cover oder ein
   kurzer (≤30s) Clip im News-Feed wird jetzt automatisch stumm in Schleife abgespielt, wie ein GIF;

CHANGELOG.md

@@ -7 +7 @@
 
 ### Added
+- **Mention people in a post.** Typing `@user@server` in a post now links to their profile and
+  notifies them on the fediverse — even if they don't follow you — just like a mention in a reply.
 - **Short videos in the feed autoplay and loop.** An animated cover or a short (≤30s) clip in the
   News feed now plays automatically and loops muted, like a GIF; longer videos keep their controls.

CHANGELOG.nl.md

@@ -7 +7 @@
 
 ### Toegevoegd
+- **Noem mensen in een post.** `@gebruiker@server` in een post linkt nu naar hun profiel en stuurt
+  ze een melding op de fediverse — ook als ze je niet volgen — net als een vermelding in een reactie.
 - **Korte video's in de feed spelen automatisch af en loopen.** Een geanimeerde cover of een korte
   (≤30s) clip in de News-feed speelt nu automatisch geluidloos in een lus, als een GIF; langere

src/services/ActivityPubService.js

@@ -352 +352 @@
   for (const a of openAudio) attachment.push(a); // fedi_open tracks → native Audio players
 
+  // Inline @user@host mentions: the Mention tag objects + the mentioned actor URIs. Only
+  // present when the content was already mention-linked (deliverCreate/Update resolve them
+  // at send time); a plain buildNote (outbox/notes) yields none.
+  const _mentionTags = mentionTags(body);
+  const _mentionCc = _mentionTags.map((t) => t.href);
+
   const note = {
     id,
@@ -362 +368 @@
     // but not addressed to Public, so Mastodon shows it only to them and can't boost it).
     to: post.fan_only ? [`${aId}/followers`] : [PUBLIC],
-    cc: post.fan_only ? [] : [`${aId}/followers`],
-    tag: buildHashtagList(base, post.tags, body),
+    // Mentioned actors (from inline @user@host links the caller resolved) are addressed in cc
+    // so Mastodon notifies them; empty unless the content was mention-linked (delivery time).
+    cc: [...new Set([...(post.fan_only ? [] : [`${aId}/followers`]), ..._mentionCc])],
+    tag: [...buildHashtagList(base, post.tags, body), ..._mentionTags],
     replies: `${id}/replies`,
     // NSFW → Mastodon-style content warning: sensitive (blurs media) + a summary/spoiler
@@ -1138 +1146 @@
   const base = (process.env.PUBLIC_BASE_URL || '').replace(/\/+$/, '');
   if (!base || !site || !site.slug) return;
+  // Resolve inline @user@host mentions → link them in the note + collect their inboxes, so a
+  // mentioned person is notified even if they don't follow us (Mastodon-standard mention).
+  const mres = await resolveMentionsInText(base, post.content || '');
+  const post2 = mres.inboxes.length ? { ...post, content: mres.html } : post;
   const followers = fStmts().list.all(site.slug);
-  if (!followers.length) return;
-  const inboxes = [...new Set(followers.map((f) => f.shared_inbox || f.inbox).filter(Boolean))];
+  const inboxes = [...new Set([...followers.map((f) => f.shared_inbox || f.inbox), ...mres.inboxes].filter(Boolean))];
+  if (!inboxes.length) return; // no followers and no one mentioned
   const keys = getOrCreateKeys(site.slug);
   const keyId = `${actorId(base, site.slug)}#main-key`;
-  const create = buildCreate(base, site, post);
+  const create = buildCreate(base, site, post2);
   for (const inbox of inboxes) deliverWithRetry(site.slug, inbox, create, keyId, keys.private_pem);
 }
@@ -1195 +1207 @@
   const base = (process.env.PUBLIC_BASE_URL || '').replace(/\/+$/, '');
   if (!base || !site || !site.slug || !post || !post.id) return;
+  const mres = await resolveMentionsInText(base, post.content || ''); // link mentions + collect inboxes
+  const post2 = mres.inboxes.length ? { ...post, content: mres.html } : post;
   const followers = fStmts().list.all(site.slug);
-  if (!followers.length) return;
-  const inboxes = [...new Set(followers.map((f) => f.shared_inbox || f.inbox).filter(Boolean))];
+  const inboxes = [...new Set([...followers.map((f) => f.shared_inbox || f.inbox), ...mres.inboxes].filter(Boolean))];
+  if (!inboxes.length) return;
   const keys = getOrCreateKeys(site.slug);
   const me = actorId(base, site.slug);
-  const note = buildNote(base, site, post);
+  const note = buildNote(base, site, post2);
   note.updated = new Date().toISOString();
   const update = {
     '@context': AP_CONTEXT,
     id: `${noteId(base, post.id)}#update-${Date.now()}-${rid()}`,
-    type: 'Update', actor: me, to: [PUBLIC], cc: [`${me}/followers`],
+    type: 'Update', actor: me, to: [PUBLIC], cc: note.cc,
     object: note,
   };