Changeset ec288dc in Klonkt for src/services

Timestamp:

07/21/2026 03:11:39 AM (7 weeks ago)

Author:

Robin <roboburr@…>

Branches:

main

Children:

dede82e

Parents:

c7a211d

git-author:

Robin <roboburr@…> (07/21/2026 03:11:37 AM)

git-committer:

Robin <roboburr@…> (07/21/2026 03:11:39 AM)

Message:

Debug: show why a patron is rejected on the "Nog geen supporter" page

We are debugging boiert.eu blind (it's a self-hosted instance we can't see
the logs of), so surface the non-identifying diagnosis on the result page
itself. verifyPatron now always returns { status, cents, diag } after it
reaches Patreon, where diag is a breadcrumb: the configured campaign_id, the
memberships Patreon returned (campaign:status:cents each), and what got
picked. The paid-result page prints it small under the buttons so the tester
can read it and report back. No identity (name/email) is included or stored.

Once the cause is known this can be removed again.

Changed files:
src/services/PaidPatreonService.js

• verifyPatron returns {status,cents,diag}; null only on hard misconfig

src/routes/paid.js

• pass diag as debug to the notpatron/tier result page

src/views/pages/paid-result.ejs

• small "diagnose:" line when debug is present

-robo
Co-Authored-By: Claude Opus 4.8 <noreply@…>

File:

• src/services/PaidPatreonService.js (modified) (1 diff)

src/services/PaidPatreonService.js

@@ -164 +164 @@
 
 // Exchange a patron's auth code and read their membership of the owner's
-// campaign. Returns { status, cents } or null. The patron token is used once
-// and discarded here: nothing identifying is stored (design decision).
+// campaign. Returns { status, cents, diag } (status null = not a patron); the
+// `diag` string is a NON-identifying breadcrumb (campaign ids + status + cents)
+// so a stuck owner can see why. Returns null only on hard misconfig. The patron
+// token is used once and discarded here: nothing identifying is stored.
 export async function verifyPatron(siteId, code, redirectUri, fetchImpl = fetch) {
   const c = getOwnerConfig(siteId);
   if (!c || !c.clientId || !c.clientSecret || !c.campaignId) return null;
-  const tokenRes = await fetchImpl(TOKEN_URL, {
-    method: 'POST',
-    headers: { 'Content-Type': 'application/x-www-form-urlencoded' },
-    body: new URLSearchParams({
-      grant_type: 'authorization_code', code,
-      client_id: c.clientId, client_secret: c.clientSecret, redirect_uri: redirectUri,
-    }).toString(),
-  });
-  if (!tokenRes.ok) return null;
+  const none = (diag) => ({ status: null, cents: 0, diag });
+  let tokenRes;
+  try {
+    tokenRes = await fetchImpl(TOKEN_URL, {
+      method: 'POST',
+      headers: { 'Content-Type': 'application/x-www-form-urlencoded' },
+      body: new URLSearchParams({
+        grant_type: 'authorization_code', code,
+        client_id: c.clientId, client_secret: c.clientSecret, redirect_uri: redirectUri,
+      }).toString(),
+    });
+  } catch { return none('token_fetch_error'); }
+  if (!tokenRes.ok) return none(`token_http_${tokenRes.status}`);
   const tok = await tokenRes.json();
-  if (!tok || !tok.access_token) return null;
+  if (!tok || !tok.access_token) return none('no_access_token');
   const url = 'https://www.patreon.com/api/oauth2/v2/identity'
     + '?include=memberships.campaign'
     + '&fields%5Bmember%5D=patron_status,currently_entitled_amount_cents';
   const idRes = await fetchImpl(url, { headers: { Authorization: `Bearer ${tok.access_token}` } });
-  if (!idRes.ok) return null;
+  if (!idRes.ok) return none(`identity_http_${idRes.status}`);
   const identity = await idRes.json();
   const membership = pickCampaignMembership(identity, c.campaignId);   // token goes out of scope, discarded
-  // Diagnostic (no identity stored, only shapes): why did a real supporter get
-  // rejected? Logs the memberships Patreon returned vs the configured campaign.
-  // Nothing here is persisted; it's a one-line server log for the owner.
-  if (!membership || membership.status !== 'active_patron') {
-    const seen = ((identity && identity.included) || [])
-      .filter((it) => it.type === 'member')
-      .map((it) => {
-        const camp = it.relationships && it.relationships.campaign && it.relationships.campaign.data;
-        const a = it.attributes || {};
-        return `${camp ? camp.id : '?'}:${a.patron_status || 'null'}:${a.currently_entitled_amount_cents || 0}c`;
-      });
-    console.warn(`[paid] verifyPatron: config campaign=${c.campaignId} → memberships seen=[${seen.join(', ') || 'none'}] picked=${membership ? membership.status + '/' + membership.cents + 'c' : 'null'}`);
-  }
-  return membership;
+  const seen = ((identity && identity.included) || [])
+    .filter((it) => it.type === 'member')
+    .map((it) => {
+      const camp = it.relationships && it.relationships.campaign && it.relationships.campaign.data;
+      const a = it.attributes || {};
+      return `${camp ? camp.id : '?'}:${a.patron_status || 'null'}:${a.currently_entitled_amount_cents || 0}c`;
+    });
+  const diag = `campaign=${c.campaignId} seen=[${seen.join(', ') || 'none'}] picked=${membership ? membership.status + '/' + membership.cents + 'c' : 'null'}`;
+  if (!membership || membership.status !== 'active_patron') console.warn(`[paid] verifyPatron: ${diag}`);
+  return { status: membership ? membership.status : null, cents: membership ? membership.cents : 0, diag };
 }