Changeset dede82e in Klonkt for test

Timestamp:

07/21/2026 03:17:16 AM (7 weeks ago)

Author:

Robin <roboburr@…>

Branches:

main

Children:

072a242

Parents:

ec288dc

git-author:

Robin <roboburr@…> (07/21/2026 03:17:13 AM)

git-committer:

Robin <roboburr@…> (07/21/2026 03:17:16 AM)

Message:

Fix: derive the owner's campaign id from the creator token (strict match)

The tester's diagnose line was the smoking gun: config campaign=29148518,
but his 12 memberships (Patreon /identity returns ALL memberships across
every creator, not just this one) contained no 29148518. His real, active
pledges were to 1373144 and 16300989. So the admin campaign_id was simply
wrong, and a wrong id locks out real patrons.

Two corrections:

• Drop the sole-membership fallback added earlier. It was based on the wrong assumption that /identity is creator-scoped; with global memberships it would grant access to someone backing a DIFFERENT creator. pickCampaign- Membership is strict again: exact campaign match or nothing.
• Auto-derive the authoritative campaign id from the creator token (GET /campaigns returns the owner's own campaign), prefer it over the typed value, and self-heal the stored config when they differ. The owner no longer has to find/enter the campaign id by hand.

The diagnose line now shows owner=<from token> config=<typed> so a mismatch
is obvious.

Changed files:
src/services/PaidPatreonService.js

• pickCampaignMembership strict; fetchOwnerCampaignId (creator token); verifyPatron derives + self-heals the campaign id, richer diag

test/paid-patron.test.js

• strict match tests; fetchOwnerCampaignId with mock fetch

-robo
Co-Authored-By: Claude Opus 4.8 <noreply@…>

File:

• test/paid-patron.test.js (modified) (2 diffs)

test/paid-patron.test.js

@@ -35 +35 @@
 });
 
-test('pickCampaignMembership: sole membership is used even if campaign_id is wrong (creator-scoped)', async () => {
+test('pickCampaignMembership: STRICT — a non-matching campaign_id is refused', async () => {
   const { pickCampaignMembership } = await import('../src/services/PaidPatreonService.js');
+  // /identity returns ALL the visitor's memberships across every creator, so a
+  // membership to a DIFFERENT campaign must never grant access here.
   const id = identityWith('42', 'active_patron', 500);
-  // A typo'd campaign_id must not lock out a real patron: memberships from the
-  // owner's own client are already their campaign, so fall back to the sole one.
-  const m = pickCampaignMembership(id, '999');
-  assert.equal(m.status, 'active_patron');
-  assert.equal(m.cents, 500);
+  assert.equal(pickCampaignMembership(id, '999'), null);      // different campaign → no
+  assert.equal(pickCampaignMembership(id, ''), null);         // no campaign → null
+  assert.equal(pickCampaignMembership(id, '42').cents, 500);  // exact → yes
 });
 
-test('pickCampaignMembership: multiple memberships + no match → null (no silent grant)', async () => {
+test('fetchOwnerCampaignId reads the creator campaign from the creator token', async () => {
+  PP.saveOwnerConfig('s3', { clientId: 'c', clientSecret: 's', campaignId: 'WRONG', accessToken: 'creator-tok', refreshToken: 'r', tokenExp: Math.floor(Date.now() / 1000) + 99999 });
+  const fetchMock = async (url) => {
+    if (url.includes('/campaigns')) return { ok: true, json: async () => ({ data: [{ type: 'campaign', id: '16300989' }] }) };
+    return { ok: false, status: 404, json: async () => ({}) };
+  };
+  const id = await PP.fetchOwnerCampaignId('s3', fetchMock);
+  assert.equal(id, '16300989');
+});
+
+test('pickCampaignMembership: many memberships, only the exact campaign matches', async () => {
   const { pickCampaignMembership } = await import('../src/services/PaidPatreonService.js');
   const id = {
@@ -54 +64 @@
     ],
   };
-  assert.equal(pickCampaignMembership(id, '999'), null);      // ambiguous, refuse
-  assert.equal(pickCampaignMembership(id, '77').cents, 800);  // exact still works
+  assert.equal(pickCampaignMembership(id, '999'), null);      // none of them
+  assert.equal(pickCampaignMembership(id, '42').cents, 300);
+  assert.equal(pickCampaignMembership(id, '77').cents, 800);
 });