Changeset de89079 in Klonkt

Timestamp:

07/26/2026 10:56:43 AM (6 weeks ago)

Author:

Robin Genis <roboburr@…>

Branches:

main

Children:

c628dcd4

Parents:

42e7616

Message:

C2S: liked/boosted op de inbox-read + followers-only reply-adressering

Voor de Shaer-detailweergave (Like/Boost/Reply): de inbox-read serveert nu per
note shaer:liked/shaer:boosted (uit ap_timeline.liked/boosted), zodat de app de
knop-status toont en kan togglen/undoen. En een reply kan followers-only: als de
client de reply als .friends stuurt, respecteert de outbox dat nu (de auteur in
to + onze volgers in cc, GEEN Public). De standaard-reply blijft quiet-public.

hasGuardians blijft ongewijzigd automatisch gestempeld (keuze Robin).

Changed files:
src/routes/activitypub.js

• inbox-read: shaer:liked + shaer:boosted per note

src/services/ActivityPubService.js

• buildNote(isReply): visibility 'friends' -> cc zonder Public (followers-only)
• deliverReply accepteert visibility en bewaart 'friends' op de ap_outbox-rij
• ingestOutboxActivity geeft c2sVisibility(object) door aan de reply

New file:
test/c2s-reply-visibility.test.js

• followers-only reply (auteur+followers, geen Public), quiet-public default, direct-note

remarks: 190 tests groen (was 187).

-robo
Co-Authored-By: Claude Opus 4.8 <noreply@…>

Files:

• src/routes/activitypub.js (modified) (1 diff)
• src/services/ActivityPubService.js (modified) (4 diffs)
• test/c2s-reply-visibility.test.js (added)

src/routes/activitypub.js

@@ -191 +191 @@
         emojis: (() => { try { return t.reblog_emoji_json ? JSON.parse(t.reblog_emoji_json) : undefined; } catch { return undefined; } })(),
       } : undefined,
+      // Whether THIS account already liked/boosted the note, so the app's
+      // detail-view buttons show the current state (and can toggle/undo).
+      'shaer:liked': !!t.liked,
+      'shaer:boosted': !!t.boosted,
     },
   }));

src/services/ActivityPubService.js

@@ -278 +278 @@
         ? (JSON.parse(post.to_actors || '[]'))
         : (post.to_actor ? [post.to_actor] : [PUBLIC]),
-      cc: post.visibility === 'direct' ? [] : [PUBLIC, `${meR}/followers`],
+      // Followers-only reply ('friends', shaer detail-view Reply): the parent
+      // author (in `to`) + our followers, but NO Public — it does not federate
+      // into open discovery. Default reply stays quiet-public (Public in cc).
+      cc: post.visibility === 'direct' ? []
+        : post.visibility === 'friends' ? [`${meR}/followers`]
+          : [PUBLIC, `${meR}/followers`],
       // FEP-633c 5.2.1: a ward's call for help. Only ever on direct notes.
       ...Guardianship.helpRequestProps(post),
@@ -2145 +2150 @@
           const parent = await resolveRemoteNote(c2sIdOf(object.inReplyTo)).catch(() => null);
           if (!parent) return { status: 502, error: 'cannot_resolve_inReplyTo' };
-          const r = await deliverReply(site, { postId: parent.localPostId || '', postSlug: null, parent, text: plain });
+          // Honour the client's visibility for the reply: 'friends' (followers-
+          // only, the Shaer detail-view Reply) drops Public; anything else stays
+          // quiet-public. 'direct' was already handled above.
+          const r = await deliverReply(site, { postId: parent.localPostId || '', postSlug: null, parent, text: plain, visibility: c2sVisibility(object) });
           if (!r || !r.id) return { status: 502, error: 'reply_failed' };
           return { status: 201, id: r.id, url: `${base}/ap/notes/${r.id}` };
@@ -2257 +2265 @@
 // Send a reply FROM this site to a remote actor (in reply to their inbound reply).
 // `parent` = an ap_interactions row (actor_uri, actor_url, actor_handle, object_uri).
-export async function deliverReply(site, { postId, postSlug, parent, text, html, language, attachments, mentions }) {
+export async function deliverReply(site, { postId, postSlug, parent, text, html, language, attachments, mentions, visibility }) {
   const base = (process.env.PUBLIC_BASE_URL || '').replace(/\/+$/, '');
   // Rich replies: `html` is the reply editor's HTML (sanitized here); `text` is
@@ -2328 +2336 @@
   const id = crypto.randomUUID();
   iStmts().insO.run(id, site.slug, postId, postSlug || null, parent.object_uri || null, toActorUri, toHandle, content, replyLang, mediaJson);
+  // Followers-only reply (shaer detail-view): mark the row so buildNote drops
+  // Public from cc. Default (undefined/'public'/'quiet') stays quiet-public.
+  if (visibility === 'friends') { try { db.prepare('UPDATE ap_outbox SET visibility = ? WHERE id = ?').run('friends', id); } catch { /* ignore */ } }
   const row = iStmts().getO.get(id);
   const note = buildReplyNote(base, site, row);