Changeset dc8e9bd in Klonkt

Timestamp:

06/24/2026 02:31:09 PM (3 months ago)

Author:

Robin Genis <roboburr@…>

Branches:

main

Children:

40cf2ef

Parents:

59f0170

Message:

fix(activitypub): deliver nested replies up the WHOLE chain (post author included)

resolveRemoteNote now walks the full inReplyTo chain and collects every ancestor
author's inbox, so a reply to a deeply-nested comment reaches the root post's
instance (and threads there), not just the immediate parent's.

Co-Authored-By: Claude <noreply@…>

File:

• src/services/ActivityPubService.js (modified) (3 diffs)

src/services/ActivityPubService.js

@@ -526 +526 @@
     if (a) inboxes.add((a.endpoints && a.endpoints.sharedInbox) || a.inbox);
   }
-  if (parent.threadInbox) inboxes.add(parent.threadInbox); // post author's server (nesting)
+  if (parent.threadInbox) inboxes.add(parent.threadInbox); // back-compat (single)
+  (parent.threadInboxes || []).forEach((i) => inboxes.add(i)); // whole ancestor chain
   for (const f of fStmts().list.all(site.slug)) inboxes.add(f.shared_inbox || f.inbox);
   inboxes.delete(`${me}/inbox`);       // never deliver to ourselves (already in ap_outbox)
@@ -552 +553 @@
   // link our reply to that local post so it shows nested in the post thread.
   const localTgt = findThreadTarget(note.id, (process.env.PUBLIC_BASE_URL || '').replace(/\/+$/, ''));
-  // If this note is itself a reply (a comment), also reach the original post's
-  // author so THEIR server threads our reply under the comment.
-  let threadInbox = null;
-  if (note.inReplyTo) {
-    const parentUrl = typeof note.inReplyTo === 'string' ? note.inReplyTo : (note.inReplyTo && note.inReplyTo.id);
-    const parentNote = parentUrl ? await fetchActor(parentUrl).catch(() => null) : null;
-    const pAtt = parentNote && (typeof parentNote.attributedTo === 'string' ? parentNote.attributedTo : (parentNote.attributedTo && parentNote.attributedTo.id));
-    if (pAtt && pAtt !== actorUri) {
-      const pa = await fetchActor(pAtt).catch(() => null);
-      threadInbox = pa && ((pa.endpoints && pa.endpoints.sharedInbox) || pa.inbox);
+  // Walk the WHOLE reply chain upward (comment → parent comment → … → root post)
+  // and collect every ancestor author's inbox, so each participant's server —
+  // including the original post's author — receives + threads our reply.
+  const threadInboxes = [];
+  const seenInbox = new Set();
+  let cursor = note.inReplyTo, guard = 0;
+  while (cursor && guard++ < 6) {
+    const url = typeof cursor === 'string' ? cursor : (cursor && cursor.id);
+    if (!url) break;
+    const pn = await fetchActor(url).catch(() => null);
+    if (!pn) break;
+    const pa = typeof pn.attributedTo === 'string' ? pn.attributedTo : (pn.attributedTo && pn.attributedTo.id);
+    if (pa && pa !== actorUri) {
+      const paDoc = await fetchActor(pa).catch(() => null);
+      const inbox = paDoc && ((paDoc.endpoints && paDoc.endpoints.sharedInbox) || paDoc.inbox);
+      if (inbox && !seenInbox.has(inbox)) { seenInbox.add(inbox); threadInboxes.push(inbox); }
     }
+    cursor = pn.inReplyTo; // climb to the next ancestor
   }
   const rawHtml = String(note.content || '').replace(/\[\[(track|album|playlist):[^\]]+\]\]/gi, '');
@@ -578 +586 @@
     content: HtmlSanitizerService.sanitize(rawHtml),       // full, sanitized
     images,
-    threadInbox,                                            // post author's inbox (if a comment)
+    threadInboxes,                                          // every ancestor author's inbox
     localPostId: localTgt ? localTgt.post_id : '',          // our post this belongs to (if any)
     preview: HtmlSanitizerService.toPlainText(note.content || '').slice(0, 240),