Changeset cc3cf7d in Klonkt for test/object-links.test.js

Timestamp:

07/26/2026 08:08:15 AM (6 weeks ago)

Author:

Robin Genis <roboburr@…>

Branches:

main

Children:

6fd0e20

Parents:

eb36688

Message:

FEP-044f: object-level quotes (quoteUrl / _misskey_quote) ook als quote-link serveren

De echte reden dat quotes niet toonden: bijna geen enkele instance zet een quote
als FEP-e232 Link-tag. FEP-044f zegt dat een quote meestal een object-property is
(quote / quoteUrl / quoteUri / _misskey_quote). We keken alleen naar de tag, dus
we vonden 0 quotes (self-heal v9: 0/40 overal).

Nu normaliseren we elke quote-vorm naar één FEP-e232-vormige Link (rel
_misskey_quote) en bewaren die in link_json, naast echte FEP-e232 Link-tags
(gededupliceerd op href). De client-parser markeert rel met "quote" al als
isQuote, dus de chip verschijnt zonder client-wijziging.

Self-heal v9 -> v10 zodat bestaande timeline-rijen opnieuw langs de detectie gaan
(v9 had zich al klaar-gemarkeerd).

Changed files:
src/services/ActivityPubService.js

• extractQuoteUrl(note): leest quote/quoteUrl/quoteUri/_misskey_quote (string of embedded object)
• extractLinkJson(note): FEP-e232 Link-tags + genormaliseerde object-quote, deduped
• inbound Create, outbox-backfill en self-heal gebruiken nu extractLinkJson(note)
• SELFHEAL_VERSION 9 -> 10

test/object-links.test.js

• 3 tests: extractQuoteUrl (4 vormen + embedded), normalisatie naar Link, dedup met echte tag

remarks: 178 tests groen (was 175).

-robo
Co-Authored-By: Claude Opus 4.8 <noreply@…>

File:

• test/object-links.test.js (modified) (2 diffs)

test/object-links.test.js

@@ -6 +6 @@
 const dbMod = await import('../src/config/database.js');
 dbMod.initializeDatabase();
-const { extractObjectLinkTags, timelineObjectLinks } = await import('../src/services/ActivityPubService.js');
-const AP = { extractObjectLinkTags, timelineObjectLinks };
+const { extractObjectLinkTags, timelineObjectLinks, extractQuoteUrl, extractLinkJson } = await import('../src/services/ActivityPubService.js');
+const AP = { extractObjectLinkTags, timelineObjectLinks, extractQuoteUrl, extractLinkJson };
 
 test('extractObjectLinkTags keeps AS2-profiled ld+json and activity+json Links; drops plain links and mentions', () => {
@@ -31 +31 @@
   assert.equal(AP.timelineObjectLinks('not json'), undefined);
 });
+
+// FEP-044f: object-level quote properties are the common representation.
+test('extractQuoteUrl reads quote / quoteUrl / quoteUri / _misskey_quote (string or embedded object)', () => {
+  assert.equal(AP.extractQuoteUrl({ quote: 'https://s/objects/9' }), 'https://s/objects/9');
+  assert.equal(AP.extractQuoteUrl({ quoteUrl: 'https://s/q1' }), 'https://s/q1');
+  assert.equal(AP.extractQuoteUrl({ quoteUri: 'https://s/q2' }), 'https://s/q2');
+  assert.equal(AP.extractQuoteUrl({ _misskey_quote: 'https://s/q3' }), 'https://s/q3');
+  assert.equal(AP.extractQuoteUrl({ quote: { type: 'Link', href: 'https://s/q4' } }), 'https://s/q4');
+  assert.equal(AP.extractQuoteUrl({ content: 'no quote' }), null);
+});
+
+test('extractLinkJson normalises an object-level quote into one FEP-e232 Link (rel _misskey_quote)', () => {
+  const json = AP.extractLinkJson({ content: 'nice', quoteUrl: 'https://s/objects/9' });
+  const arr = AP.timelineObjectLinks(json);
+  assert.equal(arr.length, 1);
+  assert.equal(arr[0].href, 'https://s/objects/9');
+  assert.ok(arr[0].rel.some((r) => r.includes('quote')));
+});
+
+test('extractLinkJson merges a real FEP-e232 Link with an object-level quote, deduped by href', () => {
+  const note = {
+    tag: [{ type: 'Link', mediaType: 'application/activity+json', href: 'https://s/objects/9' }],
+    quoteUrl: 'https://s/objects/9',   // same target → not duplicated
+  };
+  const arr = AP.timelineObjectLinks(AP.extractLinkJson(note));
+  assert.equal(arr.length, 1);
+  assert.equal(arr[0].href, 'https://s/objects/9');
+});