Changeset c73ac64 in Klonkt for src

Timestamp:

06/24/2026 01:58:33 PM (3 months ago)

Author:

Robin Genis <roboburr@…>

Branches:

main

Children:

5b47619

Parents:

ffa53cc

Message:

fix(activitypub): own replies show the site identity to everyone (not 'You')

Outbound reply nodes carry the site name/handle/avatar so visitors see e.g.
'Joost Groot @demo@...' instead of 'You'; the owner still gets the delete action.

Co-Authored-By: Claude <noreply@…>

Location:

src

Files:

• routes/posts.js (modified) (1 diff)
• services/ActivityPubService.js (modified) (2 diffs)
• views/partials/fedi-node.ejs (modified) (1 diff)

src/routes/posts.js

@@ -806 +806 @@
   try {
     const _apBase = (process.env.PUBLIC_BASE_URL || `${req.protocol}://${req.get('host')}`).replace(/\/+$/, '');
-    fediverse = ActivityPubService.getInteractions(post.id, _apBase);
+    fediverse = ActivityPubService.getInteractions(post.id, _apBase, site);
   } catch { /* non-fatal */ }
   // Owner/admin of this site may reply back to a fediverse interaction.

src/services/ActivityPubService.js

@@ -250 +250 @@
 // View-ready threaded view of a post's fediverse activity (inbound replies +
 // our outbound replies, nested), plus like/boost counts.
-export function getInteractions(postId, base) {
+export function getInteractions(postId, base, site) {
   const s = iStmts();
   const rows = s.list.all(postId);
   const baseClean = (base || process.env.PUBLIC_BASE_URL || '').replace(/\/+$/, '');
   const postNoteId = baseClean ? `${baseClean}/ap/notes/${postId}` : null;
+  // Our own (outbound) replies show the SITE identity for everyone (not "You").
+  let host = ''; try { host = new URL(baseClean).host; } catch { /* ignore */ }
+  const siteName = (site && (site.title || site.slug)) || '';
+  const siteHandle = (site && site.slug && host) ? `@${site.slug}@${host}` : '';
+  const siteUrl = baseClean ? `${baseClean}/` : '';
+  const siteIcon = (site && site.profile_photo) || null;
 
   const nodes = [];
@@ -269 +275 @@
     nodes.push({
       noteId: baseClean ? `${baseClean}/ap/notes/${o.id}` : o.id, parent: o.in_reply_to || null,
-      mine: true, outboxId: o.id, content: o.content, created_at: o.created_at, children: [],
+      mine: true, outboxId: o.id, content: o.content, created_at: o.created_at,
+      actor_name: siteName, actor_handle: siteHandle, actor_url: siteUrl, actor_icon: siteIcon,
+      children: [],
     });
   }

src/views/partials/fedi-node.ejs

@@ -1 +1 @@
 <%# Renders one fediverse thread node (n). Expects: n, t, canManageSite, _base, siteAvatar, formatDateTime %>
 <div class="comment-avatar">
-  <% if (n.mine) { %>
-    <% if (typeof siteAvatar !== 'undefined' && siteAvatar) { %><img src="<%= siteAvatar %>" alt="">
-    <% } else { %><span><%= t('fedi.you').charAt(0).toUpperCase() %></span><% } %>
-  <% } else if (n.actor_icon) { %><img src="<%= n.actor_icon %>" alt="" loading="lazy">
+  <% if (n.actor_icon) { %><img src="<%= n.actor_icon %>" alt="" loading="lazy">
   <% } else { %><span><%= (n.actor_name || '?').charAt(0).toUpperCase() %></span><% } %>
 </div>
 <div class="comment-body">
   <div class="comment-meta">
-    <% if (n.mine) { %>
-      <span class="comment-author"><%= t('fedi.you') %></span>
-    <% } else { %>
-      <a class="comment-author" href="<%= n.actor_url %>" rel="nofollow noopener" target="_blank"><%= n.actor_name %></a>
-      <span class="fedi-handle"><%= n.actor_handle %></span>
-    <% } %>
+    <% if (n.actor_url) { %><a class="comment-author" href="<%= n.actor_url %>" rel="nofollow noopener" target="_blank"><%= n.actor_name %></a>
+    <% } else { %><span class="comment-author"><%= n.actor_name %></span><% } %>
+    <% if (n.actor_handle) { %><span class="fedi-handle"><%= n.actor_handle %></span><% } %>
     <% if (n.created_at) { %><span class="comment-time"><%= formatDateTime(n.created_at) %></span><% } %>
   </div>