Changeset b27cde6 in Klonkt

Timestamp:

06/21/2026 07:31:08 PM (3 months ago)

Author:

roboburr <roboburr@…>

Branches:

main

Children:

0251bae

Parents:

1ee5f65

Message:

fix(posts): duplicate title/slug no longer rejected — auto-unique (title-2, -3…)

A second post with the same title gave "A post with that slug already exists".
New uniqueSlug() helper automatically appends -2/-3/… on a collision, both on
create and on save; a reserved slug gets -post. No more blocking error.

Co-Authored-By: Claude <noreply@…>

File:

• src/routes/posts.js (modified) (4 diffs)

src/routes/posts.js

@@ -48 +48 @@
 });
 
+// Maakt een unieke slug binnen de site: 'titel', 'titel-2', 'titel-3', …
+// Zo wordt een tweede post met dezelfde titel NIET geweigerd ("bestaat al"),
+// maar krijgt 'ie automatisch een vrij achtervoegsel. exceptId = de post die
+// we bijwerken (mag z'n eigen slug houden).
+function uniqueSlug(siteId, base, exceptId = null) {
+  let candidate = base;
+  let n = 2;
+  for (;;) {
+    const row = exceptId
+      ? db.prepare('SELECT id FROM posts WHERE site_id = ? AND slug = ? AND id != ?').get(siteId, candidate, exceptId)
+      : db.prepare('SELECT id FROM posts WHERE site_id = ? AND slug = ?').get(siteId, candidate);
+    if (!row) return candidate;
+    candidate = `${base}-${n++}`;
+  }
+}
+
 const router = express.Router();
 
@@ -165 +181 @@
 
   // Generate slug from title if empty
-  const finalSlug = (slug || title || '')
+  let finalSlug = (slug || title || '')
     .toLowerCase()
     .replace(/[^a-z0-9]+/g, '-')
@@ -171 +187 @@
 
   if (!finalSlug) return res.status(400).send('Title or slug required');
-  if (RESERVED_SLUGS.has(finalSlug)) return res.status(400).send('That slug is reserved');
-
-  // Uniqueness check
-  const existing = db.prepare('SELECT id FROM posts WHERE site_id = ? AND slug = ?').get(site.id, finalSlug);
-  if (existing) return res.status(400).send('A post with that slug already exists');
+  if (RESERVED_SLUGS.has(finalSlug)) finalSlug = `${finalSlug}-post`;
+
+  // Dubbele titel/slug? Automatisch uniek maken (titel-2, titel-3, …) i.p.v. weigeren.
+  finalSlug = uniqueSlug(site.id, finalSlug);
 
   const validTypes = new Set(['post', 'foto', 'video', 'audio']);
@@ -280 +295 @@
   if (newSlug && newSlug !== post.slug) {
     const cleaned = newSlug.toLowerCase().replace(/[^a-z0-9]+/g, '-').replace(/^-|-$/g, '');
-    if (RESERVED_SLUGS.has(cleaned)) return res.status(400).send('That slug is reserved');
-    const conflict = db.prepare('SELECT id FROM posts WHERE site_id = ? AND slug = ? AND id != ?').get(site.id, cleaned, post.id);
-    if (conflict) return res.status(400).send('Slug already taken');
-    finalSlug = cleaned;
+    const safe = RESERVED_SLUGS.has(cleaned) ? `${cleaned}-post` : cleaned;
+    // Dubbele slug? Automatisch uniek maken i.p.v. weigeren (eigen post mag z'n slug houden).
+    finalSlug = uniqueSlug(site.id, safe, post.id);
   }