Changeset af21002 in Klonkt

Timestamp:

07/16/2026 12:20:51 PM (8 weeks ago)

Author:

Robin <roboburr@…>

Branches:

main

Children:

476d6e7

Parents:

2d6a9c3

git-author:

Robin <roboburr@…> (07/13/2026 05:24:58 AM)

git-committer:

Robin <roboburr@…> (07/16/2026 12:20:51 PM)

Message:

Spoor A step 2: resolve @mentions into the baked content at save

bakePostContentWithMentions() runs the same webfinger resolver the federated
copy uses, ONCE at save, and bakes @user@host profile links into
content_rendered — so the site shows clickable mentions with no per-view
lookup. cacheRenderedContent stores the sync #tag/URL bake immediately, then
re-stores with mentions resolved asynchronously, so a slow/dead remote server
never blocks the save. Unresolvable handles stay plain text; any failure keeps
the sync bake. Verified: no-mention content unchanged, dead handle degrades
gracefully, and a live @Gargron@… resolves to a profile link.

Co-Authored-By: Claude Opus 4.8 <noreply@…>

Location:

src

Files:

• routes/posts.js (modified) (1 diff)
• services/ActivityPubService.js (modified) (2 diffs)

src/routes/posts.js

@@ -243 +243 @@
 // baking on the fly if this ever fails.
 function cacheRenderedContent(postId, rawContent) {
+  const raw = rawContent || '';
+  // 1. Immediate + synchronous: bake #hashtags + URLs so the post renders enriched at once.
   try {
     db.prepare('UPDATE posts SET content_rendered = ? WHERE id = ?')
-      .run(ActivityPubService.bakePostContent(rawContent || ''), postId);
+      .run(ActivityPubService.bakePostContent(raw), postId);
   } catch (e) { /* fallback bake in the render route keeps display correct */ }
+  // 2. Async: resolve @mentions (webfinger, once) and re-store, WITHOUT blocking the save
+  //    response — a moment later the post's @mentions are clickable too. A slow/dead remote
+  //    server can't stall the save; on failure the sync bake from step 1 stands.
+  ActivityPubService.bakePostContentWithMentions(raw)
+    .then((html) => {
+      try { db.prepare('UPDATE posts SET content_rendered = ? WHERE id = ?').run(html, postId); }
+      catch (e) { /* keep the sync bake */ }
+    })
+    .catch(() => { /* keep the sync bake */ });
 }
 

src/services/ActivityPubService.js

@@ -1472 +1472 @@
 }
 
+// Step 2: the full bake, incl. @mention links. Resolves @user@host via webfinger ONCE (the
+// same resolver the federated copy uses) and bakes the profile links into content_rendered,
+// so page views never do a per-view lookup. Unresolvable handles stay plain text; on any
+// failure it degrades to the sync #hashtag/URL bake. Async (webfinger) → callers run it off
+// the save response so the request never blocks on a slow/dead remote server.
+export async function bakePostContentWithMentions(source) {
+  const withHashUrls = bakePostContent(source);
+  try { const m = await resolveMentionsInText('', withHashUrls); return m.html; }
+  catch { return withHashUrls; }
+}
+
 // Extract the AP Hashtag tag objects from already-linked reply content.
 function hashtagTags(base, content) {
@@ -2471 +2482 @@
   deliverWithRetry, enqueueDelivery, processDeliveryQueue, startDeliveryWorker,
   getReplyUris, markNotificationsSeen, countUnseenNotifications, hasPlayableAudio,
-  linkifyBody, bakePostContent, listFollowers, removeFollower,
+  linkifyBody, bakePostContent, bakePostContentWithMentions, listFollowers, removeFollower,
 };