Changeset ae05747 in Klonkt

Timestamp:

07/16/2026 12:20:51 PM (8 weeks ago)

Author:

Robin <roboburr@…>

Branches:

main

Children:

4424af7

Parents:

226b563

git-author:

Robin <roboburr@…> (07/12/2026 10:34:28 PM)

git-committer:

Robin <roboburr@…> (07/16/2026 12:20:51 PM)

Message:

Fix: federate replies, comment-deletes and reply-edits durably

deliverReply, deliverOutboxDelete and deliverOutboxUpdate delivered with a
bare deliver()+catch and dropped the activity on any failure, so a reply,
a comment-delete or an edit to a briefly-offline recipient was lost with no
retry (unlike posts, which use deliverWithRetry). Each now enqueues the
activity on failure so the existing ap_delivery retry worker resends it.
The worker re-derives the signing key from the actor slug, matching the
keyId used here.

Co-Authored-By: Claude Opus 4.8 <noreply@…>

File:

• src/services/ActivityPubService.js (modified) (3 diffs)

src/services/ActivityPubService.js

@@ -1579 +1579 @@
   let delivered = 0;
   for (const inbox of [...inboxes].filter(Boolean)) {
-    try { const st = await deliver(inbox, create, keyId, keys.private_pem); if (st >= 200 && st < 300) delivered++; } catch { /* best-effort */ }
+    let ok = false;
+    try { const st = await deliver(inbox, create, keyId, keys.private_pem); ok = st >= 200 && st < 300; } catch { ok = false; }
+    if (ok) delivered++;
+    else enqueueDelivery(site.slug, inbox, create); // durable: retry a briefly-offline recipient (was silently dropped)
   }
   console.log('[AP] outreply', site.slug, '→', parent.actor_uri, 'delivered', delivered);
@@ -1695 +1698 @@
     if (row.to_actor) { const a = await fetchActor(row.to_actor).catch(() => null); if (a) inboxes.add((a.endpoints && a.endpoints.sharedInbox) || a.inbox); }
     for (const f of fStmts().list.all(site.slug)) inboxes.add(f.shared_inbox || f.inbox);
-    for (const inbox of [...inboxes].filter(Boolean)) { try { await deliver(inbox, del, `${me}#main-key`, keys.private_pem); } catch { /* best-effort */ } }
+    for (const inbox of [...inboxes].filter(Boolean)) {
+      try { const st = await deliver(inbox, del, `${me}#main-key`, keys.private_pem); if (st >= 200 && st < 300) continue; } catch { /* queue below */ }
+      enqueueDelivery(site.slug, inbox, del); // durable: a failed comment-delete now retries (was silently dropped)
+    }
   }
   db.prepare('DELETE FROM ap_outbox WHERE id = ?').run(outboxId);
@@ -1735 +1741 @@
   let delivered = 0;
   for (const inbox of [...inboxes].filter(Boolean)) {
-    try { const st = await deliver(inbox, update, `${me}#main-key`, keys.private_pem); if (st >= 200 && st < 300) delivered++; } catch { /* best-effort */ }
+    let ok = false;
+    try { const st = await deliver(inbox, update, `${me}#main-key`, keys.private_pem); ok = st >= 200 && st < 300; } catch { ok = false; }
+    if (ok) delivered++;
+    else enqueueDelivery(site.slug, inbox, update); // durable: retry the edit later (was silently dropped)
   }
   console.log('[AP] outreply edit', site.slug, 'delivered', delivered);