Changeset abdcf33 in Klonkt

Timestamp:

06/27/2026 09:46:03 PM (2 months ago)

Author:

Robin Genis <roboburr@…>

Branches:

main

Children:

d2b7247

Parents:

3746f6a

Message:

chore(cleanup): remove the dead comments_moderation_mode column + handling

Native comments are gone; this column was set but never read. Removed from the site
INSERT (admin-sites create) and UPDATE (save) in lockstep (column + placeholder + value),
from ensurePrimarySite's seed INSERT, the ensureColumn in database.js, and the 3 unused
i18n keys (asite.comment_moderation / moderation_trust / moderation_moderate, x3 langs).
No DROP — the column stays in existing DBs as harmless dead data. require_login_to_comment
is kept (still used by PermissionsService).

Location:

src

Files:

• config/database.js (modified) (1 diff)
• routes/admin-sites.js (modified) (5 diffs)
• services/ensurePrimarySite.js (modified) (1 diff)
• services/i18n.js (modified) (3 diffs)

src/config/database.js

@@ -46 +46 @@
   ensureColumn('users', 'lang', 'TEXT');
   // Site-level moderation toggle. 'trust' = auto-approve, 'moderate' = pending until reviewed.
-  ensureColumn('sites', 'comments_moderation_mode', "TEXT DEFAULT 'moderate'");
   // Circles: whether this site may appear in other sites' circles (surfacing opt-out).
   ensureColumn('sites', 'allow_circle', 'INTEGER DEFAULT 1');

src/routes/admin-sites.js

@@ -222 +222 @@
       language, palette, accent, profile_photo,
       is_public, robots_index, require_login_to_comment, enable_audio_player,
-      feed_view_default, comments_moderation_mode
-    ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
+      feed_view_default
+    ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
   `).run(
     siteId, slug,
@@ -239 +239 @@
     (f.enable_audio_player !== undefined ? (f.enable_audio_player ? 1 : 0) : 1),
     f.feed_view_default === 'timeline' ? 'timeline' : 'grid',
-    f.comments_moderation_mode === 'trust' ? 'trust' : 'moderate',
   );
 
@@ -280 +279 @@
 
   const f = req.body;
-  const moderationMode = f.comments_moderation_mode === 'moderate' ? 'moderate' : 'trust';
   const feedViewDef = f.feed_view_default === 'grid' ? 'grid' : 'timeline';
   const profileLinksJson = buildProfileLinks(f);
@@ -300 +298 @@
       is_public = ?, robots_index = ?, require_login_to_comment = ?,
       enable_audio_player = ?,
-      comments_moderation_mode = ?,
       feed_view_default = ?, feed_view_switch = ?,
       show_search = ?, show_archive_link = ?,
@@ -321 +318 @@
     f.require_login_to_comment ? 1 : 0,
     f.enable_audio_player ? 1 : 0,
-    moderationMode,
     feedViewDef,
     f.feed_view_switch ? 1 : 0,

src/services/ensurePrimarySite.js

@@ -40 +40 @@
       language, palette, accent, profile_photo,
       is_public, robots_index, require_login_to_comment, enable_audio_player,
-      feed_view_default, comments_moderation_mode, is_primary
-    ) VALUES (?, ?, ?, '', '', ?, 'en', 'klonkt', '#e8b04b', NULL, 1, 1, 1, 1, 'grid', 'moderate', 1)
+      feed_view_default, is_primary
+    ) VALUES (?, ?, ?, '', '', ?, 'en', 'klonkt', '#e8b04b', NULL, 1, 1, 1, 1, 'grid', 1)
   `).run(siteId, slug, defaultTitle(), owner.id);
 

src/services/i18n.js

@@ -238 +238 @@
     'asite.robots_index': 'Zoekmachines mogen indexeren (sitemap.xml is verborgen indien uit)',
     'asite.require_login_comment': 'Inloggen vereist om te reageren',
-    'asite.comment_moderation': 'Reactie-moderatie',
-    'asite.moderation_trust': 'Vertrouwen (automatisch goedkeuren)',
-    'asite.moderation_moderate': 'Modereren (eerst in de wachtrij)',
     'asite.enable_audio': 'Audiospeler + embeds inschakelen',
     'asite.links': 'Social / streaming-links',
@@ -1152 +1149 @@
     'asite.robots_index': 'Allow search engines to index (sitemap.xml is hidden when off)',
     'asite.require_login_comment': 'Login required to comment',
-    'asite.comment_moderation': 'Comment moderation',
-    'asite.moderation_trust': 'Trust (approve automatically)',
-    'asite.moderation_moderate': 'Moderate (queue first)',
     'asite.enable_audio': 'Enable audio player + embeds',
     'asite.links': 'Social / streaming links',
@@ -2065 +2059 @@
     'asite.robots_index': 'Suchmaschinen dürfen indexieren (sitemap.xml ist ausgeblendet, wenn aus)',
     'asite.require_login_comment': 'Anmeldung zum Kommentieren erforderlich',
-    'asite.comment_moderation': 'Kommentar-Moderation',
-    'asite.moderation_trust': 'Vertrauen (automatisch freigeben)',
-    'asite.moderation_moderate': 'Moderieren (zuerst in die Warteschlange)',
     'asite.enable_audio': 'Audioplayer + Embeds aktivieren',
     'asite.links': 'Social- / Streaming-Links',