Changeset 9e27d64 in Klonkt for src/server.js

Timestamp:

06/14/2026 07:31:23 AM (3 months ago)

Author:

roboburr <roboburr@…>

Branches:

main

Children:

6351545

Parents:

32cc601

Message:

auth: password admin + per-instance Google for listeners (no broker)

Robin's choice: every self-hoster has their own password admin account,
and can optionally let listeners log in to comment using their OWN Google
client. No central broker (that would tie every customer site to Robin's
Google Cloud -> systemic risk on abuse).

• Admin = username/password (bcrypt). First-time setup via /auth/register (only when there are 0 users); closed afterwards. No public registration.
• Forgot password: /auth/reset-request -> email (if SMTP configured) with reset link; CLI break-glass npm run reset-admin always works (no email needed).
• Change password (logged in) restored in /account.
• Google = per-instance own credentials, OPTIONAL, listeners only -> always role member, never admin (god/admin email is rejected; google_sub mismatch too).
• config/google.js back to direct Google OAuth; config/mailer.js new (nodemailer).
• jose removed from deps; nodemailer added.

Security review (workflow) incorporated:

• Reset token no longer in production logs (dev only).
• Reset link from PUBLIC_BASE_URL instead of X-Forwarded-Host (host poisoning).
• Reset tokens stored SHA-256-hashed in the DB.
• Same-origin check on all state-modifying POSTs (CSRF layer on top of sameSite-lax).
• Login always runs one bcrypt comparison (no timing enumeration).

Co-Authored-By: Claude <noreply@…>

File:

• src/server.js (modified) (2 diffs)

src/server.js

@@ -148 +148 @@
 app.use(loadTheme);
 
+// Lichtgewicht CSRF-defense: weiger cross-origin state-wijzigende requests.
+// Same-origin forms + HTMX sturen een matchende Origin; ontbreekt Origin dan
+// laten we door (non-browser clients). sameSite:'lax' op de sessiecookie is de
+// tweede laag. (Geldt niet voor GET/HEAD/OPTIONS.)
+app.use((req, res, next) => {
+  if (req.method === 'GET' || req.method === 'HEAD' || req.method === 'OPTIONS') return next();
+  const origin = req.get('origin');
+  if (!origin) return next(); // geen Origin -> geen browser-CSRF-vector
+  let originHost;
+  try { originHost = new URL(origin).host; } catch { return res.status(403).send('Ongeldige origin'); }
+  if (originHost !== req.get('host')) return res.status(403).send('Cross-origin request geweigerd');
+  next();
+});
+
 app.use('/auth', authRoutes);
 app.use('/account', accountRoutes);
@@ -328 +342 @@
   console.log(`   ✓ Privacy:  Self-hosted fonts, no third-party requests`);
   console.log(`   ✓ Layout:   v9 editorial feel (top nav, profile header)`);
-  console.log(`   ✓ Auth:     Google login / logout`);
+  console.log(`   ✓ Auth:     wachtwoord (beheer) + Google (luisteraars) / logout`);
   console.log(`   ✓ Posts:    create / edit / view / archive`);
   console.log(`   ✓ Realtime: WebSocket server ready (Prutter)`);