Changeset 9a34d31 in Klonkt

Timestamp:

06/21/2026 06:41:31 PM (3 months ago)

Author:

roboburr <roboburr@…>

Branches:

main

Children:

e25438a

Parents:

c9c6a2d

Message:

fix(notifications): table renamed to user_notifications (collision with stale table)

Older DBs still have an unused 'notifications' table (different schema, no
read column) -> CREATE TABLE IF NOT EXISTS became a no-op and the index on
read crashed the boot (demo + demohub in crash loop). Table + queries now
use user_notifications.

Co-Authored-By: Claude <noreply@…>

Location:

src

Files:

• config/database.js (modified) (2 diffs)
• services/NotificationService.js (modified) (4 diffs)

src/config/database.js

@@ -254 +254 @@
   // Meldingen: iemand reageert op je reactie / post, of liket je post. Snapshots
   // van naam/titel zodat de lijst goedkoop te tonen is zonder joins.
-  db.exec(`
-    CREATE TABLE IF NOT EXISTS notifications (
+  // NB: bewust 'user_notifications' — sommige oudere DBs hebben nog een stale,
+  // ongebruikte 'notifications'-tabel met een ander schema (geen read-kolom).
+  db.exec(`
+    CREATE TABLE IF NOT EXISTS user_notifications (
       id TEXT PRIMARY KEY,
       user_id TEXT NOT NULL,
@@ -267 +269 @@
       created_at DATETIME DEFAULT CURRENT_TIMESTAMP
     );
-    CREATE INDEX IF NOT EXISTS idx_notif_user ON notifications(user_id, read, created_at);
+    CREATE INDEX IF NOT EXISTS idx_unotif_user ON user_notifications(user_id, read, created_at);
   `);
 

src/services/NotificationService.js

@@ -13 +13 @@
   try {
     db.prepare(`
-      INSERT INTO notifications (id, user_id, type, actor_id, actor_name, post_slug, post_title, url, read)
+      INSERT INTO user_notifications (id, user_id, type, actor_id, actor_name, post_slug, post_title, url, read)
       VALUES (?, ?, ?, ?, ?, ?, ?, ?, 0)
     `).run(randomUUID(), userId, type, actorId || null, actorName || null, postSlug || null, postTitle || null, url || null);
@@ -21 +21 @@
 export function unreadCount(userId) {
   if (!userId) return 0;
-  try { return db.prepare('SELECT COUNT(*) AS c FROM notifications WHERE user_id = ? AND read = 0').get(userId).c; }
+  try { return db.prepare('SELECT COUNT(*) AS c FROM user_notifications WHERE user_id = ? AND read = 0').get(userId).c; }
   catch { return 0; }
 }
@@ -27 +27 @@
 export function list(userId, limit = 50) {
   if (!userId) return [];
-  try { return db.prepare('SELECT * FROM notifications WHERE user_id = ? ORDER BY created_at DESC LIMIT ?').all(userId, limit); }
+  try { return db.prepare('SELECT * FROM user_notifications WHERE user_id = ? ORDER BY created_at DESC LIMIT ?').all(userId, limit); }
   catch { return []; }
 }
@@ -33 +33 @@
 export function markAllRead(userId) {
   if (!userId) return;
-  try { db.prepare('UPDATE notifications SET read = 1 WHERE user_id = ? AND read = 0').run(userId); } catch { /* noop */ }
+  try { db.prepare('UPDATE user_notifications SET read = 1 WHERE user_id = ? AND read = 0').run(userId); } catch { /* noop */ }
 }