Changeset 8cf8b5f in Klonkt

Timestamp:

07/01/2026 09:31:54 PM (2 months ago)

Author:

roboburr <roboburr@…>

Branches:

main

Children:

c06816e

Parents:

badbba8

Message:

feat(fediverse): cover art on federated Audio attachments (AS2 icon)

A fedi_open track's Audio attachment now carries artwork as an AS2 icon (the
track cover, else the post cover), so receivers whose audio player supports
artwork (Mastodon's shows a thumbnail) render it instead of a blank tile. Purely
additive — a receiver that ignores icon is unaffected.

• src/services/ActivityPubService.js — addRow selects t.cover_url and attaches icon {type:Image, mediaType, url} with post-cover fallback (track + playlist SELECTs).
• test/audio-attachment-art.test.js — track cover, post-cover fallback, no-cover no-icon.
• CHANGELOG(.nl/.de).md — "Cover art on openly shared audio" under Unreleased.

Co-Authored-By: Claude <noreply@…>

Files:

• CHANGELOG.de.md (modified) (1 diff)
• CHANGELOG.md (modified) (1 diff)
• CHANGELOG.nl.md (modified) (1 diff)
• src/services/ActivityPubService.js (modified) (1 diff)
• test/audio-attachment-art.test.js (added)

CHANGELOG.de.md

@@ -7 +7 @@
 
 ### Hinzugefügt
+- **Cover-Art bei offen geteiltem Audio.** Ein offen im Fediverse geteilter Track trägt jetzt sein
+  Cover (oder das Beitragscover) mit, sodass Audio-Player, die Artwork unterstützen, es statt einer
+  leeren Kachel anzeigen.
 - **Einen Beitrag im Fediverse melden.** Von einem Fediverse-Beitrag aus kannst du ihn jetzt den
   Moderatoren seines Heimatservers melden, mit optionaler Begründung — und meldet jemand deine Seite,

CHANGELOG.md

@@ -7 +7 @@
 
 ### Added
+- **Cover art on openly shared audio.** A track shared openly on the fediverse now carries its
+  cover art (or the post cover), so audio players that support artwork show it instead of a blank tile.
 - **Report a post to the fediverse.** From a fediverse post you can now report it to the moderators
   of its own home server, with an optional reason — and if someone reports your site, the report

CHANGELOG.nl.md

@@ -7 +7 @@
 
 ### Toegevoegd
+- **Cover-art op openbaar gedeelde audio.** Een track die je openbaar op de fediverse deelt draagt
+  nu z'n cover-art mee (of de post-cover), zodat audiospelers die artwork ondersteunen die tonen in
+  plaats van een leeg vlak.
 - **Rapporteer een post op de fediverse.** Vanaf een fediverse-post kun je die nu melden bij de
   moderators van de eigen server van die post, met een optionele reden — en meldt iemand jouw site,

src/services/ActivityPubService.js

@@ -299 +299 @@
       const fn = r.filename || (r.storage_path || '').split('/').pop();
       if (!fn || seenA.has(fn)) return; seenA.add(fn);
-      openAudio.push({ type: 'Audio', mediaType: r.mime_type || 'audio/mpeg', url: `${base}/audio/stream/${encodeURIComponent(fn)}`, name: r.title || 'Audio' });
+      const a = { type: 'Audio', mediaType: r.mime_type || 'audio/mpeg', url: `${base}/audio/stream/${encodeURIComponent(fn)}`, name: r.title || 'Audio' };
+      // Cover art on the Audio attachment (AS2 `icon`): track cover, else the post cover.
+      // Mastodon renders it as the artwork thumbnail on its native audio player.
+      const art = abs(r.cover_url || post.cover_image_url || null);
+      if (art) a.icon = { type: 'Image', mediaType: mediaType(art), url: art };
+      openAudio.push(a);
     };
-    const SEL = 'SELECT t.title, m.filename, m.storage_path, m.mime_type FROM audio_tracks t JOIN media m ON m.id = t.media_id WHERE t.fedi_open = 1 AND ';
+    const SEL = 'SELECT t.title, t.cover_url, m.filename, m.storage_path, m.mime_type FROM audio_tracks t JOIN media m ON m.id = t.media_id WHERE t.fedi_open = 1 AND ';
     try {
       for (const mm of (post.content || '').matchAll(/\[\[track:([A-Za-z0-9_-]+)\]\]/g)) { const r = db.prepare(SEL + 't.id = ?').get(mm[1]); if (r) addRow(r); }
       for (const mm of (post.content || '').matchAll(/\[\[album:([^\]]+)\]\]/g)) for (const r of db.prepare(SEL + 't.site_id = ? AND t.album = ? ORDER BY t.rowid').all(site.id, mm[1].trim())) addRow(r);
-      for (const mm of (post.content || '').matchAll(/\[\[playlist:([A-Za-z0-9_-]+)\]\]/g)) for (const r of db.prepare('SELECT t.title, m.filename, m.storage_path, m.mime_type FROM playlist_tracks pt JOIN audio_tracks t ON t.id = pt.track_id JOIN media m ON m.id = t.media_id WHERE t.fedi_open = 1 AND pt.playlist_id = ? ORDER BY pt.position').all(mm[1])) addRow(r);
+      for (const mm of (post.content || '').matchAll(/\[\[playlist:([A-Za-z0-9_-]+)\]\]/g)) for (const r of db.prepare('SELECT t.title, t.cover_url, m.filename, m.storage_path, m.mime_type FROM playlist_tracks pt JOIN audio_tracks t ON t.id = pt.track_id JOIN media m ON m.id = t.media_id WHERE t.fedi_open = 1 AND pt.playlist_id = ? ORDER BY pt.position').all(mm[1])) addRow(r);
     } catch { /* non-fatal */ }
   }