Changeset 8b700ad in Klonkt

Timestamp:

06/30/2026 01:38:10 PM (2 months ago)

Author:

roboburr <roboburr@…>

Branches:

main

Children:

d8e3ff7

Parents:

462a931

Message:

fix(federation): refresh ap_timeline.url on inbound Update (remote slug rename kept a dead link)

A remote post's AP id is stable across a slug rename, but its human url changes. The inbound
Update handler refreshed content/media but not url, so a renamed remote post kept linking to the
old, now-404 URL. Now COALESCE the new url in. (like/boost key on the stable AP id and are
unaffected by the rename.)

Co-Authored-By: Claude <noreply@…>

File:

• src/services/ActivityPubService.js (modified) (1 diff)

src/services/ActivityPubService.js

@@ -829 +829 @@
       const media = mediaFromNote(o);
       try {
-        const r = db.prepare('UPDATE ap_timeline SET content = ?, media_json = ?, nsfw = ?, cw = ? WHERE id = ? AND author_uri = ?')
-          .run(html, media, o.sensitive ? 1 : 0, o.summary || null, o.id, claimedActor);
+        // Refresh url too (COALESCE keeps the old one if the Update omits it): a remote slug
+        // rename keeps the same AP id but changes the human url, so without this the cached
+        // post would keep linking to the old, now-dead URL.
+        const r = db.prepare('UPDATE ap_timeline SET content = ?, media_json = ?, nsfw = ?, cw = ?, url = COALESCE(?, url) WHERE id = ? AND author_uri = ?')
+          .run(html, media, o.sensitive ? 1 : 0, o.summary || null, o.url || null, o.id, claimedActor);
         if (r.changes) console.log('[AP] timeline update', claimedActor, '→', o.id);
       } catch { /* ignore */ }