Changeset 80c36a1 in Klonkt

Timestamp:

06/27/2026 01:04:55 AM (2 months ago)

Author:

Robin Genis <roboburr@…>

Branches:

main

Children:

dcff893

Parents:

e390844

Message:

feat(fedi): fans-only = followers-only federation (option A)

A fan_only post now federates to your followers but addressed followers-only (to:
followers, no Public) so only they see it in their feed and it can't be boosted public.
buildNote sets the audience from post.fan_only; create/save/scheduler/delete hooks no
longer skip fan_only (they pass fan_only through). The public outbox still excludes
fan_only, and the on-site fan-gate is unchanged (so it stays hidden on the site).

Location:

src

Files:

• routes/posts.js (modified) (3 diffs)
• services/ActivityPubService.js (modified) (1 diff)
• services/Scheduler.js (modified) (1 diff)

src/routes/posts.js

@@ -232 +232 @@
     } catch (e) { /* FTS index issues are non-fatal */ }
 
-    // ActivityPub: federate a freshly published public post to followers.
-    if (!fanOnly) {
+    // ActivityPub: federate a freshly published post to followers. fan_only → delivered
+    // to followers but addressed followers-only (option A: "fans" = your fedi followers).
+    if (status === 'published') {
       ActivityPubService.deliverCreate(site, {
         id: postId, slug: finalSlug, title: title || finalSlug,
         content: cleanContent, cover_image_url: cover_image_url || null,
-        published_at: publishedAt, created_at: now,
+        published_at: publishedAt, created_at: now, fan_only: fanOnly,
       }).catch(() => { /* best-effort */ });
     }
@@ -356 +357 @@
   // ActivityPub: federate edits to followers. A post that BECOMES published →
   // Create (new post); an already-published post that's edited → Update (so
-  // Mastodon refreshes its cached copy). fan_only posts don't federate.
-  if (finalStatus === 'published' && !fanOnly) {
+  // Mastodon refreshes its cached copy). fan_only → followers-only (option A).
+  if (finalStatus === 'published') {
     const apPost = {
       id: post.id, slug: finalSlug, title: title || finalSlug,
       content: cleanContent, cover_image_url: cover_image_url || null,
-      published_at: publishedAt, created_at: post.created_at,
+      published_at: publishedAt, created_at: post.created_at, fan_only: fanOnly,
     };
     if (post.status !== 'published') ActivityPubService.deliverCreate(site, apPost).catch(() => { /* best-effort */ });
@@ -391 +392 @@
   }
 
-  // ActivityPub: tell followers the post is gone (Delete + Tombstone), but only
-  // if it was actually federated (published + not fan-only). Fire before the row
-  // is removed — we still have post.id (= the Note id).
-  if (post.status === 'published' && !post.fan_only) {
+  // ActivityPub: tell followers the post is gone (Delete + Tombstone) if it was
+  // federated (any published post now federates — fan_only goes followers-only).
+  // Fire before the row is removed — we still have post.id (= the Note id).
+  if (post.status === 'published') {
     ActivityPubService.deliverDelete(site, post).catch(() => { /* best-effort */ });
   }

src/services/ActivityPubService.js

@@ -240 +240 @@
     url: human,
     published: new Date(post.published_at || post.created_at || Date.now()).toISOString(),
-    to: [PUBLIC],
-    cc: [`${aId}/followers`],
+    // fan_only = "fans only" → followers-only visibility (delivered to your followers
+    // but not addressed to Public, so Mastodon shows it only to them and can't boost it).
+    to: post.fan_only ? [`${aId}/followers`] : [PUBLIC],
+    cc: post.fan_only ? [] : [`${aId}/followers`],
     tag: Array.isArray(post.tags) ? post.tags.map((t) => ({ type: 'Hashtag', name: '#' + String(t).replace(/\s+/g, '') })) : [],
     replies: `${id}/replies`,

src/services/Scheduler.js

@@ -32 +32 @@
       // get a duplicate FTS row → duplicate search hits.
       try { ftsDel.run(p.id); fts.run(HtmlSanitizerService.toPlainText(p.content || ''), p.title || '', p.username || '', p.id); } catch { /* FTS failure is non-fatal */ }
-      // ActivityPub: federate the now-published post to followers.
-      if (!p.fan_only) {
-        try {
-          const site = siteStmt.get(p.site_id);
-          if (site) {
-            ActivityPubService.deliverCreate(site, {
-              id: p.id, slug: p.slug, title: p.title || p.slug,
-              content: p.content, cover_image_url: p.cover_image_url || null,
-              published_at: p.published_at || p.publish_at, created_at: p.created_at,
-            }).catch(() => { /* best-effort */ });
-          }
-        } catch { /* non-fatal */ }
-      }
+      // ActivityPub: federate the now-published post to followers (fan_only → followers-only).
+      try {
+        const site = siteStmt.get(p.site_id);
+        if (site) {
+          ActivityPubService.deliverCreate(site, {
+            id: p.id, slug: p.slug, title: p.title || p.slug,
+            content: p.content, cover_image_url: p.cover_image_url || null,
+            published_at: p.published_at || p.publish_at, created_at: p.created_at, fan_only: p.fan_only,
+          }).catch(() => { /* best-effort */ });
+        }
+      } catch { /* non-fatal */ }
     }
     return due.length;