Changeset 7d19465 in Klonkt for src/services/ActivityPubService.js

Timestamp:

07/17/2026 02:27:52 AM (8 weeks ago)

Author:

Robin <roboburr@…>

Branches:

main

Children:

f1a23b8

Parents:

92a2c46

git-author:

Robin <roboburr@…> (07/17/2026 02:27:34 AM)

git-committer:

Robin <roboburr@…> (07/17/2026 02:27:52 AM)

Message:

Fix: boosted video-only posts keep their media in the Circle (Loops)

Boosting a video-only post lost its media twice over: resolveRemoteNote only
surfaced image/* attachments (images list), so upsertBoostedNote stored
media_json=[] for a Loops video; and its refresh-UPDATE clobbered an existing
good media_json (cached via following) with that empty set. resolveRemoteNote
now also returns full typed media via mediaFromNote (images stays image-only
for the interact preview); upsertBoostedNote prefers the typed media and its
refresh keeps cached media when the resolve yielded none. Verified live: the
reported Loops file is 2.9MB with moov in reach, and a seeded boosted video row
now renders a grid tile with a real generated poster (200 image/webp, 13KB).
Covered by test/boost-media.test.js (63 tests green). Reported by Robin.

Co-Authored-By: Claude Opus 4.8 <noreply@…>

File:

• src/services/ActivityPubService.js (modified) (3 diffs)

src/services/ActivityPubService.js

@@ -1828 +1828 @@
     cw: note.summary || '',
     images,
+    // Full typed media (incl. video/mp4) for the timeline cache. `images` above is
+    // image-only for the interact page preview; a boosted video-only post (Loops)
+    // lost its media entirely because upsertBoostedNote only saw `images`.
+    media: mediaFromNote(note),
     threadInboxes,                                          // every ancestor author's inbox
     localPostId: localTgt ? localTgt.post_id : '',          // our post this belongs to (if any)
@@ -2014 +2018 @@
   if (!slug || !note || !note.object_uri) return;
   const id = note.object_uri;
-  const media = JSON.stringify((note.images || []).map((u) => ({ url: u, type: 'image/jpeg' })));
+  // Prefer the full typed media (incl. video/mp4 — a Loops boost is video-only and
+  // rendered a bare text tile); fall back to the image-only list for older callers.
+  const media = (note.media && note.media !== '[]')
+    ? note.media
+    : JSON.stringify((note.images || []).map((u) => ({ url: u, type: 'image/jpeg' })));
   try {
     const r = tlStmts().ins.run(id, slug, note.actor_uri || '', note.actor_name || '', note.actor_handle || '',
@@ -2023 +2031 @@
       // resolved note. Without this a row cached without its cover (or with
       // stale content) stayed stale forever — even boosting again didn't heal it.
-      db.prepare('UPDATE ap_timeline SET content = ?, media_json = ?, nsfw = ?, cw = ?, url = COALESCE(?, url) WHERE slug = ? AND id = ?')
-        .run(note.content || '', media, note.sensitive ? 1 : 0, note.cw || null, note.url || null, slug, id);
+      // Keep the CACHED media when the resolve yielded none: an empty re-resolve
+      // used to clobber a good media_json (the followed copy had the video, the
+      // boost wiped it to []).
+      db.prepare(`UPDATE ap_timeline SET content = ?, media_json = CASE WHEN ? = '[]' THEN media_json ELSE ? END,
+                  nsfw = ?, cw = ?, url = COALESCE(?, url) WHERE slug = ? AND id = ?`)
+        .run(note.content || '', media, media, note.sensitive ? 1 : 0, note.cw || null, note.url || null, slug, id);
     }
   } catch { /* ignore */ }