Changeset 6fd0e20 in Klonkt for test

Timestamp:

07/26/2026 08:20:58 AM (6 weeks ago)

Author:

Robin Genis <roboburr@…>

Branches:

main

Children:

af6e085

Parents:

cc3cf7d

Message:

FEP-044f: Klonkt resolvet de geciteerde post voor een ingebedde quote-kaart

De client kan remote AP-objecten niet gesigneerd ophalen, dus Klonkt resolvet de
quote emit-side tot een compacte, gesaneerde snapshot en serveert die als
shaer:quote op de C2S inbox-read. De client rendert daarmee een geneste kaart
(auteur + avatar + tekst + evt. thumbnail) i.p.v. alleen de link-chip.

resolveQuote(note) haalt de quoted post op (SSRF-safe apGetJson), pakt de auteur
(fetchActor + actorInfo) en saneert de content met dezelfde sanitizer als elke
andere note (kindveilig blijft gelden). Best-effort: faalt de fetch, dan blijft
quote_json leeg en valt de client terug op de chip.

Bron-URL via quoteHrefOf: object-level quote (FEP-044f) of een quote-rel
FEP-e232 Link. Resolutie op inbound (fire-and-forget, blokkeert de inbox-response
niet), op outbox-backfill (await) en in self-heal (v10 -> v11, met COALESCE-gedrag
zodat een tijdelijk onbereikbare quoted post de cache niet leegt).

Changed files:
src/config/database.js

• ap_timeline.quote_json kolom

src/services/ActivityPubService.js

• quoteHrefOf(note): quoted-post-URL uit object-quote of quote-rel Link
• resolveQuote(note): async snapshot {url, author, content, published, media}
• timelineQuote(quoteJson): snapshot terug voor de inbox-read
• inbound (fire-and-forget), backfill (await), self-heal v11 (await + COALESCE)
• timelineQuote in de default-export

src/routes/activitypub.js

• inbox-read serveert shaer:quote (de geresolvede snapshot)

test/object-links.test.js

• quoteHrefOf (object-quote + quote-rel Link + geen) en timelineQuote round-trip

remarks: 180 tests groen (was 178). resolveQuote zelf is netwerk, niet in de unit-test.

-robo
Co-Authored-By: Claude Opus 4.8 <noreply@…>

File:

• test/object-links.test.js (modified) (2 diffs)

test/object-links.test.js

@@ -6 +6 @@
 const dbMod = await import('../src/config/database.js');
 dbMod.initializeDatabase();
-const { extractObjectLinkTags, timelineObjectLinks, extractQuoteUrl, extractLinkJson } = await import('../src/services/ActivityPubService.js');
-const AP = { extractObjectLinkTags, timelineObjectLinks, extractQuoteUrl, extractLinkJson };
+const { extractObjectLinkTags, timelineObjectLinks, extractQuoteUrl, extractLinkJson, quoteHrefOf, timelineQuote } = await import('../src/services/ActivityPubService.js');
+const AP = { extractObjectLinkTags, timelineObjectLinks, extractQuoteUrl, extractLinkJson, quoteHrefOf, timelineQuote };
 
 test('extractObjectLinkTags keeps AS2-profiled ld+json and activity+json Links; drops plain links and mentions', () => {
@@ -59 +59 @@
   assert.equal(arr[0].href, 'https://s/objects/9');
 });
+
+// FEP-044f embedded quote card: the quoted-post URL feeds the resolver.
+test('quoteHrefOf reads an object-level quote or a quote-rel FEP-e232 Link', () => {
+  assert.equal(AP.quoteHrefOf({ quoteUrl: 'https://s/q1' }), 'https://s/q1');
+  assert.equal(AP.quoteHrefOf({
+    tag: [{ type: 'Link', href: 'https://s/q2', rel: 'https://misskey-hub.net/ns#_misskey_quote' }],
+  }), 'https://s/q2');
+  assert.equal(AP.quoteHrefOf({ content: 'plain, no quote' }), null);
+  // a plain (non-quote) FEP-e232 reference is not a quote target
+  assert.equal(AP.quoteHrefOf({ tag: [{ type: 'Link', href: 'https://s/ref', rel: 'mention' }] }), null);
+});
+
+test('timelineQuote round-trips the stored snapshot; junk → undefined', () => {
+  const snap = JSON.stringify({ url: 'https://s/q', author: { name: 'A', handle: '@a@s', icon: null }, content: '<p>hi</p>' });
+  const back = AP.timelineQuote(snap);
+  assert.equal(back.url, 'https://s/q');
+  assert.equal(back.author.handle, '@a@s');
+  assert.equal(AP.timelineQuote(null), undefined);
+  assert.equal(AP.timelineQuote('not json'), undefined);
+});