Changeset 6dd1a3f in Klonkt

Timestamp:

07/04/2026 05:26:26 PM (2 months ago)

Author:

roboburr <roboburr@…>

Branches:

main

Children:

14f54a7

Parents:

236e11b

Message:

fix(ap): upsertBoostedNote refreshes an already-cached row

Root cause of "cover still missing on sound-fabrics" after both earlier
fixes: the self-heal is once-per-version and silently skips a note whose
fetch fails at that moment (the phone-hosted origin was briefly
unreachable when v6 ran), and upsertBoostedNote was INSERT OR IGNORE
only - so the stale coverless row could never be repaired, not even by
boosting the post again.

Now, when the INSERT is ignored because the row exists, the row is
UPDATEd with the freshly resolved note (content, media/cover, nsfw, cw,
url). Boosting a post again therefore always heals its cached copy.

Verified in isolation against the real schema: stale coverless row +
re-boost -> cover present, content refreshed. Suite 45/45.

• src/services/ActivityPubService.js - update branch in upsertBoostedNote
• CHANGELOG(.nl/.de).md - extended the existing Unreleased bullet (3 languages)

Co-Authored-By: Claude <noreply@…>

Files:

• CHANGELOG.de.md (modified) (1 diff)
• CHANGELOG.md (modified) (1 diff)
• CHANGELOG.nl.md (modified) (1 diff)
• src/services/ActivityPubService.js (modified) (1 diff)

CHANGELOG.de.md

@@ -9 +9 @@
 - **Boosts, die ihr Cover verloren hatten, bekommen es automatisch zurück.**
   Beiträge, die du vor dem Cover-Fix geboostet hast, waren ohne Artwork
-  gespeichert; sie werden beim nächsten Neustart einmalig aufgefrischt.
+  gespeichert; sie werden beim nächsten Neustart einmalig aufgefrischt. Einen
+  Beitrag erneut zu boosten aktualisiert jetzt ebenfalls die gespeicherte Kopie
+  (Cover, Inhalt) — ein veralteter Boost lässt sich also auch von Hand heilen.
 
 ## [1.3.3] — 2026-07-03

CHANGELOG.md

@@ -9 +9 @@
 - **Boosts that lost their cover get it back automatically.** Posts you boosted
   before the cover fix were cached without their artwork; they are refreshed
-  once on the next restart.
+  once on the next restart. Boosting a post again now also refreshes its cached
+  copy (cover, content), so a stale boost can always be healed by hand too.
 
 ## [1.3.3] — 2026-07-03

CHANGELOG.nl.md

@@ -9 +9 @@
 - **Boosts die hun cover kwijt waren krijgen 'm automatisch terug.** Posts die
   je vóór de cover-fix boostte waren zonder artwork opgeslagen; die worden bij
-  de volgende herstart eenmalig ververst.
+  de volgende herstart eenmalig ververst. Een post opnieuw boosten ververst nu
+  ook de opgeslagen kopie (cover, inhoud), dus een oude boost is altijd ook
+  handmatig te genezen.
 
 ## [1.3.3] — 2026-07-03

src/services/ActivityPubService.js

@@ -1839 +1839 @@
   const media = JSON.stringify((note.images || []).map((u) => ({ url: u, type: 'image/jpeg' })));
   try {
-    tlStmts().ins.run(id, slug, note.actor_uri || '', note.actor_name || '', note.actor_handle || '',
+    const r = tlStmts().ins.run(id, slug, note.actor_uri || '', note.actor_name || '', note.actor_handle || '',
       note.actor_icon || '', note.actor_url || '', note.content || '', note.url || null,
       new Date().toISOString(), media, note.sensitive ? 1 : 0, note.cw || null);
+    if (!r.changes) {
+      // Row already cached (INSERT OR IGNORE) → refresh it with the freshly
+      // resolved note. Without this a row cached without its cover (or with
+      // stale content) stayed stale forever — even boosting again didn't heal it.
+      db.prepare('UPDATE ap_timeline SET content = ?, media_json = ?, nsfw = ?, cw = ?, url = COALESCE(?, url) WHERE slug = ? AND id = ?')
+        .run(note.content || '', media, note.sensitive ? 1 : 0, note.cw || null, note.url || null, slug, id);
+    }
   } catch { /* ignore */ }
   markBoosted(slug, id);