Changeset 594cc50 in Klonkt

Timestamp:

06/24/2026 12:47:56 PM (3 months ago)

Author:

Robin Genis <roboburr@…>

Branches:

main

Children:

2826bb97

Parents:

3d7312a

Message:

fix(activitypub): remote-reply button — data attrs + delegated handler

The inline onclick used JSON.stringify (double quotes) inside a double-quoted
attribute, which closed the attribute early and broke the button. Replaced with
data-* attributes + a single delegated click handler.

Co-Authored-By: Claude <noreply@…>

File:

• src/views/pages/post.ejs (modified) (1 diff)

src/views/pages/post.ejs

@@ -139 +139 @@
   <% var _postAbsUrl = (typeof ogOrigin !== 'undefined' && ogOrigin ? ogOrigin : '') + (typeof _base !== 'undefined' && _base ? _base : '') + '/' + post.slug; %>
   <div class="post-fediverse-cta">
-    <button type="button" class="btn fedi-remote-reply-btn"
-      onclick="(function(){var d=prompt(<%- JSON.stringify(t('fedi.remote_prompt')) %>);if(!d)return;d=d.trim().replace(/^@?[^@\s]*@/,'').replace(/^https?:\/\//i,'').replace(/\/.*$/,'').trim();if(d)location.href='https://'+d+'/authorize_interaction?uri='+encodeURIComponent(<%- JSON.stringify(_postAbsUrl) %>);})()">
-      🐘 <%= t('fedi.remote_reply') %>
-    </button>
+    <button type="button" class="btn fedi-remote-reply-btn" data-fedi-uri="<%= _postAbsUrl %>" data-fedi-prompt="<%= t('fedi.remote_prompt') %>">🐘 <%= t('fedi.remote_reply') %></button>
   </div>
+  <script>
+  (function(){
+    if (window.__fediRemoteWired) return; window.__fediRemoteWired = true;
+    document.addEventListener('click', function(e){
+      var b = e.target.closest && e.target.closest('.fedi-remote-reply-btn');
+      if (!b) return;
+      var d = prompt(b.getAttribute('data-fedi-prompt') || ''); if (!d) return;
+      d = d.trim().replace(/^@?[^@\s]*@/, '').replace(/^https?:\/\//i, '').replace(/\/.*$/, '').trim();
+      if (d) location.href = 'https://' + d + '/authorize_interaction?uri=' + encodeURIComponent(b.getAttribute('data-fedi-uri') || '');
+    });
+  })();
+  </script>
 
   <!-- Comments -->