Changeset 5924bbf in Klonkt

Timestamp:

06/30/2026 01:42:44 PM (2 months ago)

Author:

roboburr <roboburr@…>

Branches:

main

Children:

2306abd

Parents:

d8e3ff7

Message:

fix(federation): self-heal also refreshes ap_timeline.url (heals dead links from a remote slug rename)

The inbound Update handler now refreshes url, but existing cached rows keep the old (dead) url
until re-fetched. selfHeal re-fetches cached notes but didn't update url either; now it does, and
SELFHEAL_VERSION 3->4 triggers a one-time re-sync at boot so already-cached renamed posts get the
correct link.

Co-Authored-By: Claude <noreply@…>

File:

• src/services/ActivityPubService.js (modified) (3 diffs)

src/services/ActivityPubService.js

@@ -1500 +1500 @@
 // during a flux window, e.g. a fleet-wide update), and drops notes that are gone
 // (404/410). Bump SELFHEAL_VERSION only on a release that warrants a re-sync.
-const SELFHEAL_VERSION = 3;
+const SELFHEAL_VERSION = 4;
 async function fetchNoteAP(url) {
   try {
@@ -1572 +1572 @@
     if (cur >= SELFHEAL_VERSION) return; // already healed for this version — skip on normal boots
     let rows = [];
-    try { rows = db.prepare('SELECT id, content, media_json, nsfw, cw FROM ap_timeline ORDER BY rowid DESC LIMIT 200').all(); } catch { /* no table */ }
+    try { rows = db.prepare('SELECT id, content, media_json, nsfw, cw, url FROM ap_timeline ORDER BY rowid DESC LIMIT 200').all(); } catch { /* no table */ }
     let healed = 0;
     for (const r of rows) {
@@ -1583 +1583 @@
         const nsfw = note.sensitive ? 1 : 0;   // re-sync NSFW/sensitive + CW onto already-cached posts
         const cw = note.summary || null;
-        if ((html && html !== r.content) || media !== (r.media_json || '[]') || nsfw !== (r.nsfw || 0) || (cw || '') !== (r.cw || '')) {
-          db.prepare('UPDATE ap_timeline SET content = ?, media_json = ?, nsfw = ?, cw = ? WHERE id = ?').run(html || r.content, media, nsfw, cw, r.id);
+        const url = note.url || null;          // re-sync the human url (catches a remote slug rename)
+        if ((html && html !== r.content) || media !== (r.media_json || '[]') || nsfw !== (r.nsfw || 0) || (cw || '') !== (r.cw || '') || (url && url !== r.url)) {
+          db.prepare('UPDATE ap_timeline SET content = ?, media_json = ?, nsfw = ?, cw = ?, url = COALESCE(?, url) WHERE id = ?').run(html || r.content, media, nsfw, cw, url, r.id);
           healed++;
         }