Changeset 5190152 in Klonkt for src/assets/js

Timestamp:

07/19/2026 05:38:25 PM (7 weeks ago)

Author:

Robin <roboburr@…>

Branches:

main

Children:

e9c9ae1

Parents:

feced2c

git-author:

Robin <roboburr@…> (07/19/2026 05:38:00 PM)

git-committer:

Robin <roboburr@…> (07/19/2026 05:38:25 PM)

Message:

Feature: rich editor on the edit forms too (klonkt-demo-c7f, last slice)

Editing a sent reply (Messages + the interact page's manage list) now opens the
same shared editor as new replies, instead of a bare textarea. Prutter stays
plain on purpose (Robin: not part of this).

• reply-editor partial: initialHtml/initialText prefill for edit mode, and a noAttach flag that omits the media UI (an edit never touches attachments). JS grew canAttach guards so the component runs without the attach elements; pasted files are still swallowed there rather than becoming base64 blobs.
• deliverOutboxUpdate(site, id, text, {html, language}): rich path with the same sanitize + enrichment + mention-first-paragraph logic as deliverReply; language updated via COALESCE (bogus codes keep the old one); attachments survive untouched. Plain path unchanged.
• /fediverse/:id/edit passes content + language; listOutbox and the Messages sent-projection carry language so the select preselects correctly.
• The interact page's edit-toggle focuses the rich editor when present.

2 new tests (93 green). Browser-verified on /messages: prefilled editor
(mention-stripped HTML + plain fallback + language preselected, no paperclip),
edit saved -> content replaced with markup, mention re-attached inline,
language nl->en, no console errors.

Co-Authored-By: Claude Opus 4.8 <noreply@…>

File:

• src/assets/js/reply-editor.js (modified) (7 diffs)

src/assets/js/reply-editor.js

@@ -36 +36 @@
     var attField = form.querySelector('input[name="attachments"]');
     var fileInput = form.querySelector('.re-file');
+    var canAttach = !!(attWrap && attField && fileInput);   // edit mode renders without media
     var attachments = [];
 
     function syncAtt() {
+      if (!canAttach) return;
       attField.value = attachments.length ? JSON.stringify(attachments) : '';
       attWrap.hidden = attachments.length === 0;
@@ -62 +64 @@
     }
     function uploadFiles(files) {
+      if (!canAttach) return;
       Array.prototype.forEach.call(files, function (file) {
         if (!/^(image|audio|video)\//.test(file.type) || attachments.length >= 4) return;
@@ -93 +96 @@
       e.preventDefault();
       var cmd = btn.getAttribute('data-cmd');
-      if (cmd === 'attach') { fileInput.click(); return; }   // no editor focus: keeps the picker usable on mobile
+      if (cmd === 'attach') { if (fileInput) fileInput.click(); return; }   // no editor focus: keeps the picker usable on mobile
       ed.focus();
       if (cmd === 'bold') document.execCommand('bold');
@@ -104 +107 @@
       }
     });
-    fileInput.addEventListener('change', function () {
+    if (fileInput) fileInput.addEventListener('change', function () {
       uploadFiles(fileInput.files);
       fileInput.value = '';
@@ -114 +117 @@
       var cd = e.clipboardData || window.clipboardData;
       if (cd.files && cd.files.length) {
-        e.preventDefault();
-        uploadFiles(cd.files);
+        e.preventDefault();            // never let the browser inline-paste a file as base64
+        uploadFiles(cd.files);         // no-op without the attach UI (edit mode)
         return;
       }
@@ -125 +128 @@
 
     // Drag/drop media onto the editor.
+    if (canAttach) {
     ed.addEventListener('dragover', function (e) {
       if (e.dataTransfer && Array.prototype.some.call(e.dataTransfer.types || [], function (t) { return t === 'Files'; })) {
@@ -139 +143 @@
       }
     });
+    }
 
     // Full-screen compose on mobile: enter on focus, leave via ×.