Changeset 33886fb in Klonkt

Timestamp:

06/15/2026 03:56:37 AM (3 months ago)

Author:

roboburr <roboburr@…>

Branches:

main

Children:

6117035

Parents:

1f01b99

Message:

fix: site player now also pauses fallback embeds (mutual exclusion both ways)

The registry already handled mutual exclusion for custom players (API loaded),
but fallback iframes (ad-blocker blocks the API) didn't register themselves:
the site player couldn't stop them -> double audio. A cross-origin iframe
can't be paused via API, so we now register the fallback in the registry with
a pause() that reloads the iframe WITHOUT autoplay (= stops it, remains
restartable). Result: starting an embed pauses the site player, and starting
the site player stops the embed. embed-player.js v=3 -> v=4.

Co-Authored-By: Claude <noreply@…>

Location:

src

Files:

• assets/js/embed-player.js (modified) (1 diff)
• views/shell.ejs (modified) (1 diff)

src/assets/js/embed-player.js

@@ -260 +260 @@
       el.innerHTML = '';
       el.appendChild(iframe);
+
+      // Mutual exclusion óók voor de fallback-iframe. Een cross-origin iframe
+      // kunnen we niet via een API pauzeren, dus 'pauze' = herladen ZONDER
+      // autoplay (= stopt het geluid, speler blijft zichtbaar/herstartbaar).
+      // We registreren 'm als actief: nu (= gebruiker start de embed) pauzeert de
+      // site-speler/andere embeds; en als de site-speler later start, pauzeert de
+      // registry deze fallback.
+      self.pause = function () {
+        try {
+          const noAuto = fb.src
+            .replace(/([?&])(?:autoplay=1|auto_play=true)(&|$)/gi, '$1')
+            .replace(/[?&]$/, '');
+          if (iframe.src === noAuto) {
+            // src ongewijzigd (bv. Spotify zonder autoplay) → forceer een reload
+            iframe.src = 'about:blank';
+            setTimeout(() => { try { iframe.src = noAuto; } catch (e) {} }, 30);
+          } else {
+            iframe.src = noAuto;
+          }
+        } catch (e) {}
+      };
+      registry().setActive(self);
     }
 

src/views/shell.ejs

@@ -314 +314 @@
 <!-- Eigen custom media-embeds (YouTube/SoundCloud/Spotify) via de echte
      player-API's + gedeelde mutual-exclusion registry met de site-speler. -->
-<script src="/assets/js/embed-player.js?v=3" defer></script>
+<script src="/assets/js/embed-player.js?v=4" defer></script>
 <% if (site && site.enable_audio_player && audioTracks && audioTracks.length > 0) { %>
   <script>window.PCMS_SITE_TRACKS = <%- JSON.stringify(audioTracks) %>;</script>