Changeset 30271e6 in Klonkt for src/routes

Timestamp:

06/25/2026 06:13:00 AM (3 months ago)

Author:

Robin Genis <roboburr@…>

Branches:

main

Children:

6c3d805

Parents:

2923a95

Message:

fix(fediverse): player card only for playable (hosted) audio; scope embed strictly

A link-only track (external, media_id NULL) has no hosted audio, so it must not get
a Klonkt player card — and /embed?post= must not fall back to ALL site tracks (that
showed unrelated songs). New hasPlayableAudio() gates the player card + cover-
suppression on a real file-backed track; link-only audio keeps its cover. /embed?post
now scopes strictly to the post's tracks (no all-site fallback).

Co-Authored-By: Claude <noreply@…>

Location:

src/routes

Files:

• embed.js (modified) (1 diff)
• posts.js (modified) (1 diff)

src/routes/embed.js

@@ -45 +45 @@
         for (const m of post.content.matchAll(/\[\[album:([^\]]+)\]\]/g)) for (const r of db.prepare('SELECT id FROM audio_tracks WHERE site_id = ? AND album = ? ORDER BY position').all(site.id, m[1].trim())) add(r.id);
         for (const m of post.content.matchAll(/\[\[playlist:([A-Za-z0-9_-]+)\]\]/g)) for (const r of db.prepare('SELECT track_id FROM playlist_tracks WHERE playlist_id = ? ORDER BY position').all(m[1])) add(r.track_id);
-        if (ids.length) {
-          const byId = new Map(tracks.map((t) => [t.id, t]));
-          const scoped = ids.map((id) => byId.get(id)).filter(Boolean);
-          if (scoped.length) tracks = scoped;
-        }
+        // Strictly scope to this post's tracks — do NOT fall back to all-site
+        // tracks (that showed unrelated songs for a link-only-track post).
+        const byId = new Map(tracks.map((t) => [t.id, t]));
+        tracks = ids.map((id) => byId.get(id)).filter(Boolean);
       }
     } catch { /* fall back to the full site player */ }

src/routes/posts.js

@@ -848 +848 @@
     canManageSite,
     siteAvatar,
+    postHasPlayableAudio: ActivityPubService.hasPlayableAudio(post.content || '', site.id),
     pageTitle: post.title + ' - ' + site.title,
     socialDescr: post.excerpt || '',