Changeset 28b59e7 in Klonkt

Timestamp:

06/30/2026 02:24:00 PM (2 months ago)

Author:

roboburr <roboburr@…>

Branches:

main

Children:

443f982

Parents:

292734a

Message:

fix(federation): don't federate inline images we can't serve (stale /images/... -> black tile in Mastodon)

buildNote turned every inline <img> into an AP image attachment, including a dead relative path
(e.g. a stale /images/<hash>.jpg that 404s). Mastodon then showed it as a black tile in its
attachment grid next to the real cover. Now only federate absolute http(s) URLs or our own
/media/ uploads; other relative paths (which we don't host) are skipped.

• src/services/ActivityPubService.js — guard inline image collection in buildNote

Co-Authored-By: Claude <noreply@…>

File:

• src/services/ActivityPubService.js (modified) (1 diff)

src/services/ActivityPubService.js

@@ -232 +232 @@
   if (post.cover_image_url && !playable) urls.push(abs(post.cover_image_url));
   let body = post.content || '';
-  if (!playable) for (const m of body.matchAll(/<img\b[^>]*\bsrc="([^"]+)"[^>]*>/gi)) urls.push(abs(m[1]));
+  // Only federate inline images we can actually serve: absolute http(s) URLs, or our own
+  // /media/ uploads. A relative path we don't host (e.g. a stale /images/... ref) would 404
+  // and show up as a black tile in Mastodon's attachment grid.
+  if (!playable) for (const m of body.matchAll(/<img\b[^>]*\bsrc="([^"]+)"[^>]*>/gi)) {
+    const src = m[1];
+    if (/^https?:\/\//i.test(src) || src.startsWith('/media/')) urls.push(abs(src));
+  }
   body = body.replace(/<img\b[^>]*>/gi, '');
   // Audio shortcodes: do NOT federate the raw audio file — Klonkt deliberately