Changeset 201ec06 in Klonkt

Timestamp:

06/28/2026 05:15:48 PM (2 months ago)

Author:

Robin Genis <roboburr@…>

Branches:

main

Children:

a64d705

Parents:

99989f9

Message:

fix(images): cap concurrent ffmpeg (thumbnails) to avoid CPU saturation

A cold-cache image-heavy page fired one ffmpeg per thumbnail at once (a thundering herd),
saturating CPU and making the whole instance slow. Cap concurrent ffmpeg spawns to 3; excess
requests wait briefly for a slot. Applies to local + remote thumbnail generation.

• services/ThumbnailService.js — acquireSlot/releaseSlot semaphore + runFfmpeg wrapper

File:

• src/services/ThumbnailService.js (modified) (5 diffs)

src/services/ThumbnailService.js

@@ -27 +27 @@
 
 let _seq = 0;
+
+// Limit concurrent ffmpeg spawns. A cold-cache, image-heavy page fires many thumbnail
+// requests at once; without a cap each spawns its own ffmpeg → CPU saturation makes the
+// WHOLE instance slow (the thundering herd). With the cap, excess requests wait briefly
+// for a slot → bounded CPU, the page still loads (images just appear progressively).
+const MAX_CONCURRENT = 3;
+let _active = 0;
+const _waiters = [];
+function acquireSlot() {
+  if (_active < MAX_CONCURRENT) { _active++; return Promise.resolve(); }
+  return new Promise((resolve) => _waiters.push(resolve));
+}
+function releaseSlot() {
+  const next = _waiters.shift();
+  if (next) next();      // transfer the slot directly to the next waiter (_active unchanged)
+  else _active--;
+}
+async function runFfmpeg(args) {
+  await acquireSlot();
+  try { await execFileP(ffmpegPath, args, { timeout: 20000 }); }
+  finally { releaseSlot(); }
+}
 
 function mediaRoot() {
@@ -57 +79 @@
   const tmp = `${cached}.tmp-${process.pid}-${_seq++}`;
   try {
-    await execFileP(ffmpegPath, [
+    await runFfmpeg([
       '-hide_banner', '-loglevel', 'error', '-y',
       '-i', orig,
@@ -68 +90 @@
       '-f', 'webp',
       tmp,
-    ], { timeout: 20000 });
+    ]);
     await fs.promises.rename(tmp, cached);
     return cached;
@@ -143 +165 @@
   try {
     await fs.promises.writeFile(tmpIn, buf);
-    await execFileP(ffmpegPath, [
+    await runFfmpeg([
       '-hide_banner', '-loglevel', 'error', '-y',
       '-i', tmpIn,
@@ -150 +172 @@
       '-c:v', 'libwebp', '-q:v', '82', '-f', 'webp',
       tmpOut,
-    ], { timeout: 20000 });
+    ]);
     await fs.promises.rename(tmpOut, cached);
     return cached;