Changeset 1ff0043 in Klonkt

Timestamp:

06/28/2026 04:12:48 PM (2 months ago)

Author:

Robin Genis <roboburr@…>

Branches:

main

Children:

f79a471

Parents:

897c33b

Message:

fix(seo): canonical falls back to PUBLIC_BASE_URL + English placeholders

• views/shell.ejs — <link rel=canonical> now uses the per-site override OR the .env base (ogOrigin/PUBLIC_BASE_URL), so the canonical works from .env without filling the SEO field
• views/pages/admin-seo.ejs — placeholders jouw-domein.com -> yourdomain.com (was Dutch in an English app)

Location:

src/views

Files:

• pages/admin-seo.ejs (modified) (3 diffs)
• shell.ejs (modified) (1 diff)

src/views/pages/admin-seo.ejs

@@ -29 +29 @@
       <label>
         <span><%= t('aseo.canonical') %> <small class="form-hint-inline">— <%= t('aseo.canonical_hint') %></small></span>
-        <input type="text" name="canonical" value="<%= site.canonical || '' %>" placeholder="https://jouw-domein.com" maxlength="200">
+        <input type="text" name="canonical" value="<%= site.canonical || '' %>" placeholder="https://yourdomain.com" maxlength="200">
       </label>
       <label>
@@ -41 +41 @@
       <label>
         <span><%= t('aseo.og_image') %> <small class="form-hint-inline">— <%= t('aseo.og_image_hint') %></small></span>
-        <input type="text" name="og_image_default" value="<%= site.og_image_default || '' %>" placeholder="https://jouw-domein.com/share.jpg" maxlength="500">
+        <input type="text" name="og_image_default" value="<%= site.og_image_default || '' %>" placeholder="https://yourdomain.com/share.jpg" maxlength="500">
       </label>
       <label>
@@ -72 +72 @@
       <label>
         <span><%= t('aseo.publisher_url') %></span>
-        <input type="text" name="publisher_url" value="<%= site.publisher_url || '' %>" placeholder="https://jouw-domein.com" maxlength="200">
+        <input type="text" name="publisher_url" value="<%= site.publisher_url || '' %>" placeholder="https://yourdomain.com" maxlength="200">
       </label>
       <label>
         <span><%= t('aseo.publisher_logo') %></span>
-        <input type="text" name="publisher_logo" value="<%= site.publisher_logo || '' %>" placeholder="https://jouw-domein.com/logo.png" maxlength="500">
+        <input type="text" name="publisher_logo" value="<%= site.publisher_logo || '' %>" placeholder="https://yourdomain.com/logo.png" maxlength="500">
       </label>
     </fieldset>

src/views/shell.ejs

@@ -42 +42 @@
 }
 
-// ── Canonical URL (only when we have one configured) ─────────────
+// ── Canonical URL: per-site override (admin SEO), else the .env base
+//    (PUBLIC_BASE_URL, via ogOrigin → falls back to the request host) ──
 let _canonical = null;
-if (safeSite.canonical) {
-  const _base = safeSite.canonical.replace(/\/+$/, '');
+const _canonBase = safeSite.canonical || (typeof ogOrigin !== 'undefined' ? ogOrigin : '');
+if (_canonBase) {
+  const _base = _canonBase.replace(/\/+$/, '');
   let _path = '/';
   if (typeof post !== 'undefined' && post && post.slug) _path = '/' + post.slug;