Changeset 1cc8c85 in Klonkt

Timestamp:

07/16/2026 12:20:51 PM (8 weeks ago)

Author:

Robin <roboburr@…>

Branches:

main

Children:

87d2787

Parents:

476d6e7

git-author:

Robin <roboburr@…> (07/13/2026 05:48:50 AM)

git-committer:

Robin <roboburr@…> (07/16/2026 12:20:51 PM)

Message:

Spoor A step 3b: buildNote is the single Note entry point (buildReplyNote delegates)

Fold buildReplyNote into buildNote via an isReply option, so ALL ActivityPub
Notes are built by one function. For now a reply stays the simple flavor
(pre-baked content, no title/cover/image/audio/embed machinery) behind an early
branch, so output is byte-identical (verified: reply Note deep-equals the old
buildReplyNote for both a mention+hashtag reply and a plain reply; 46 tests
green). buildReplyNote is now a thin delegate, so no caller changes. This is the
foundation for rich replies: when replies gain images/audio/embeds, the branch
collapses and they flow through the full post pipeline instead of duplicating it.

Co-Authored-By: Claude Opus 4.8 <noreply@…>

File:

• src/services/ActivityPubService.js (modified) (2 diffs)

src/services/ActivityPubService.js

@@ -210 +210 @@
 
 // A single post as an AS2 Note (the object), and as a Create activity (for outbox/delivery).
-export function buildNote(base, site, post) {
+export function buildNote(base, site, post, opts = {}) {
+  // Replies are Notes too. buildNote is the single entry point for ALL Notes; a reply is
+  // (for now) the simple flavor: pre-baked content, no title/cover/image/audio/embed
+  // machinery, addressed to the parent actor + thread. This early branch keeps that output
+  // byte-identical to the old buildReplyNote. When rich replies land (images/audio/embeds),
+  // this branch collapses and replies flow through the full post pipeline below. `post` here
+  // is the ap_outbox reply row (id, in_reply_to, content, post_slug, created_at, to_actor).
+  if (opts.isReply) {
+    const meR = actorId(base, site.slug);
+    return {
+      id: noteId(base, post.id),
+      type: 'Note',
+      attributedTo: meR,
+      inReplyTo: post.in_reply_to || undefined,
+      content: post.content,
+      url: post.post_slug ? `${base}/${encodeURIComponent(post.post_slug)}` : undefined,
+      published: toISO(post.created_at),
+      to: post.to_actor ? [post.to_actor] : [PUBLIC],
+      cc: [PUBLIC, `${meR}/followers`],
+      tag: [
+        ...mentionTags(post.content),
+        ...hashtagTags(base, post.content),
+      ],
+    };
+  }
   const id = noteId(base, post.id);
   const aId = actorId(base, site.slug);
@@ -1572 +1596 @@
 
 export function buildReplyNote(base, site, row) {
-  const me = actorId(base, site.slug);
-  return {
-    id: noteId(base, row.id),
-    type: 'Note',
-    attributedTo: me,
-    inReplyTo: row.in_reply_to || undefined,
-    content: row.content,
-    url: row.post_slug ? `${base}/${encodeURIComponent(row.post_slug)}` : undefined,
-    published: toISO(row.created_at),
-    to: row.to_actor ? [row.to_actor] : [PUBLIC],
-    cc: [PUBLIC, `${me}/followers`],
-    tag: [
-      ...mentionTags(row.content),
-      ...hashtagTags(base, row.content),
-    ],
-  };
+  // Thin delegate: replies are built by buildNote (the single Note entry point) in reply mode.
+  return buildNote(base, site, row, { isReply: true });
 }