Changeset 155c24e in Klonkt for test/c2s-direct.test.js

Timestamp:

07/20/2026 10:52:58 PM (7 weeks ago)

Author:

Robin <roboburr@…>

Branches:

main

Children:

7922694

Parents:

e6c6e6f

git-author:

Robin <roboburr@…> (07/20/2026 10:52:57 PM)

git-committer:

Robin <roboburr@…> (07/20/2026 10:52:58 PM)

Message:

Feature: emit shaer:helpRequest on direct notes (FEP-633c 5.2.1)

The wire now claims exactly what the FEP specifies. The shaer
namespace (​https://ns.klonkt.com/shaer#) joins AP_CONTEXT, so the term
is valid JSON-LD; a C2S note carrying shaer:helpRequest true routes
through the direct path with the flag stored (additive column
ap_outbox.help_request) and the built note emits the term, strictly on
direct notes only. Non-observing servers ignore it; a guardian-side
client can render the alert card the spec allows.

Changed files:
src/services/ActivityPubService.js

• shaer namespace in AP_CONTEXT
• ingest reads shaer:helpRequest / helpRequest from the object
• deliverDirectNote stores the flag; buildReplyNote emits the term

src/config/database.js

• additive column ap_outbox.help_request

test/c2s-direct.test.js

• term emitted with flag, absent without, namespace declared

-robo
Co-Authored-By: Claude Opus 4.8 <noreply@…>

File:

• test/c2s-direct.test.js (modified) (1 diff)

test/c2s-direct.test.js

@@ -38 +38 @@
 });
 
+test('a help request emits shaer:helpRequest (FEP-633c 5.2.1)', () => {
+  db.prepare(`INSERT INTO ap_outbox (id, site_slug, post_id, post_slug, in_reply_to, to_actor, to_handle, content, visibility, to_actors, help_request, created_at)
+    VALUES ('d3','me','',NULL,NULL,'https://r.test/u/g','@g@r.test','<p>help</p>','direct','["https://r.test/u/g"]',1,CURRENT_TIMESTAMP)`).run();
+  const row = db.prepare('SELECT * FROM ap_outbox WHERE id = ?').get('d3');
+  const note = AP.buildReplyNote('https://test.example', site, row);
+  assert.equal(note['shaer:helpRequest'], true);
+  assert.deepEqual(note.cc, []);   // still strictly direct
+  // and the namespace is declared, so the term is valid JSON-LD
+  const ctx = AP.AP_CONTEXT.find((p) => p && typeof p === 'object');
+  assert.equal(ctx.shaer, 'https://ns.klonkt.com/shaer#');
+  // a plain direct note (no flag) does NOT carry the term
+  const plainRow = db.prepare('SELECT * FROM ap_outbox WHERE id = ?').get('d1');
+  assert.equal(AP.buildReplyNote('https://test.example', site, plainRow)['shaer:helpRequest'], undefined);
+});
+
 test('direct without any real recipient is refused (400 no_recipients)', async () => {
   const r = await AP.ingestOutboxActivity(site, user, {