Changeset 11b3ba5 in Klonkt

Timestamp:

06/21/2026 03:54:13 PM (3 months ago)

Author:

roboburr <roboburr@…>

Branches:

main

Children:

1664f31

Parents:

5e61b17

Message:

fix(editor): schedule publication behind an on/off toggle (no accidental date)

The "Publish on" date field was always open → an accidentally chosen date silently
set the post to 'scheduled' (not live, no obvious reason). Now a "Schedule
publication" toggle, off by default = publish immediately; the date field appears
and counts only when the toggle is on (input disabled when off). Server honours
publish_at only with schedule_enabled (bulletproof, create + update). NL/EN/DE.

Co-Authored-By: Claude <noreply@…>

Location:

src

Files:

• routes/posts.js (modified) (2 diffs)
• services/i18n.js (modified) (3 diffs)
• views/pages/post-edit.ejs (modified) (1 diff)

src/routes/posts.js

@@ -186 +186 @@
   let publishAt = null;
   const pa = Date.parse(req.body.publish_at || '');
-  if (finalStatus === 'published' && Number.isFinite(pa) && pa > Date.now()) {
+  if (req.body.schedule_enabled && finalStatus === 'published' && Number.isFinite(pa) && pa > Date.now()) {
     finalStatus = 'scheduled';
     publishAt = new Date(pa).toISOString();
@@ -297 +297 @@
   let publishAt = null;
   const pa = Date.parse(req.body.publish_at || '');
-  if (finalStatus === 'published' && Number.isFinite(pa) && pa > Date.now()) {
+  if (req.body.schedule_enabled && finalStatus === 'published' && Number.isFinite(pa) && pa > Date.now()) {
     finalStatus = 'scheduled';
     publishAt = new Date(pa).toISOString();

src/services/i18n.js

@@ -725 +725 @@
     'pedit.noindex_label': 'noindex (verberg voor zoekmachines)',
     'pedit.fan_only_label': 'Alleen voor ingelogde fans',
-    'pedit.publish_at_label': 'Publiceren op (laat leeg = direct)',
+    'pedit.schedule_label': 'Publicatie inplannen',
+    'pedit.schedule_hint': 'Staat dit uit, dan gaat je post meteen live. Aan = kies hieronder wanneer \'ie verschijnt.',
+    'pedit.publish_at_label': 'Datum & tijd',
     'pedit.scheduled_for': 'Ingepland voor {d}',
     'pedit.cancel': 'Annuleren',
@@ -1676 +1678 @@
     'pedit.noindex_label': 'noindex (hide from search engines)',
     'pedit.fan_only_label': 'Logged-in fans only',
-    'pedit.publish_at_label': 'Publish at (leave empty = immediately)',
+    'pedit.schedule_label': 'Schedule publication',
+    'pedit.schedule_hint': 'When off, your post goes live immediately. On = pick below when it appears.',
+    'pedit.publish_at_label': 'Date & time',
     'pedit.scheduled_for': 'Scheduled for {d}',
     'pedit.cancel': 'Cancel',
@@ -2627 +2631 @@
     'pedit.noindex_label': 'noindex (vor Suchmaschinen verbergen)',
     'pedit.fan_only_label': 'Nur für angemeldete Fans',
-    'pedit.publish_at_label': 'Veröffentlichen am (leer lassen = sofort)',
+    'pedit.schedule_label': 'Veröffentlichung planen',
+    'pedit.schedule_hint': 'Wenn aus, geht dein Beitrag sofort live. An = wähle unten, wann er erscheint.',
+    'pedit.publish_at_label': 'Datum & Uhrzeit',
     'pedit.scheduled_for': 'Geplant für {d}',
     'pedit.cancel': 'Abbrechen',

src/views/pages/post-edit.ejs

@@ -208 +208 @@
             <span>🔒 <%= t('pedit.fan_only_label') %></span>
           </label>
-          <div style="margin-top:8px">
-            <label style="display:block;font-size:12.5px;opacity:.8;margin-bottom:4px">📅 <%= t('pedit.publish_at_label') %></label>
-            <input type="datetime-local" name="publish_at" value="<%= post.publish_at ? String(post.publish_at).replace(' ','T').slice(0,16) : '' %>" style="padding:8px 10px;border-radius:8px;border:1px solid var(--rule,rgba(128,128,128,.4));background:transparent;color:inherit">
+          <% var _scheduled = !!(post.publish_at && (post.status === 'scheduled' || Date.parse(String(post.publish_at).replace(' ', 'T')) > Date.now())); %>
+          <label class="pe-checkbox" style="margin-top:8px">
+            <input type="checkbox" name="schedule_enabled" value="1" id="pe-sched-toggle" <%= _scheduled ? 'checked' : '' %>>
+            <span>📅 <%= t('pedit.schedule_label') %></span>
+          </label>
+          <div id="pe-sched-fields" style="margin-top:6px;<%= _scheduled ? '' : 'display:none' %>">
+            <label style="display:block;font-size:12.5px;opacity:.8;margin-bottom:4px"><%= t('pedit.publish_at_label') %></label>
+            <input type="datetime-local" name="publish_at" <%= _scheduled ? '' : 'disabled' %> value="<%= post.publish_at ? String(post.publish_at).replace(' ','T').slice(0,16) : '' %>" style="padding:8px 10px;border-radius:8px;border:1px solid var(--rule,rgba(128,128,128,.4));background:transparent;color:inherit">
             <% if (post.status === 'scheduled' && post.publish_at) { %><div style="font-size:12px;opacity:.7;margin-top:4px">⏳ <%= t('pedit.scheduled_for', { d: post.publish_at }) %></div><% } %>
+            <div style="font-size:11.5px;opacity:.65;margin-top:4px"><%= t('pedit.schedule_hint') %></div>
           </div>
+          <script>
+            (function () {
+              var cb = document.getElementById('pe-sched-toggle');
+              var box = document.getElementById('pe-sched-fields');
+              if (!cb || !box) return;
+              var inp = box.querySelector('input[name="publish_at"]');
+              function sync() { box.style.display = cb.checked ? '' : 'none'; if (inp) inp.disabled = !cb.checked; }
+              cb.addEventListener('change', sync); sync();
+            })();
+          </script>
         <% } %>
       </div>