Changeset 0a7ba90 in Klonkt

Timestamp:

06/27/2026 12:42:07 PM (2 months ago)

Author:

Robin Genis <roboburr@…>

Branches:

main

Children:

a78e051

Parents:

204bd74

Message:

fix(theme): a site renders in its own palette, not the logged-in viewer's

• middleware/site.js — loadTheme prioritised the session user's palette over the site's, so a full page load (owner logged in) used the viewer's stale user.palette while htmx-nav used the site palette → the palette appeared to change on hard refresh. There is no per-user palette UI (user.palette is vestigial migration data); the site palette now always wins, matching the htmx pcmsNav path. Theme (dark/light) stays a per-user preference.

File:

• src/middleware/site.js (modified) (1 diff)

src/middleware/site.js

@@ -110 +110 @@
   const site = res.locals.site;
   
-  // Priority: user setting > site setting > default
-  const palette = (user && PALETTES.includes(user.palette) ? user.palette : null)
-                || (site && PALETTES.includes(site.palette) ? site.palette : null)
+  // A site always renders in ITS OWN palette, regardless of who is viewing. There is
+  // no per-user palette UI (user.palette is vestigial/stale data from old migrations),
+  // and the htmx pcmsNav path (render.js) already uses the site palette only — so reading
+  // user.palette here made a full page load (owner logged in) flip to the viewer's stale
+  // palette while htmx-nav kept the site's, i.e. "palette changes on hard refresh".
+  const palette = (site && PALETTES.includes(site.palette) ? site.palette : null)
                 || 'klonkt';
-  
+
   res.locals.palette = palette;
   res.locals.theme = (user && ['dark','light'].includes(user.theme)) ? user.theme : 'dark';