Changeset 041a0df in Klonkt

Timestamp:

06/28/2026 05:38:13 PM (2 months ago)

Author:

Robin Genis <roboburr@…>

Branches:

main

Children:

492fc20

Parents:

3038fc9

Message:

fix(images): downscale remote (federated) covers + feed media via the proxy

thumb() only rewrote LOCAL /media covers; a remote (federated) cover URL passed through
unchanged → loaded full-res from the origin → browser-downscaled jagged (esp. line-art).
Route remote http(s) covers + timeline feed media through the same signed downscale proxy.

• middleware/render.js — thumb() proxies remote http(s) URLs (like avatar())
• views/pages/news.ejs — feed media <img> uses thumb(m.url, 640) (link stays the original)

Location:

src

Files:

• middleware/render.js (modified) (1 diff)
• views/pages/news.ejs (modified) (1 diff)

src/middleware/render.js

@@ -163 +163 @@
     // Rewrite a local /media/<file> cover to its on-demand downscaled thumbnail
     // (crisp grid/list images). External URLs + already-thumb URLs pass through.
-    thumb: (url, w) => (typeof url === 'string' && url.startsWith('/media/') && !url.startsWith('/media/thumb/'))
-      ? `/media/thumb/${w || 480}/${url.slice(7)}`
-      : url,
+    thumb: (url, w) => {
+      if (!url || typeof url !== 'string') return url;
+      // Local cover → local thumb route; remote (federated) cover → signed downscale
+      // proxy (same as avatars), so remote line-art covers aren't browser-downscaled jagged.
+      if (url.startsWith('/media/') && !url.startsWith('/media/thumb/')) return `/media/thumb/${w || 480}/${url.slice(7)}`;
+      if (/^https?:\/\//i.test(url)) return imgProxyUrl(url, w || 480);
+      return url;
+    },
     // Crisp avatars: a local /media avatar goes through the local thumb route; a REMOTE
     // (fediverse) avatar through the signed downscaling proxy. Same downscale, the remote

src/views/pages/news.ejs

@@ -118 +118 @@
             <div class="tl-media">
               <% imgs.forEach(function(m){ %>
-                <a class="tl-media-img" href="<%= m.url %>" target="_blank" rel="noopener"><img src="<%= m.url %>" alt="" loading="lazy" decoding="async"></a>
+                <a class="tl-media-img" href="<%= m.url %>" target="_blank" rel="noopener"><img src="<%= thumb(m.url, 640) %>" alt="" loading="lazy" decoding="async"></a>
               <% }); %>
             </div>