Changeset 006a3be in Klonkt

Timestamp:

07/04/2026 05:05:30 PM (2 months ago)

Author:

roboburr <roboburr@…>

Branches:

main

Children:

b7e382f

Parents:

8b5c076

Message:

fix(ap): boosted post keeps its cover when you don't follow the author

Boosting a post from someone you DON'T follow resolves the note via
resolveRemoteNote() (authorize_interaction/boost -> upsertBoostedNote),
which extracted images only from attachment. A Klonkt hosted-audio
post deliberately strips its cover from attachment (so Mastodon shows
the player card) and carries it in image instead — so the cover was
lost. Posts from FOLLOWED accounts go through mediaFromNote(), which
already falls back to image; resolveRemoteNote() now does the same.

Verified in isolation: cover extracted from image (object/string/array),
attachment still wins when present, no duplication, non-http rejected
(SSRF-safe). Full suite 45/45.

• src/services/ActivityPubService.js — image fallback in resolveRemoteNote
• CHANGELOG(.nl/.de).md — user-facing entry under Unreleased (3 languages)

Co-Authored-By: Claude <noreply@…>

Files:

• CHANGELOG.de.md (modified) (1 diff)
• CHANGELOG.md (modified) (1 diff)
• CHANGELOG.nl.md (modified) (1 diff)
• src/services/ActivityPubService.js (modified) (1 diff)

CHANGELOG.de.md

@@ -5 +5 @@
 
 ## [Unreleased]
+
+### Behoben
+- **Geteilte Musikbeiträge behalten ihr Cover.** Wenn du einen Titel von jemandem
+  geteilt (geboostet) hast, dem du nicht folgst, fehlte das Cover; es wird jetzt
+  angezeigt, genau wie bei Personen, denen du folgst.
 
 ## [1.3.2] — 2026-07-02

CHANGELOG.md

@@ -5 +5 @@
 
 ## [Unreleased]
+
+### Fixed
+- **Boosted music posts keep their cover.** When you boosted a track from
+  someone you don't follow, the cover art went missing; it now shows, just like
+  for people you do follow.
 
 ## [1.3.2] — 2026-07-02

CHANGELOG.nl.md

@@ -5 +5 @@
 
 ## [Unreleased]
+
+### Opgelost
+- **Geboooste muziekposts houden hun cover.** Als je een nummer boostte van
+  iemand die je niet volgt, ontbrak de cover; die verschijnt nu wel, net als bij
+  mensen die je wél volgt.
 
 ## [1.3.2] — 2026-07-02

src/services/ActivityPubService.js

@@ -1637 +1637 @@
     .filter((a) => a && a.url && (!a.mediaType || /^image\//i.test(a.mediaType)))
     .map((a) => safeUrl(a.url)).filter(Boolean);
+  // A Klonkt hosted-audio post strips its cover from `attachment` (so Mastodon
+  // shows the player card, not a loose image) and puts it in `image` instead.
+  // Same fallback as mediaFromNote() so a boosted music post keeps its cover.
+  if (!images.length && note.image) {
+    const im = Array.isArray(note.image) ? note.image[0] : note.image;
+    const iu = safeUrl(typeof im === 'string' ? im : (im && im.url));
+    if (iu) images.push(iu);
+  }
   return {
     object_uri: safeUrl(note.id) || note.id,