source: Klonkt/test/paid-patron.test.js@ ec288dc

main
Last change on this file since ec288dc was c7a211d, checked in by Robin <roboburr@…>, 7 weeks ago

Fix: real supporters were rejected on a wrong campaign_id + add diagnostics

Robin is an active supporter but /paid/callback said "Nog geen supporter",
so he never reached the passkey step (that page only shows after a verified
patron). Root cause: pickCampaignMembership matched STRICTLY on the owner's
configured campaign_id, and a wrong/typo'd id in the admin locked out real
patrons.

Memberships returned via a creator's OWN OAuth client are already scoped to
that creator's campaign(s), so:

  • prefer an exact campaign_id match (unchanged for the common case),
  • but fall back to the sole membership when the configured id doesn't match,
  • refuse only when it's genuinely ambiguous (multiple memberships, none matching) so we never silently grant the wrong one.

Also log a one-line diagnostic in verifyPatron when a patron is NOT accepted:
the campaign_id configured vs the memberships Patreon actually returned
(campaign:status:cents). Stores nothing; it's a server log so the owner can
see whether their campaign_id is wrong or the pledge isn't active.

Changed files:
src/services/PaidPatreonService.js

  • pickCampaignMembership: exact match, else sole-membership fallback, else null; verifyPatron logs why a patron was rejected

test/paid-patron.test.js

  • exact match, sole-membership fallback, ambiguous→null, empty→null

-robo
Co-Authored-By: Claude Opus 4.8 <noreply@…>

  • Property mode set to 100644
File size: 6.1 KB
RevLine 
[9e9e6f9]1// Paid posts slice 3 (klonkt-demo-aki): patron verification + pseudonymous
2// passkey entitlements. The WebAuthn ceremony itself needs a browser, so here
3// we cover the pure parsing, the Patreon exchange (mock fetch), the entitlement
4// store, and that registration options carry a challenge.
5import { test } from 'node:test';
6import assert from 'node:assert/strict';
7
8process.env.DATABASE_PATH = ':memory:';
9process.env.PUBLIC_BASE_URL = 'https://test.example';
10process.env.PAID_SECRET = 'a-test-paid-secret-of-sufficient-length';
11
12const dbMod = await import('../src/config/database.js');
13const db = dbMod.default;
14dbMod.initializeDatabase();
15const PP = (await import('../src/services/PaidPatreonService.js')).default;
16const Passkey = (await import('../src/services/PasskeyService.js')).default;
17
18PP.saveOwnerConfig('s1', { clientId: 'cid', clientSecret: 'sec', campaignId: '42', defaultMinCents: 300 });
19
20const identityWith = (campaignId, status, cents) => ({
21 data: { type: 'user', id: 'u', relationships: { memberships: { data: [{ type: 'member', id: 'm1' }] } } },
22 included: [
23 { type: 'member', id: 'm1', attributes: { patron_status: status, currently_entitled_amount_cents: cents },
24 relationships: { campaign: { data: { type: 'campaign', id: campaignId } } } },
25 { type: 'campaign', id: campaignId },
26 ],
27});
28
[c7a211d]29test('pickCampaignMembership: exact campaign match wins', async () => {
[9e9e6f9]30 const { pickCampaignMembership } = await import('../src/services/PaidPatreonService.js');
31 const id = identityWith('42', 'active_patron', 500);
32 const m = pickCampaignMembership(id, '42');
33 assert.equal(m.status, 'active_patron');
34 assert.equal(m.cents, 500);
[c7a211d]35});
36
37test('pickCampaignMembership: sole membership is used even if campaign_id is wrong (creator-scoped)', async () => {
38 const { pickCampaignMembership } = await import('../src/services/PaidPatreonService.js');
39 const id = identityWith('42', 'active_patron', 500);
40 // A typo'd campaign_id must not lock out a real patron: memberships from the
41 // owner's own client are already their campaign, so fall back to the sole one.
42 const m = pickCampaignMembership(id, '999');
43 assert.equal(m.status, 'active_patron');
44 assert.equal(m.cents, 500);
45});
46
47test('pickCampaignMembership: multiple memberships + no match → null (no silent grant)', async () => {
48 const { pickCampaignMembership } = await import('../src/services/PaidPatreonService.js');
49 const id = {
50 data: { type: 'user', id: 'u', relationships: { memberships: { data: [{ type: 'member', id: 'm1' }, { type: 'member', id: 'm2' }] } } },
51 included: [
52 { type: 'member', id: 'm1', attributes: { patron_status: 'active_patron', currently_entitled_amount_cents: 300 }, relationships: { campaign: { data: { type: 'campaign', id: '42' } } } },
53 { type: 'member', id: 'm2', attributes: { patron_status: 'active_patron', currently_entitled_amount_cents: 800 }, relationships: { campaign: { data: { type: 'campaign', id: '77' } } } },
54 ],
55 };
56 assert.equal(pickCampaignMembership(id, '999'), null); // ambiguous, refuse
57 assert.equal(pickCampaignMembership(id, '77').cents, 800); // exact still works
58});
59
60test('pickCampaignMembership: no memberships → null', async () => {
61 const { pickCampaignMembership } = await import('../src/services/PaidPatreonService.js');
62 assert.equal(pickCampaignMembership({ data: {}, included: [] }, '42'), null);
[9e9e6f9]63});
64
65test('verifyPatron exchanges the code and reads the membership (mock fetch)', async () => {
66 const calls = [];
67 const fetchMock = async (url, opts) => {
68 calls.push(url);
69 if (url.includes('/token')) return { ok: true, json: async () => ({ access_token: 'patron-tok' }) };
70 return { ok: true, json: async () => identityWith('42', 'active_patron', 800) };
71 };
72 const m = await PP.verifyPatron('s1', 'the-code', 'https://test.example/paid/callback', fetchMock);
73 assert.equal(m.status, 'active_patron');
74 assert.equal(m.cents, 800);
75 assert.ok(calls[0].includes('patreon.com'));
76 assert.ok(calls[1].includes('identity'));
77});
78
79test('registration options carry a challenge and the site host as rpID', async () => {
80 const opts = await Passkey.registrationOptions('https://test.example', 's1');
81 assert.ok(opts.challenge && typeof opts.challenge === 'string');
82 assert.equal(opts.rp.id, 'test.example');
83 assert.equal(opts.authenticatorSelection.residentKey, 'required');
84});
85
86test('entitlement stores, reads, expires, prunes; no patron identity present', () => {
87 Passkey.storeEntitlement({ credentialId: 'cred1', siteId: 's1', publicKey: 'PUBKEY', counter: 0, minCents: 500, ttlDays: 30 });
88 const e = Passkey.getEntitlement('cred1', 's1');
89 assert.ok(e);
90 assert.equal(e.min_cents, 500);
91 // the row has no name/email/patreon id
92 const cols = Object.keys(e);
93 assert.ok(!cols.some((c) => /name|email|patron|user/i.test(c)), 'no identity columns');
94 // expired entitlement is not returned and gets pruned
95 Passkey.storeEntitlement({ credentialId: 'cred2', siteId: 's1', publicKey: 'PK', minCents: 100, ttlDays: 30 });
96 db.prepare('UPDATE paid_entitlements SET expires_at = 1 WHERE credential_id = ?').run('cred2');
97 assert.equal(Passkey.getEntitlement('cred2', 's1'), null);
98 assert.equal(Passkey.pruneExpired() >= 1, true);
99 assert.ok(Passkey.getEntitlement('cred1', 's1')); // the fresh one survives
100});
101
[c3d12a6]102test('patreonUrl: set, kept on unrelated save, cleared on empty', () => {
103 PP.saveOwnerConfig('s2', { clientId: 'c', clientSecret: 's', campaignId: '7', patreonUrl: 'https://patreon.com/x' });
104 assert.equal(PP.patreonUrl('s2'), 'https://patreon.com/x');
105 // a save that does NOT mention patreonUrl (e.g. token refresh) keeps it
106 PP.saveOwnerConfig('s2', { defaultMinCents: 200 });
107 assert.equal(PP.patreonUrl('s2'), 'https://patreon.com/x');
108 // an explicit empty value clears it
109 PP.saveOwnerConfig('s2', { patreonUrl: '' });
110 assert.equal(PP.patreonUrl('s2'), null);
111});
112
[9e9e6f9]113test('deleteEntitlement removes the row (forget-passkey path)', () => {
114 Passkey.storeEntitlement({ credentialId: 'cred3', siteId: 's1', publicKey: 'PK', minCents: 100 });
115 assert.equal(Passkey.deleteEntitlement('cred3'), true);
116 assert.equal(Passkey.getEntitlement('cred3', 's1'), null);
117});
Note: See TracBrowser for help on using the repository browser.