| 1 | // Unit-tests voor de hub-permissielaag — juist `canAdminSite` was lang stil kapot
|
|---|
| 2 | // (las een nooit-gevulde user.siteRoles), dus dit dekt 'm nu af. Draait op de
|
|---|
| 3 | // ingebouwde node:test (geen extra deps). In-memory SQLite → raakt geen echte data.
|
|---|
| 4 | //
|
|---|
| 5 | // Run: npm test (= node --test)
|
|---|
| 6 |
|
|---|
| 7 | import { test } from 'node:test';
|
|---|
| 8 | import assert from 'node:assert/strict';
|
|---|
| 9 |
|
|---|
| 10 | // Isoleer van de echte DB: ':memory:' MOET gezet zijn vóór de eerste import van
|
|---|
| 11 | // config/database.js (die maakt de singleton-connectie op basis van deze env).
|
|---|
| 12 | process.env.DATABASE_PATH = ':memory:';
|
|---|
| 13 |
|
|---|
| 14 | const dbMod = await import('../src/config/database.js');
|
|---|
| 15 | const db = dbMod.default;
|
|---|
| 16 | const PermissionsService = (await import('../src/services/PermissionsService.js')).default;
|
|---|
| 17 | const { getPrimarySite } = await import('../src/middleware/site.js');
|
|---|
| 18 |
|
|---|
| 19 | dbMod.initializeDatabase();
|
|---|
| 20 |
|
|---|
| 21 | // ── Seed ────────────────────────────────────────────────────────────────
|
|---|
| 22 | function addUser(id, role) {
|
|---|
| 23 | db.prepare('INSERT INTO users (id, username, email, password_hash, role) VALUES (?,?,?,?,?)')
|
|---|
| 24 | .run(id, id, id + '@test', 'x', role);
|
|---|
| 25 | }
|
|---|
| 26 | function addSite(id, slug, ownerId, isPrimary = 0) {
|
|---|
| 27 | db.prepare('INSERT INTO sites (id, slug, title, owner_id, is_primary) VALUES (?,?,?,?,?)')
|
|---|
| 28 | .run(id, slug, slug, ownerId, isPrimary);
|
|---|
| 29 | }
|
|---|
| 30 | addUser('u-god', 'god');
|
|---|
| 31 | addUser('u-owner', 'member');
|
|---|
| 32 | addUser('u-collab', 'member');
|
|---|
| 33 | addUser('u-stranger', 'member');
|
|---|
| 34 | addSite('s1', 'site-een', 'u-owner', 1);
|
|---|
| 35 |
|
|---|
| 36 | const god = { id: 'u-god', role: 'god' };
|
|---|
| 37 | const owner = { id: 'u-owner', role: 'member' };
|
|---|
| 38 | const collab = { id: 'u-collab', role: 'member' };
|
|---|
| 39 | const stranger = { id: 'u-stranger', role: 'member' };
|
|---|
| 40 | const site = () => db.prepare('SELECT * FROM sites WHERE id = ?').get('s1');
|
|---|
| 41 |
|
|---|
| 42 | // ── canAdminSite ─────────────────────────────────────────────────────────
|
|---|
| 43 | test('canAdminSite: god mag altijd', () => {
|
|---|
| 44 | assert.equal(PermissionsService.canAdminSite(god, site()), true);
|
|---|
| 45 | });
|
|---|
| 46 | test('canAdminSite: owner mag', () => {
|
|---|
| 47 | assert.equal(PermissionsService.canAdminSite(owner, site()), true);
|
|---|
| 48 | });
|
|---|
| 49 | test('canAdminSite: vreemde zonder membership mag niet', () => {
|
|---|
| 50 | assert.equal(PermissionsService.canAdminSite(stranger, site()), false);
|
|---|
| 51 | });
|
|---|
| 52 | test('canAdminSite: collaborator zonder membership mag niet', () => {
|
|---|
| 53 | assert.equal(PermissionsService.canAdminSite(collab, site()), false);
|
|---|
| 54 | });
|
|---|
| 55 | test('canAdminSite: collaborator MET site_members-admin mag (de gefixte dode code)', () => {
|
|---|
| 56 | db.prepare("INSERT OR REPLACE INTO site_members (site_id, user_id, role) VALUES ('s1','u-collab','admin')").run();
|
|---|
| 57 | assert.equal(PermissionsService.canAdminSite(collab, site()), true);
|
|---|
| 58 | });
|
|---|
| 59 | test('canAdminSite: site_members met rol "member" (geen admin) mag niet', () => {
|
|---|
| 60 | db.prepare("INSERT OR REPLACE INTO site_members (site_id, user_id, role) VALUES ('s1','u-stranger','member')").run();
|
|---|
| 61 | assert.equal(PermissionsService.canAdminSite(stranger, site()), false);
|
|---|
| 62 | });
|
|---|
| 63 | test('canAdminSite: null user of null site → false (geen crash)', () => {
|
|---|
| 64 | assert.equal(PermissionsService.canAdminSite(null, site()), false);
|
|---|
| 65 | assert.equal(PermissionsService.canAdminSite(owner, null), false);
|
|---|
| 66 | });
|
|---|
| 67 |
|
|---|
| 68 | // ── Delegatie: canEditPost via canAdminSite ──────────────────────────────
|
|---|
| 69 | test('canEditPost: collaborator-admin kan een post van een ander bewerken (via canAdminSite)', () => {
|
|---|
| 70 | const post = { author_id: 'iemand-anders' };
|
|---|
| 71 | assert.equal(PermissionsService.canEditPost(collab, post, site()), true);
|
|---|
| 72 | });
|
|---|
| 73 | test('canEditPost: vreemde kan een post van een ander NIET bewerken', () => {
|
|---|
| 74 | const post = { author_id: 'iemand-anders' };
|
|---|
| 75 | assert.equal(PermissionsService.canEditPost(stranger, post, site()), false);
|
|---|
| 76 | });
|
|---|
| 77 |
|
|---|
| 78 | // ── getPrimarySite (#3) ──────────────────────────────────────────────────
|
|---|
| 79 | test('getPrimarySite: geeft de is_primary-site', () => {
|
|---|
| 80 | assert.equal(getPrimarySite().id, 's1');
|
|---|
| 81 | });
|
|---|
| 82 | test('getPrimarySite: valt terug op de oudste als geen is_primary gemarkeerd is', () => {
|
|---|
| 83 | db.prepare('UPDATE sites SET is_primary = 0').run();
|
|---|
| 84 | assert.equal(getPrimarySite().id, 's1'); // s1 is de oudste/enige
|
|---|
| 85 | db.prepare("UPDATE sites SET is_primary = 1 WHERE id = 's1'").run(); // herstel
|
|---|
| 86 | });
|
|---|