source: Klonkt/test/c2s-direct.test.js

main
Last change on this file was 155c24e, checked in by Robin <roboburr@…>, 7 weeks ago

Feature: emit shaer:helpRequest on direct notes (FEP-633c 5.2.1)

The wire now claims exactly what the FEP specifies. The shaer
namespace (https://ns.klonkt.com/shaer#) joins AP_CONTEXT, so the term
is valid JSON-LD; a C2S note carrying shaer:helpRequest true routes
through the direct path with the flag stored (additive column
ap_outbox.help_request) and the built note emits the term, strictly on
direct notes only. Non-observing servers ignore it; a guardian-side
client can render the alert card the spec allows.

Changed files:
src/services/ActivityPubService.js

  • shaer namespace in AP_CONTEXT
  • ingest reads shaer:helpRequest / helpRequest from the object
  • deliverDirectNote stores the flag; buildReplyNote emits the term

src/config/database.js

  • additive column ap_outbox.help_request

test/c2s-direct.test.js

  • term emitted with flag, absent without, namespace declared

-robo
Co-Authored-By: Claude Opus 4.8 <noreply@…>

  • Property mode set to 100644
File size: 5.0 KB
Line 
1// Direct notes (private mentions, shaer-tqc): never Public, never boostable.
2import { test } from 'node:test';
3import assert from 'node:assert/strict';
4
5process.env.DATABASE_PATH = ':memory:';
6process.env.PUBLIC_BASE_URL = 'https://test.example';
7
8const dbMod = await import('../src/config/database.js');
9const db = dbMod.default;
10dbMod.initializeDatabase();
11const AP = (await import('../src/services/ActivityPubService.js')).default;
12
13const PUB = 'https://www.w3.org/ns/activitystreams#Public';
14db.prepare('INSERT INTO users (id, username, email, password_hash, role) VALUES (?,?,?,?,?)').run('u1', 'u1', 'u1@test', 'x', 'god');
15db.prepare('INSERT INTO sites (id, slug, title, owner_id, is_primary) VALUES (?,?,?,?,?)').run('s1', 'me', 'Me', 'u1', 1);
16const site = db.prepare('SELECT * FROM sites WHERE id = ?').get('s1');
17const user = { id: 'u1', username: 'u1' };
18
19test('a direct outbox row addresses only its recipients, no Public, no cc', () => {
20 db.prepare(`INSERT INTO ap_outbox (id, site_slug, post_id, post_slug, in_reply_to, to_actor, to_handle, content, visibility, to_actors, created_at)
21 VALUES ('d1','me','',NULL,NULL,'https://r.test/u/g','@g@r.test','<p>help</p>','direct','["https://r.test/u/g","https://q.test/u/h"]',CURRENT_TIMESTAMP)`).run();
22 const row = db.prepare('SELECT * FROM ap_outbox WHERE id = ?').get('d1');
23 const note = AP.buildReplyNote('https://test.example', site, row);
24 assert.deepEqual(note.to, ['https://r.test/u/g', 'https://q.test/u/h']);
25 assert.deepEqual(note.cc, []);
26 assert.ok(!JSON.stringify(note.to).includes(PUB) && !JSON.stringify(note.cc).includes(PUB));
27});
28
29test('a direct note carries its attachments (help-buoy capture)', () => {
30 db.prepare(`INSERT INTO ap_outbox (id, site_slug, post_id, post_slug, in_reply_to, to_actor, to_handle, content, visibility, to_actors, attachments, created_at)
31 VALUES ('d2','me','',NULL,NULL,'https://r.test/u/g','@g@r.test','<p>kijk</p>','direct','["https://r.test/u/g"]','[{"url":"/media/reply-media/x.png","mediaType":"image/png","name":"capture"}]',CURRENT_TIMESTAMP)`).run();
32 const row = db.prepare('SELECT * FROM ap_outbox WHERE id = ?').get('d2');
33 const note = AP.buildReplyNote('https://test.example', site, row);
34 assert.equal(note.attachment.length, 1);
35 assert.equal(note.attachment[0].type, 'Image');
36 assert.ok(note.attachment[0].url.endsWith('/media/reply-media/x.png'));
37 assert.deepEqual(note.cc, []); // still direct
38});
39
40test('a help request emits shaer:helpRequest (FEP-633c 5.2.1)', () => {
41 db.prepare(`INSERT INTO ap_outbox (id, site_slug, post_id, post_slug, in_reply_to, to_actor, to_handle, content, visibility, to_actors, help_request, created_at)
42 VALUES ('d3','me','',NULL,NULL,'https://r.test/u/g','@g@r.test','<p>help</p>','direct','["https://r.test/u/g"]',1,CURRENT_TIMESTAMP)`).run();
43 const row = db.prepare('SELECT * FROM ap_outbox WHERE id = ?').get('d3');
44 const note = AP.buildReplyNote('https://test.example', site, row);
45 assert.equal(note['shaer:helpRequest'], true);
46 assert.deepEqual(note.cc, []); // still strictly direct
47 // and the namespace is declared, so the term is valid JSON-LD
48 const ctx = AP.AP_CONTEXT.find((p) => p && typeof p === 'object');
49 assert.equal(ctx.shaer, 'https://ns.klonkt.com/shaer#');
50 // a plain direct note (no flag) does NOT carry the term
51 const plainRow = db.prepare('SELECT * FROM ap_outbox WHERE id = ?').get('d1');
52 assert.equal(AP.buildReplyNote('https://test.example', site, plainRow)['shaer:helpRequest'], undefined);
53});
54
55test('direct without any real recipient is refused (400 no_recipients)', async () => {
56 const r = await AP.ingestOutboxActivity(site, user, {
57 type: 'Note', content: '<p>x</p>',
58 to: ['https://test.example/ap/users/me/followers'], cc: [], // friends-shaped? no: followers in to = friends
59 });
60 // followers-only reads as friends, so force the direct shape: bare unknown string
61 const r2 = await AP.ingestOutboxActivity(site, user, { type: 'Note', content: '<p>x</p>', to: [], cc: [] });
62 // empty addressing = legacy public; the real no-recipient direct case:
63 const r3 = await AP.ingestOutboxActivity(site, user, { type: 'Note', content: '<p>x</p>', to: ['not-a-uri'], cc: [] });
64 assert.equal(r3.status, 400);
65 assert.equal(r3.error, 'no_recipients');
66 assert.ok(r && r2); // shapes above answered too (not the point of this test)
67});
68
69test('C2S Announce/Like of a non-public local post is refused (403)', async () => {
70 db.prepare(`INSERT INTO posts (id, site_id, slug, author_id, title, content, status, type, fan_only, ap_visibility, created_at, updated_at, published_at)
71 VALUES ('pf','s1','geheim','u1','','<p>prive</p>','published','post',1,'friends',datetime('now'),datetime('now'),datetime('now'))`).run();
72 const noteUrl = 'https://test.example/ap/notes/pf';
73 const boost = await AP.ingestOutboxActivity(site, user, { type: 'Announce', object: noteUrl });
74 assert.equal(boost.status, 403);
75 assert.equal(boost.error, 'not_public');
76 const like = await AP.ingestOutboxActivity(site, user, { type: 'Like', object: noteUrl });
77 assert.equal(like.status, 403);
78});
Note: See TracBrowser for help on using the repository browser.