| 1 | // Vindbaarheid van playlist-collecties (shaer-ayc, stap 2).
|
|---|
| 2 | //
|
|---|
| 3 | // Drie wegen ernaartoe, elk getest: de actor wijst via AS2 `streams` naar de
|
|---|
| 4 | // lijst; de lijst geeft kaal URI's en verrijkt stubs (FEP-9876), waarbij ook
|
|---|
| 5 | // een stub alleen het open deel telt; en een post die een playlist insluit
|
|---|
| 6 | // draagt een Link-tag naar de collectie -- maar nooit naar die van een andere
|
|---|
| 7 | // site, want playlist-ids zijn een globale primary key.
|
|---|
| 8 | import { test } from 'node:test';
|
|---|
| 9 | import assert from 'node:assert/strict';
|
|---|
| 10 |
|
|---|
| 11 | process.env.DATABASE_PATH = ':memory:';
|
|---|
| 12 | process.env.PUBLIC_BASE_URL = 'https://test.example';
|
|---|
| 13 |
|
|---|
| 14 | const dbMod = await import('../src/config/database.js');
|
|---|
| 15 | const db = dbMod.default;
|
|---|
| 16 | dbMod.initializeDatabase();
|
|---|
| 17 | const AP = (await import('../src/services/ActivityPubService.js')).default;
|
|---|
| 18 | const express = (await import('express')).default;
|
|---|
| 19 | const routes = (await import('../src/routes/activitypub.js')).default;
|
|---|
| 20 |
|
|---|
| 21 | db.prepare('INSERT INTO users (id, username, email, password_hash, role) VALUES (?,?,?,?,?)')
|
|---|
| 22 | .run('u1', 'u1', 'u1@t', 'x', 'god');
|
|---|
| 23 | db.prepare('INSERT INTO sites (id, slug, title, owner_id, is_public) VALUES (?,?,?,?,1)')
|
|---|
| 24 | .run('s1', 'band', 'De Band', 'u1');
|
|---|
| 25 | db.prepare('INSERT INTO sites (id, slug, title, owner_id, is_public) VALUES (?,?,?,?,1)')
|
|---|
| 26 | .run('s2', 'ander', 'Andere Site', 'u1');
|
|---|
| 27 |
|
|---|
| 28 | const insMedia = db.prepare('INSERT INTO media (id, site_id, filename, storage_path, mime_type, size) VALUES (?,?,?,?,?,1000)');
|
|---|
| 29 | const insTrack = db.prepare('INSERT INTO audio_tracks (id, site_id, title, artist, duration, media_id, fedi_open) VALUES (?,?,?,?,?,?,?)');
|
|---|
| 30 | insMedia.run('m1', 's1', 'een.mp3', 'audio/een.mp3', 'audio/mpeg');
|
|---|
| 31 | insMedia.run('m2', 's1', 'twee.mp3', 'audio/twee.mp3', 'audio/mpeg');
|
|---|
| 32 | insTrack.run('t1', 's1', 'Open nummer', 'De Band', 200, 'm1', 1);
|
|---|
| 33 | insTrack.run('t2', 's1', 'Dicht nummer', 'De Band', 180, 'm2', 0);
|
|---|
| 34 |
|
|---|
| 35 | // Twee playlists op band, een op ander. Expliciete created_at: de lijst
|
|---|
| 36 | // sorteert erop, en twee inserts in dezelfde seconde maken die volgorde
|
|---|
| 37 | // anders een muntworp.
|
|---|
| 38 | db.prepare("INSERT INTO playlists (id, site_id, title, kind, created_at) VALUES ('eerste','s1','Eerste Plaat','album','2026-01-01 00:00:00')").run();
|
|---|
| 39 | db.prepare("INSERT INTO playlists (id, site_id, title, kind, created_at) VALUES ('tweede','s1','Tweede Plaat','album','2026-02-01 00:00:00')").run();
|
|---|
| 40 | db.prepare("INSERT INTO playlists (id, site_id, title, kind, created_at) VALUES ('vreemd','s2','Van De Ander','album','2026-03-01 00:00:00')").run();
|
|---|
| 41 | const insPT = db.prepare('INSERT INTO playlist_tracks (playlist_id, track_id, position) VALUES (?,?,?)');
|
|---|
| 42 | insPT.run('eerste', 't1', 1);
|
|---|
| 43 | insPT.run('eerste', 't2', 2);
|
|---|
| 44 |
|
|---|
| 45 | const app = express();
|
|---|
| 46 | app.use(routes);
|
|---|
| 47 | const server = app.listen(0);
|
|---|
| 48 | await new Promise((r) => server.once('listening', r));
|
|---|
| 49 | const base = `http://127.0.0.1:${server.address().port}`;
|
|---|
| 50 | const getJson = async (path, headers = {}) => {
|
|---|
| 51 | const r = await fetch(base + path, { headers: { Accept: 'application/activity+json', ...headers } });
|
|---|
| 52 | return { status: r.status, body: r.status === 200 ? await r.json() : null, headers: r.headers };
|
|---|
| 53 | };
|
|---|
| 54 |
|
|---|
| 55 | test('de actor wijst via streams naar de playlist-lijst', async () => {
|
|---|
| 56 | const { body } = await getJson('/ap/users/band');
|
|---|
| 57 | assert.deepEqual(body.streams, ['https://test.example/ap/users/band/playlists']);
|
|---|
| 58 | });
|
|---|
| 59 |
|
|---|
| 60 | test('de lijst is kaal standaard: URI-per-playlist, alleen van deze site, in vaste volgorde', async () => {
|
|---|
| 61 | const { body } = await getJson('/ap/users/band/playlists');
|
|---|
| 62 | assert.equal(body.type, 'OrderedCollection');
|
|---|
| 63 | assert.equal(body.totalItems, 2);
|
|---|
| 64 | assert.deepEqual(body.orderedItems, [
|
|---|
| 65 | 'https://test.example/ap/users/band/playlists/eerste',
|
|---|
| 66 | 'https://test.example/ap/users/band/playlists/tweede',
|
|---|
| 67 | ]);
|
|---|
| 68 | });
|
|---|
| 69 |
|
|---|
| 70 | test('verrijkt (FEP-9876) geeft stubs zonder tracks, en ook de stub telt alleen het open deel', async () => {
|
|---|
| 71 | const { body, headers } = await getJson('/ap/users/band/playlists', { Prefer: 'return=representation' });
|
|---|
| 72 | assert.equal(headers.get('preference-applied'), 'return=representation');
|
|---|
| 73 | assert.match(headers.get('vary') || '', /Prefer/);
|
|---|
| 74 | const stub = body.orderedItems[0];
|
|---|
| 75 | assert.equal(stub.name, 'Eerste Plaat');
|
|---|
| 76 | assert.equal(stub.totalItems, 1, 'een open en een gated track: de stub telt er een');
|
|---|
| 77 | assert.equal(stub.orderedItems, undefined, 'een stub draagt geen tracks');
|
|---|
| 78 | assert.equal(stub['@context'], undefined, 'genest object draagt de context van zijn omhulsel');
|
|---|
| 79 | assert.ok(!JSON.stringify(body).includes('Dicht nummer'), 'de gated titel lekt ook hier niet');
|
|---|
| 80 | });
|
|---|
| 81 |
|
|---|
| 82 | test('een lege site heeft een lege lijst, geen 404 -- de lijst zelf is niet geheim', async () => {
|
|---|
| 83 | const { status, body } = await getJson('/ap/users/ander/playlists');
|
|---|
| 84 | assert.equal(status, 200);
|
|---|
| 85 | assert.equal(body.totalItems, 1); // de eigen playlist van s2 staat er wel in
|
|---|
| 86 | });
|
|---|
| 87 |
|
|---|
| 88 | test('een post met [[playlist:id]] draagt een Link-tag naar de collectie', () => {
|
|---|
| 89 | const site = db.prepare("SELECT * FROM sites WHERE id = 's1'").get();
|
|---|
| 90 | const post = { id: 'p1', slug: 'p1', title: 'Luister', content: 'Nieuw album! [[playlist:eerste]] en nogmaals [[playlist:eerste]]', status: 'published' };
|
|---|
| 91 | const note = AP.buildNote('https://test.example', site, post);
|
|---|
| 92 | const links = (note.tag || []).filter((t) => t.type === 'Link');
|
|---|
| 93 | assert.equal(links.length, 1, 'dubbel insluiten geeft een tag');
|
|---|
| 94 | assert.equal(links[0].href, 'https://test.example/ap/users/band/playlists/eerste');
|
|---|
| 95 | assert.equal(links[0].name, 'Eerste Plaat');
|
|---|
| 96 | });
|
|---|
| 97 |
|
|---|
| 98 | test('een playlist van een ANDERE site levert geen tag -- de site-check is de tenancy-grens', () => {
|
|---|
| 99 | const site = db.prepare("SELECT * FROM sites WHERE id = 's1'").get();
|
|---|
| 100 | const post = { id: 'p2', slug: 'p2', title: 'Fout', content: 'Kijk: [[playlist:vreemd]]', status: 'published' };
|
|---|
| 101 | const note = AP.buildNote('https://test.example', site, post);
|
|---|
| 102 | assert.equal((note.tag || []).filter((t) => t.type === 'Link').length, 0);
|
|---|
| 103 | });
|
|---|
| 104 |
|
|---|
| 105 | test('een post zonder playlist heeft geen Link-tags', () => {
|
|---|
| 106 | const site = db.prepare("SELECT * FROM sites WHERE id = 's1'").get();
|
|---|
| 107 | const note = AP.buildNote('https://test.example', site, { id: 'p3', slug: 'p3', title: 'Los', content: 'Gewoon tekst met [[track:t1]]', status: 'published' });
|
|---|
| 108 | assert.equal((note.tag || []).filter((t) => t.type === 'Link').length, 0);
|
|---|
| 109 | });
|
|---|
| 110 |
|
|---|
| 111 | test.after(() => server.close());
|
|---|